From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Amit Prakash Shukla <amitprakashs@marvell.com>
Subject: Re: [EXT] [PATCH v2] graph: fix pcapng file support
Date: Mon, 12 Jun 2023 22:25:26 +0200 [thread overview]
Message-ID: <2604609.tIAgqjz4sF@thomas> (raw)
In-Reply-To: <PH0PR18MB5167E3CD8A2813D2BD192BC4C8499@PH0PR18MB5167.namprd18.prod.outlook.com>
> > The interface to rte_pcapng changed in last release
> > so that the interfaces used need to be added to the pcapng
> > file via the API. If this step is missing the pcapng
> > file will not be valid and can't be read by wireshark etc.
> >
> > Fixes: d1da6d0d04c7 ("pcapng: require per-interface information")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Looks good to me. Thanks.
>
> Acked-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Applied, thanks.
prev parent reply other threads:[~2023-06-12 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 19:08 [RFT] " Stephen Hemminger
2023-05-31 8:27 ` [EXT] " Amit Prakash Shukla
2023-05-31 17:27 ` [PATCH v2] " Stephen Hemminger
2023-06-01 11:22 ` [EXT] " Amit Prakash Shukla
2023-06-12 20:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2604609.tIAgqjz4sF@thomas \
--to=thomas@monjalon.net \
--cc=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).