From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6FB13A04DD;
Wed, 28 Oct 2020 08:34:35 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C4AF39AFD;
Wed, 28 Oct 2020 08:34:32 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AAB647CC8;
Wed, 28 Oct 2020 08:34:31 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 42BFB5C01AB;
Wed, 28 Oct 2020 03:34:30 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Wed, 28 Oct 2020 03:34:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
Y6ordMtbboDNihz5SEHqOi26zVeAfFUNnecRhtyaNQI=; b=ghmNkLoogWJfchq0
86y7dMy+A2GyVpaKFlKCvGhIgyqpfZnk1LY7959MkawqoHrudgf1/VHoIejnxrpd
RcjIW+Mx+5ftN26bECh8jLwhlyCSqYNdLDZQHPXy8KVAoLAQKQaaSx7YIM8glAro
0X+nSUWJuJrnq09fYCtfidYXQb7qZpUGovIfB8j9pzKFraziuMGIqi+smLWFVpJ9
9gjlD5OyIh+b2LQ2Epq5xMXgis0duGOskxAz2bJDeTQVb1EQ+3viw0ymfv+X9WKO
BuL1w1ESWK1USOL9npr2PCDoll/UwLm5rI8c7wn7PA4jvtkLTH7cgONGnxxqRPc9
lR6wOQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=Y6ordMtbboDNihz5SEHqOi26zVeAfFUNnecRhtyaN
QI=; b=I+rI6S/CAeRBXDdE5kjq/Q/pD1U2m/JEaFDnGpKdGDqOqROjHqC+Jma0u
IrTyn5SLBmGRIsb9YuRL9BM0bErSRUp+Bt+JNlBwz9iIEmaVHzFHO0TtS+xcolJx
ORYQKtlDm5Emwtp1ij45p0wKx9Y/PGXGQYNMDiE3QhDpS6MDCKL81pAgrT1KMtV3
OPsO2ZIMgSSHVEg3yWWp/E8cSbuWNj0KfN5kZQYu+pW4anWnd5RBAPxHdICUiuKh
10P27H6iugmHutDGLbf3ZOZslh81td/yj+ggUbnoxy6443b0a49KyhvfHv382XNt
5GcU8sAJJXEREcMfops/RhPR+gtlQ==
X-ME-Sender: <xms:Bh-ZX8uta0yf3jhwYzz-88DMD574iwGV25CJlQpV96tWZmWGWSg4Kg>
<xme:Bh-ZX5d9F9HABEhoCG8c73YKO4-wkZNmkaiboVsexU19jO_6Qkhq6oVm3MKsUXsB_
O2YYCSxQKPVjvELAw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledtgddutdejucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:Bh-ZX3x7atKYHaPLEv857hIeEo8UkkoQ94qu96VAqfsAzSteSZm3Yg>
<xmx:Bh-ZX_Nne-U30rvuqOM3C5H4FHj19RSvTuTKYN0EbBt5CSTh4-yLng>
<xmx:Bh-ZX89YN18pSBre4LGJSYdwiWvzJnUQhLKUL-GXq8Y7QwXHoBmJSw>
<xmx:Bh-ZX7ZF9pJyiMWnp3GCLx_KeXl_6b2DIlgv4ZLiDERi4d4PHCGM2Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 57AC83064610;
Wed, 28 Oct 2020 03:34:29 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@nvidia.com>
Cc: dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Tal Shnaiderman <talshn@nvidia.com>,
stable@dpdk.org
Date: Wed, 28 Oct 2020 08:34:28 +0100
Message-ID: <2604819.ZWI1aHImtR@thomas>
In-Reply-To: <20201027232335.31427-72-ophirmu@nvidia.com>
References: <20201027232335.31427-1-ophirmu@nvidia.com>
<20201027232335.31427-72-ophirmu@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 71/72] net/mlx5: fix Windows warnings on
get_if_name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
28/10/2020 00:23, Ophir Munk:
> From: Tal Shnaiderman <talshn@nvidia.com>
>
> Windows warns on missing function prototype get_if_name. To fix it -
> move the prototype to shared file mlx5.h and add missing definition
> IF_NAMESIZE to Windows mlx5_os.h file.
>
> Fixes: e9c0b96e3526 ("net/mlx5: move Linux ifname function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
[...]
> --- a/drivers/net/mlx5/windows/mlx5_os.h
> +++ b/drivers/net/mlx5/windows/mlx5_os.h
> @@ -21,4 +21,7 @@ enum {
> #ifndef ETOOMANYREFS
> #define ETOOMANYREFS 109 /* Too many references: cannot splice */
> #endif
> +#ifndef IF_NAMESIZE
> +#define IF_NAMESIZE 128
> +#endif
Should be in EAL.