From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63C21A00C2; Thu, 24 Nov 2022 18:26:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ABCE42DDC; Thu, 24 Nov 2022 18:26:54 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 4D81542DE3 for ; Thu, 24 Nov 2022 18:26:53 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E972A5C013B; Thu, 24 Nov 2022 12:26:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 24 Nov 2022 12:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669310812; x= 1669397212; bh=oXkM8YbFxXzYN13K2x4Z1+dpvYEXtQNe5gHxs9WFDNs=; b=P 9GGznnqYc1pXSK28TSowCCT80SNRr6407A1U8oujrO3wIlBYrNEZDdcvcN/S0qto 4PlpPdid6fdlSSbH1D47g9eGWduuycWu+Hb5Qe8of8V6mCuGOd/WU3+8xrz4RLFK 3XXeuLzYnEk3l/yzFXnq21HiKn2h/AxrtCdGeyWGvudvIdT/uX9N2AZKM6PA6Vm0 ASa1z/mKQT9QBUXL/scf/0a1BHcdkqTnGFYMkGGFiMQwBBLSlBeuCa937HoDM+ln aOejDsz/UoQMQL01bk9nJSlDBcE9/FthChL+Iq+MDmvFGllqYKDGvAJcfL+LgecV lGLiIWAvM8VFLPi7cLsgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669310812; x= 1669397212; bh=oXkM8YbFxXzYN13K2x4Z1+dpvYEXtQNe5gHxs9WFDNs=; b=f 13vn5DKUpy7xx9NuHj4UyhVhhPGxA76hZFiNxcUaQMiDku/rtp36Xms/Oz6KnfCs O7F8my2VfsOfDzYY82XvB/QLNlayIYR+g1WqZ7PRwhvoOfz4t46NVRviMXhbGeOE 3uZEEjlAbf2HoPztn6lEEV4mI/lMDiZ+BR4ems2bVVdFJpAtIjr5lGyuG+3J/CHk 4DIYf3mBrnF4yrqJjiXKD5t4unhWodwhxiS9AkBxFnm0cEqbMKe3NfebhFMPWvdX QJNK8U/Cf/0TZ3aY05/viA3n5/yvFu2r5F7fOnhxl8Ifz1+M74t5Gla1wtXvnTZ6 24Ut6vO2YfhioZnzgRGnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 12:26:51 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, Bruce Richardson Subject: Re: [PATCH v5] mailmap: add file to DPDK Date: Thu, 24 Nov 2022 18:26:50 +0100 Message-ID: <2605498.Isy0gbHreE@thomas> In-Reply-To: <3e2daacc-a306-dee9-9611-68b8327d599f@amd.com> References: <20201020130722.304989-1-bruce.richardson@intel.com> <20221124154401.3562903-1-david.marchand@redhat.com> <3e2daacc-a306-dee9-9611-68b8327d599f@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2022 18:21, Ferruh Yigit: > On 11/24/2022 3:44 PM, David Marchand wrote: > > From: Bruce Richardson > > > > Since a number of contributors to DPDK have submitted patches to DPDK > > under more than one email address, we should maintain a mailmap file to > > properly track their commits using "shortlog". > > > > It also helps fix up any mangled names, for example, with > > surname/firstname reversed, or with incorrect capitalization. > > By keeping this file in the DPDK repository, rather than committers > > maintaining their own copies, it allows individual contributors to edit > > it to update their own email address preferences if so desired. > > > > While at it, update our checkpatches.sh script and add some > > documentation to help new contributors. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: David Marchand > > <...> > > > @@ -148,6 +148,9 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines > > > > * Follow the :ref:`coding_style` guidelines. > > > > +* If you are a new contributor, or if your mail address changed, please update the ``.mailmap`` file. > > There is no benefit for new contributors to update .mailmap file, but it > adds another thing to update. > > I think it is simpler to keep .mailmap only for users that has multiple > email address in the git repo, and ask only from contributors in this > catagory to update the .mailmap instead of all contributors. We are doing checks on name and email. Typos are very common. So we are maintaining such a file privately. We would like to make it public so people can change it if needed. If it looks a problem for newcomers, we can reword the doc to say if they are missing in the file and not added themselves, it will be added with their first patch by maintainers. Is it better?