From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9FC84A0C41;
	Fri,  5 Nov 2021 21:46:26 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 30A7C40DFD;
	Fri,  5 Nov 2021 21:46:26 +0100 (CET)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id AD1D740151
 for <dev@dpdk.org>; Fri,  5 Nov 2021 21:46:24 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 0E0123201A3C;
 Fri,  5 Nov 2021 16:46:22 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Fri, 05 Nov 2021 16:46:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 iazudnQB4aRYI3/E3kDgns3/i1TfbqkAPGf23pnAf/c=; b=jZm7bDYDUrhttcB0
 RmuI/vHL9DFggM+3HMuMY6s1IznC7joDrDCGBNHBAfGyvxuAfsGoRVkWDEo1knmD
 8qHQOhbRDVv7mUbDS9XOTyZjZ8jylRKzI+/x0X1NBMliy/CgiO/8v4mYZcCpKiws
 ZJLBroNlsTfxSSkHozz/Vr00j+cbcK1f7+AtpwbdY8RimwebHfWk2EF9YjoHBUOc
 hEX9g7t8BYcH1WHhM3ecu0IVo/RGqa522TKRB69ldSVsSRJoyjtvMMa0W8bkKih7
 fVo7SFuS8iMgiO+nKI2JWclRcnBU3D8ISqUS92oxNTtEkXDrUYUus07/DY7vdQJ/
 /847Dg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=iazudnQB4aRYI3/E3kDgns3/i1TfbqkAPGf23pnAf
 /c=; b=mq8InxXQuqXTHY4tXpT3NoNyTss3LCsrE8pvVRp77aMWd34FFat0OmHjw
 sRbcqYpWQD44jGwaribSp2w/HC78Pxutn8mHVwoEx2OTEIaIgNqBNEyylZGhJ/Yi
 vnSOidkEWiNbzSC5pq+KCMb4vo9vObL0W4uWYvRc3QEti/sy/yNFmqfYrNVMQW6C
 p49719nxhNB+LJ5x9gt4fRELLSwKjeZAxnVEP7zOSGpSPaCDe2geCXXV20nNyTlw
 zAKmfjxTvPtqeGWMyTMxCGQpFqywyYqU2+IYOAXonokUl+72P3z+sU5Sjfx5Xw5S
 vTUwzZyVj+nIWc7oDQzwtTXPThbkQ==
X-ME-Sender: <xms:HpiFYcTWwHkJZnt8mPcrgUKkLFegD-jkIzKWunzqjoKYA5zDMf3kTg>
 <xme:HpiFYZyltVRbmmyt6qQE3twPsUufHGG-wAKuJS_1MQgB9Z-sWa3X_tMRM17S3K0jA
 GmMu6s86xWh8DwaXQ>
X-ME-Received: <xmr:HpiFYZ0DUi9qgf1aEGCwMwR04mta6zVxzCUGdb-_z0FX2OjS7Ighi38GmeFRA0hp7d-vopcoWQZcg0vwPQRKq_soIQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeigddufeekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:HpiFYQAEypSlQeDLWIrJwJ1UmC48KxFQ3oFs63doWF0e33uMLtwGqg>
 <xmx:HpiFYVh438Vs1nC8JhLSk5nP3DVagK3RQs67dMpuyA06Y6PA6SnbEQ>
 <xmx:HpiFYcrpS8iqaOAG1aUvX8XLIoRUuaFLlWqfUfZFnLe3n7ph8WCqYw>
 <xmx:HpiFYTY1gnc6IZc1kV7Ly6Di-Z45Mly-WRLj-K4yXElJkZGpQnhNHg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 5 Nov 2021 16:46:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Fan Zhang <roy.fan.zhang@intel.com>, Kai Ji <kai.ji@intel.com>
Cc: dev@dpdk.org, gakhil@marvell.com,
 Arek Kusztal <arkadiuszx.kusztal@intel.com>, david.marchand@redhat.com,
 ferruh.yigit@intel.com
Date: Fri, 05 Nov 2021 21:46:19 +0100
Message-ID: <2607407.E0SPF39NIo@thomas>
In-Reply-To: <5995285.MEobBQfBtn@thomas>
References: <20211027155055.32264-1-kai.ji@intel.com>
 <20211104103457.20264-10-kai.ji@intel.com> <5995285.MEobBQfBtn@thomas>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-dev v8 9/9] crypto/qat: add gen specific
 implementation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/11/2021 21:39, Thomas Monjalon:
> 04/11/2021 11:34, Kai Ji:
> > From: Fan Zhang <roy.fan.zhang@intel.com>
> > 
> > This patch replaces the mixed QAT symmetric and asymmetric
> > support implementation by separate files with shared or
> > individual implementation for specific QAT generation.
> > 
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > Acked-by: Ciara Power <ciara.power@intel.com>
> [...]
> > +++ b/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c
> > +#include "qat_sym_session.h"
> > +#include "qat_sym.h"
> > +#include "qat_sym_session.h"
> > +#include "qat_crypto.h"
> > +#include "qat_crypto_pmd_gens.h"
> 
> I suppose the double include of qat_sym_session.h is useless...

Note: it can be detected with devtools/check-dup-includes.sh

Other avoidable issues in this series detected with devtools/check-meson.py:

Error: Missing trailing "," in list at drivers/common/qat/meson.build:56
Error parsing drivers/common/qat/meson.build:74, got some tabulation

I expect such basic issues to be solved by the component maintainers,
or at last, by the tree maintainer. This time I will fix it.