DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH v8 00/47] TruFlow update for Thor2
Date: Tue, 12 Nov 2024 12:00:33 +0100	[thread overview]
Message-ID: <26077598.hxa6pUQ8Du@thomas> (raw)
In-Reply-To: <CACZ4nhumH+OW5CdnZhZRv1oGOhW04WjmwAy71bC-GwYzsShODQ@mail.gmail.com>

08/11/2024 03:14, Ajit Khaparde:
> On Thu, Nov 7, 2024 at 6:05 PM Sriharsha Basavapatna
> <sriharsha.basavapatna@broadcom.com> wrote:
> > > v7->v8:
> > > Changed logging macros CFA_TCAM_MGR_TRACE()->PMD_DRV_LOG_LINE()
> > > Fixed the following checkpatch warnings:
> > >   Writing to stdout or stderr
> > >   Using __atomic_xxx/__ATOMIC_XXX built-ins,
> > >         prefer rte_atomic_xxx/rte_memory_order_xxx
> > > Added Fixes: tag and Cc: stable@dpdk.org for some patches
> > >
> >
> > There are a couple of patches with warnings about "Prefer
> > RTE_LOG_LINE" and "Do not use variadic argument pack in macros".
> > We haven't fixed these, since it involves a lot of changes. We will
> > fix them in a separate clean-up patch after this patchset is merged.

log and variadic are OK to be cleaned later.
But I cannot merge with SPDX issues, rte_flow doc not updated, __builtin functions.

> Apart from this, I have addressed the spelling errors,
> errors in meson, updates to the rte_flow items and actions list
> while merging.
> 
> Patchset rebased on dpdk main tree and applied to
> dpdk-next-net-brcm main and for-next-net branch.
> Please apply.

I still see these errors from next-net-brcm/for-next-net:

SPDX tag missing in 38 files

rte_flow doc out of sync for bnxt
        item geneve
        item vxlan_gpe
        action set_ipv6_dst
        action set_ipv6_src
        action set_ttl

Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE

Using __builtin helpers, prefer EAL macros

Do not use variadic argument pack in macros

Error: Incorrect indent at drivers/net/bnxt/tf_core/v3/meson.build
Error: Missing trailing "," in list at drivers/net/bnxt/tf_core/v3/meson.build:33
Error parsing drivers/net/bnxt/hcapi/cfa_v3/meson.build, got some tabulation
Error: Incorrect indent at drivers/net/bnxt/hcapi/cfa_v3/meson.build
Error parsing drivers/net/bnxt/tf_ulp/meson.build, got some tabulation
Error parsing drivers/net/bnxt/tf_ulp/generic_templates/meson.build, got some tabulation

+drivers/net/bnxt/tf_core/v3/tfc_global_id.c: duplicated include: tfc.h
+drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c: duplicated include: bnxt.h
+drivers/net/bnxt/tf_core/v3/tfc_tcam.c: duplicated include: tfc.h

Is it candidate for Cc: stable@dpdk.org backport?
        net/bnxt: fix issue reading sff8436 sfp eeproms
        net/bnxt: tf_ulp: fixed parent child db counters

Contributor name/email mismatch with .mailmap: 
        Peter Morrow <peter@graphiant.com> is unknown in .mailmap
        Vasuthevan Maheswaran <vasuthevan.maheswaran@broadcom.com> is unknown in .mailmap

'resoure' may be misspelled - perhaps 'resource'?
'Recrod' may be misspelled - perhaps 'Record'?
'adn' may be misspelled - perhaps 'and'?
'decorder' may be misspelled - perhaps 'decoder'?
'retreved' may be misspelled - perhaps 'retrieved'?
'Foward' may be misspelled - perhaps 'Forward'?
'modfication' may be misspelled - perhaps 'modification'?
'pupose' may be misspelled - perhaps 'purpose'?
'inluding' may be misspelled - perhaps 'including'?
'explicity' may be misspelled - perhaps 'explicitly'?
'Conifiguration' may be misspelled - perhaps 'Configuration'?
'wit' may be misspelled - perhaps 'with'?
'spefific' may be misspelled - perhaps 'specific'?
'thorugh' may be misspelled - perhaps 'through'?
'hve' may be misspelled - perhaps 'have'?
'localy' may be misspelled - perhaps 'locally'?
'singe' may be misspelled - perhaps 'single'?
'faeture' may be misspelled - perhaps 'feature'?
'paranthesis' may be misspelled - perhaps 'parenthesis'?
'firmwware' may be misspelled - perhaps 'firmware'?




      reply	other threads:[~2024-11-12 11:00 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 13:52 Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 02/47] net/bnxt: tf_core: tcam manager data corruption Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 03/47] net/bnxt: tf_core: External EM support cleanup Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 04/47] net/bnxt: tf_core: Thor TF EM key size check Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 05/47] net/bnxt: tf_core: flow scale improvement Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 06/47] net/bnxt: tf_core: TF support flow scale query Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 08/47] net/bnxt: tf_core: convert priority based TCAM manager to dynamic allocation Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 09/47] net/bnxt: tf_core: remove dead AFM code from session-based priority TCAM mgr Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 10/47] net/bnxt: tf_core: remove dead " Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 11/47] net/bnxt: tfc: support tf-core for Thor2 Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 12/47] net/bnxt: tf_ulp: add vxlan-gpe base support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 13/47] net/bnxt: tf_ulp: add custom l2 etype tunnel support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 14/47] net/bnxt: tf_ulp: add support for vf to vf flow offload Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 15/47] net/bnxt: tf_ulp: Wh+ mirroring support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 16/47] net/bnxt: tf_ulp: miscellaneous fixes Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 17/47] net/bnxt: tf_ulp: support for Thor2 ulp layer Sriharsha Basavapatna
2024-12-10 13:32   ` David Marchand
2024-11-07 13:52 ` [PATCH v8 18/47] net/bnxt: tf_ulp: add support for overlapping flows Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 19/47] net/bnxt: tf_ulp: convert recipe table to dynamic memory Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 20/47] net/bnxt: tf_ulp: add feature bit support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 21/47] net/bnxt: tf_ulp: add action read and clear support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 22/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 23/47] net/bnxt: tf_ulp: VFR updates for Thor 2 Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 24/47] net/bnxt: tf_ulp: add support for tunnel flow stats Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 25/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 26/47] net/bnxt: tf_ulp: enable recipe id generation Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 27/47] net/bnxt: tf_ulp: fixed parent child db counters Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 28/47] net/bnxt: tf_ulp: modify return values to adhere to C coding standard Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 29/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 30/47] net/bnxt: tf_ulp: add mask defaults when mask is not specified Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 31/47] net/bnxt: tf_ulp: add jump action support Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 32/47] net/bnxt: tf_ulp: add support for flow priority Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 33/47] net/bnxt: tf_ulp: support for dynamic tunnel ports Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 34/47] net/bnxt: tf_ulp: add rte_mtr support for Thor2 Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 35/47] net/bnxt: tf_ulp: TF support flow scale query Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 36/47] net/bnxt: tf_ulp: add support for rss flow query to ULP Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 37/47] net/bnxt: tf_ulp: add track type feature to tables Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 38/47] net/bnxt: tf_ulp: inline utility functions and use likely/unlikely Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 40/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 41/47] net/bnxt: tf_ulp: support a few generic template items Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 42/47] net/bnxt: tf_ulp: TFC support flow scale query for Thor2 Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 43/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 44/47] net/bnxt: tf_ulp: enable support for truflow feature configuration Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 45/47] net/bnxt: tf_ulp: support a few feature extensions Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 46/47] net/bnxt: tf_ulp: update template files Sriharsha Basavapatna
2024-11-07 13:52 ` [PATCH v8 47/47] net/bnxt: tf_ulp: add stats cache for thor2 Sriharsha Basavapatna
2024-11-08  2:05 ` [PATCH v8 00/47] TruFlow update for Thor2 Sriharsha Basavapatna
2024-11-08  2:14   ` Ajit Khaparde
2024-11-12 11:00     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26077598.hxa6pUQ8Du@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).