From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B60F345CF4; Tue, 12 Nov 2024 12:00:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D98F42D91; Tue, 12 Nov 2024 12:00:38 +0100 (CET) Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by mails.dpdk.org (Postfix) with ESMTP id 7899E427AC for ; Tue, 12 Nov 2024 12:00:36 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id B25FF25401B6; Tue, 12 Nov 2024 06:00:35 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 12 Nov 2024 06:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731409235; x=1731495635; bh=xacgFkKaloxFGHK2MuaHO0HQcLh6WXOuW3Bl8+wYHYo=; b= WBeq01OJOwIyAk57OEW9SzRL6p8XcH1bqKIG/huOPS2IJxlCm/RZf+K0+ZNTY1GU /RAWiEaC8P3JrNHJtueaC7Vj29ZBaKAMn788owoy5WbIPFW0VQ9tqgdGfdo7yzjd 7EU1hIj4rRtovNZnmkSxBaMbrk4LnR8WHQnNOIw567rbe/nc3IL2ho6xVMR7oFUS WlN55lb9OKEhR0spx+XRHjRS7ExjucmP9M2BBoP228hCIwE+Q4opGbuKnugDN54x ++SLwfbh3BbcmjhYRnuOXEn+n1EfdezchPN9EMlATk9dby+0HRXC7oxDgL1EDB48 f2B6yNzNXSzzWu4H8uuSpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731409235; x= 1731495635; bh=xacgFkKaloxFGHK2MuaHO0HQcLh6WXOuW3Bl8+wYHYo=; b=a MaEXFnWNtlb1jHbQ4rhogeQtHJ5XSOH0aImKExSI0dbTnZ9e+795YtvGVJj8yDWf rGBiNVhIn58n4+cdApNO+BFYq47ZJM4F+wRR3MYqgMTOEa0M4C2110ZIqUI2YFa6 88jZ13vUassbh2Lf7S3UKFebHCONUy2N150q6pHJ/9vJVi5u4M7sZda9Mf4K/tqG ev808f8uthuncdyRwwOzG7AX10DxFow+PRdljZIm9A+NHjMWXHCuG1OpsqZwOd/8 4bRjdIcR3MOvuvnIYwKhsQYhN/SWnOS/HvJFrT6ctD8RGtte7SPa4aiIZVZ1JAyQ 0MHl4ngQqQHGReEujE9mw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeggddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdeh vedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhrihhhrg hrshhhrgdrsggrshgrvhgrphgrthhnrgessghrohgruggtohhmrdgtohhmpdhrtghpthht oheprghjihhtrdhkhhgrphgrrhguvgessghrohgruggtohhmrdgtohhmpdhrtghpthhtoh epuggvvhesughpughkrdhorhhgpdhrtghpthhtohepuggrvhhiugdrmhgrrhgthhgrnhgu sehrvgguhhgrthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Nov 2024 06:00:34 -0500 (EST) From: Thomas Monjalon To: Sriharsha Basavapatna , Ajit Khaparde Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v8 00/47] TruFlow update for Thor2 Date: Tue, 12 Nov 2024 12:00:33 +0100 Message-ID: <26077598.hxa6pUQ8Du@thomas> In-Reply-To: References: <20241107135254.1611676-1-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/11/2024 03:14, Ajit Khaparde: > On Thu, Nov 7, 2024 at 6:05=E2=80=AFPM Sriharsha Basavapatna > wrote: > > > v7->v8: > > > Changed logging macros CFA_TCAM_MGR_TRACE()->PMD_DRV_LOG_LINE() > > > Fixed the following checkpatch warnings: > > > Writing to stdout or stderr > > > Using __atomic_xxx/__ATOMIC_XXX built-ins, > > > prefer rte_atomic_xxx/rte_memory_order_xxx > > > Added Fixes: tag and Cc: stable@dpdk.org for some patches > > > > > > > There are a couple of patches with warnings about "Prefer > > RTE_LOG_LINE" and "Do not use variadic argument pack in macros". > > We haven't fixed these, since it involves a lot of changes. We will > > fix them in a separate clean-up patch after this patchset is merged. log and variadic are OK to be cleaned later. But I cannot merge with SPDX issues, rte_flow doc not updated, __builtin fu= nctions. > Apart from this, I have addressed the spelling errors, > errors in meson, updates to the rte_flow items and actions list > while merging. >=20 > Patchset rebased on dpdk main tree and applied to > dpdk-next-net-brcm main and for-next-net branch. > Please apply. I still see these errors from next-net-brcm/for-next-net: SPDX tag missing in 38 files rte_flow doc out of sync for bnxt item geneve item vxlan_gpe action set_ipv6_dst action set_ipv6_src action set_ttl Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE Using __builtin helpers, prefer EAL macros Do not use variadic argument pack in macros Error: Incorrect indent at drivers/net/bnxt/tf_core/v3/meson.build Error: Missing trailing "," in list at drivers/net/bnxt/tf_core/v3/meson.bu= ild:33 Error parsing drivers/net/bnxt/hcapi/cfa_v3/meson.build, got some tabulation Error: Incorrect indent at drivers/net/bnxt/hcapi/cfa_v3/meson.build Error parsing drivers/net/bnxt/tf_ulp/meson.build, got some tabulation Error parsing drivers/net/bnxt/tf_ulp/generic_templates/meson.build, got so= me tabulation +drivers/net/bnxt/tf_core/v3/tfc_global_id.c: duplicated include: tfc.h +drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c: duplicated include: bnxt.h +drivers/net/bnxt/tf_core/v3/tfc_tcam.c: duplicated include: tfc.h Is it candidate for Cc: stable@dpdk.org backport? net/bnxt: fix issue reading sff8436 sfp eeproms net/bnxt: tf_ulp: fixed parent child db counters Contributor name/email mismatch with .mailmap:=20 Peter Morrow is unknown in .mailmap Vasuthevan Maheswaran is unkno= wn in .mailmap 'resoure' may be misspelled - perhaps 'resource'? 'Recrod' may be misspelled - perhaps 'Record'? 'adn' may be misspelled - perhaps 'and'? 'decorder' may be misspelled - perhaps 'decoder'? 'retreved' may be misspelled - perhaps 'retrieved'? 'Foward' may be misspelled - perhaps 'Forward'? 'modfication' may be misspelled - perhaps 'modification'? 'pupose' may be misspelled - perhaps 'purpose'? 'inluding' may be misspelled - perhaps 'including'? 'explicity' may be misspelled - perhaps 'explicitly'? 'Conifiguration' may be misspelled - perhaps 'Configuration'? 'wit' may be misspelled - perhaps 'with'? 'spefific' may be misspelled - perhaps 'specific'? 'thorugh' may be misspelled - perhaps 'through'? 'hve' may be misspelled - perhaps 'have'? 'localy' may be misspelled - perhaps 'locally'? 'singe' may be misspelled - perhaps 'single'? 'faeture' may be misspelled - perhaps 'feature'? 'paranthesis' may be misspelled - perhaps 'parenthesis'? 'firmwware' may be misspelled - perhaps 'firmware'?