From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B1FDA00C5; Thu, 15 Sep 2022 12:57:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 474874021D; Thu, 15 Sep 2022 12:57:42 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id D611940156 for ; Thu, 15 Sep 2022 12:57:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 73A5C5C014F; Thu, 15 Sep 2022 06:57:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 15 Sep 2022 06:57:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663239458; x= 1663325858; bh=CiJPos2K3cgGpv1Ee1UDAQn5e4Xgdq6xxHo+48AQ6yA=; b=p nSmDgZvdGpkUmS7uYMFoYhnvx2wjZgLZdJUlPPLFcwZUNdYhD67J/ty7K+/LAQkm ia2+4xutXAUFqv0/BCDLCTc32qS+lSmofowF3Y+Nhm2uUMRtROpoOzbjrYBizGms 46sZ8DRXuED2gnFhnIeS8W7K/gNmtHndJCEUgGlCPbkvJq95zcGpWn6X2GMLMcFN IXMgzcnLokJxObLmlRFf7dFbYX79MJnMpL6tvl9CRWzlPW6N+sehDIiXQWgosxIc q4YZXkfkneJ9lomAyjc0le1McvJqS2v493ky0YlEELDPXEa/ztElGoyR41VxLByn MNefHVrxrYfM9UCmMNX4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663239458; x= 1663325858; bh=CiJPos2K3cgGpv1Ee1UDAQn5e4Xgdq6xxHo+48AQ6yA=; b=G zKfwGjReALbVLETpCkDGMawo2/IgMHH8VDyETtbG23W6oSp/Ijc+gMKpnMz/vn4E 4vyL1ijtQ0+UtiDrDuqjUu55LZQm+BR59GT/EDrZJVxNtidU40s2k9ZpzuPW20lX UMf4NHW/RX+oFco18CnkSR61zR7UrnKsu20d4kslq14Dv6SLfTi1ZhxLYbuLg4Zc /C4Ztrld2CMXarHMiCi/I8e4vYRp3X91SfoNrd5Bt3kUEYQ2ac5uv6vROTw3pb1P beLiiYq1R91NkqHyfbrypEGvSeTQ7zGRmkDAjf3kxC5yl3OFxcMwfdDjOKysbnjS W6YBUxPiRfOWwNSp0kMHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 06:57:37 -0400 (EDT) From: Thomas Monjalon To: Hernan Vargas Cc: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, nicolas.chautru@intel.com, qi.z.zhang@intel.com, Maxime Coquelin Subject: Re: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency Date: Thu, 15 Sep 2022 12:57:34 +0200 Message-ID: <2608223.q0ZmV6gNhb@thomas> In-Reply-To: <86ecbc97-a280-903d-7ccb-62f3843c1f98@redhat.com> References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-35-hernan.vargas@intel.com> <86ecbc97-a280-903d-7ccb-62f3843c1f98@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/09/2022 12:31, Maxime Coquelin: > > On 8/20/22 04:31, Hernan Vargas wrote: > > Update meson files with FlexRAN SDK dependency. There is no reason for this commit. If the reason is that you need these dependencies for some features, it is better to introduce the dependency when you use it. Patches should be split per features, not per file. > > Signed-off-by: Hernan Vargas > > --- > > drivers/baseband/acc100/meson.build | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/drivers/baseband/acc100/meson.build b/drivers/baseband/acc100/meson.build > > index 9a1a3b8b07..3b934a25ca 100644 > > --- a/drivers/baseband/acc100/meson.build > > +++ b/drivers/baseband/acc100/meson.build > > @@ -1,6 +1,27 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2020 Intel Corporation > > > > +# check for FlexRAN SDK libraries > > +dep_dec5g = dependency('flexran_sdk_ldpc_decoder_5gnr', required: false) > > + > > +if dep_dec5g.found() > > + ext_deps += cc.find_library('libstdc++', required: true) > > + ext_deps += cc.find_library('libirc', required: true) > > + ext_deps += cc.find_library('libimf', required: true) > > + ext_deps += cc.find_library('libipps', required: true) > > + ext_deps += cc.find_library('libsvml', required: true) > > + ext_deps += dep_dec5g > > + ext_deps += dependency('flexran_sdk_ldpc_encoder_5gnr', required: true) > > + ext_deps += dependency('flexran_sdk_LDPC_ratematch_5gnr', required: true) > > + ext_deps += dependency('flexran_sdk_rate_dematching_5gnr', required: true) > > + ext_deps += dependency('flexran_sdk_turbo', required: true) > > + ext_deps += dependency('flexran_sdk_crc', required: true) > > + ext_deps += dependency('flexran_sdk_rate_matching', required: true) > > + ext_deps += dependency('flexran_sdk_common', required: true) > > + cflags += ['-DRTE_BBDEV_SDK_AVX2'] > > + cflags += ['-DRTE_BBDEV_SDK_AVX512'] > > +endif > > + > > deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci'] > > > > sources = files('rte_acc100_pmd.c') > > I think we should improve build coverage with stubs. > > For example, we could stub bblib_rate_dematching_5gnr(), and so all the > code under RTE_BBDEV_SDK_AVX512 ifdef in enqueue_ldpc_dec_one_op_cb() > would be built. Yes, having code built even when the proprietary dependency is missing, would help to track some issues. > It would even open the possibility to have open-source implementations > of these libraries if community feel the need. > > What do you think? > > Thanks, > Maxime