From: HongBo Zheng <zhenghongbo3@huawei.com> Fix assignment errors of ep_hgh_edpi in function parse_ep_config. Fixes: a137d012a0dd ("examples/l3fwd-power: support traffic pattern aware control") Cc: stable@dpdk.org Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> --- examples/l3fwd-power/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 0af8810..f8dfed1 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1748,7 +1748,7 @@ parse_ep_config(const char *q_arg) int hgh_edpi; ep_med_edpi = EMPTY_POLL_MED_THRESHOLD; - ep_hgh_edpi = EMPTY_POLL_MED_THRESHOLD; + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD; strlcpy(s, p, sizeof(s)); @@ -1771,7 +1771,7 @@ parse_ep_config(const char *q_arg) if (med_edpi > 0) ep_med_edpi = med_edpi; - if (med_edpi > 0) + if (hgh_edpi > 0) ep_hgh_edpi = hgh_edpi; } else { -- 2.7.4
Ping for review please.
21/04/2021 05:53, Min Hu (Connor):
> From: HongBo Zheng <zhenghongbo3@huawei.com>
>
> Fix assignment errors of ep_hgh_edpi in function parse_ep_config.
>
> Fixes: a137d012a0dd ("examples/l3fwd-power: support traffic pattern aware control")
> Cc: stable@dpdk.org
>
> Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> examples/l3fwd-power/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 0af8810..f8dfed1 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1748,7 +1748,7 @@ parse_ep_config(const char *q_arg)
> int hgh_edpi;
>
> ep_med_edpi = EMPTY_POLL_MED_THRESHOLD;
> - ep_hgh_edpi = EMPTY_POLL_MED_THRESHOLD;
> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
>
> strlcpy(s, p, sizeof(s));
>
> @@ -1771,7 +1771,7 @@ parse_ep_config(const char *q_arg)
> if (med_edpi > 0)
> ep_med_edpi = med_edpi;
>
> - if (med_edpi > 0)
> + if (hgh_edpi > 0)
> ep_hgh_edpi = hgh_edpi;
>
> } else {
>
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Ping for review please. > <snip> > 21/04/2021 05:53, Min Hu (Connor): > > From: HongBo Zheng <zhenghongbo3@huawei.com> > > > > + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD; <snip> > > > > + if (hgh_edpi > 0) > > ep_hgh_edpi = hgh_edpi; > > Changes looks good to me. Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com> Thanks, Reshma
On 13/5/2021 10:09 AM, Pattan, Reshma wrote:
>
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>> Ping for review please.
>>
> <snip>
>
>> 21/04/2021 05:53, Min Hu (Connor):
>>> From: HongBo Zheng <zhenghongbo3@huawei.com>
>>>
>>> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
> <snip>
>>> + if (hgh_edpi > 0)
>>> ep_hgh_edpi = hgh_edpi;
>>>
> Changes looks good to me.
>
> Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com>
>
>
> Thanks,
> Reshma
+1
Acked-by: David Hunt <david.hunt@intel.com>
13/05/2021 11:47, David Hunt:
> On 13/5/2021 10:09 AM, Pattan, Reshma wrote:
> >> 21/04/2021 05:53, Min Hu (Connor):
> >>> From: HongBo Zheng <zhenghongbo3@huawei.com>
> >>>
> >>> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
> > <snip>
> >>> + if (hgh_edpi > 0)
> >>> ep_hgh_edpi = hgh_edpi;
> >>>
> > Changes looks good to me.
> >
> > Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com>
> >
> >
> > Thanks,
> > Reshma
>
>
> +1
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks