From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 81E258E70 for <dev@dpdk.org>; Fri, 30 Oct 2015 12:37:58 +0100 (CET) Received: by wmeg8 with SMTP id g8so9655880wme.0 for <dev@dpdk.org>; Fri, 30 Oct 2015 04:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=EPhar4op2cm3astaTaneoGTsajmI8AhtxSLN6HUtEwI=; b=OtwYxcjdmMaKfoZNYtBMPNtRexJnrCyIWXSuABhu0H0oeMCF9VRbNXF77q+KQ3Lbqv YL7cPk7OYVA6n9RNuWKPSjLMTxjZq4OLC6k2PLwYKW8XXHUJ9rE9GkZteYm+9CsbkfSR U7087dGOCE73kQK4FNp7HX2T+6Et+q15OgTVfY2rZ5Ldv6VYvvXIM25X39SYY5v/pZwD qgKhR8BTOl3ZhPSZZ4+/5Ptl90OFe8PkdTrlrxj7kHMniD30jWZsJSF5C0ac7yF2oL+K 5XWqJKlN+59rZzQ8DF5PN80TGhfPt9+cXUCcJ4QD00JekVPVwJh5GCa7tEPnNg2FS1wR 2TyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=EPhar4op2cm3astaTaneoGTsajmI8AhtxSLN6HUtEwI=; b=VOzpTOFC41yIHEz7MD840Q92LeIPLkRT6QRUes5DvtfLtM2Y8pn8De6WAQ2IYHSKiu RzwPB7MmS1rbkWCorNhslyTf6Wivs+Tkml3ZJ9aQyRewq/rQUgshCyXY7reD5f7D8R1e Io0ZGr3KQFC3KGcQXuWcJ1e84YxtAdJGwLsVSDiQDNsaz3A+gE7Y8W1/KWckdWqx8XwS lMs8GQvtYuT11d0MeqXaoms65wUMU3VS3927JMcuUqFCmxD/ESGZi56lbw0e0mt8Thby MVX6RQ5WFd8TqUPPPDh2UN9OlmVZIBA+0yPF+47nk6D+9IqJpd/OaDRZqMIzl3AGr9yK w7+g== X-Gm-Message-State: ALoCoQkecWuVkun8LgCwNQToxGi5aDAWmIrcyjfQd4P9JyS+ykqIzf8ocUp9i2jGei7MYkqvZfVl X-Received: by 10.28.137.211 with SMTP id l202mr2693474wmd.18.1446205078379; Fri, 30 Oct 2015 04:37:58 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id lv4sm6609177wjb.43.2015.10.30.04.37.57 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Oct 2015 04:37:57 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Date: Fri, 30 Oct 2015 12:36:47 +0100 Message-ID: <2612413.4Q5Ch6HCxj@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C8409A2@IRSMSX108.ger.corp.intel.com> References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com> <2601191342CEEE43887BDE71AB97725836AB6EC2@irsmsx105.ger.corp.intel.com> <E115CCD9D858EF4F90C690B0DCB4D8973C8409A2@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 30 Oct 2015 11:37:58 -0000 2015-10-30 11:33, De Lara Guarch, Pablo: > > These 3 functions above are redefined for each PMD in your patch. > > I think it is worth to move it to the upper layer (rte_ethdev, rte_net) to avoid > > code duplication. > > Thanks > > Kinstantin > > We thought about that, but we didn't know what the best place was for them. > Looking at the functions in rte_ethdev, they look quite different compared to these ones, > so we thought it wasn't the appropriate place. Do you think that is the best place? You are talking about the timer conversions, right? It looks appropriate for EAL.