DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: oulijun <oulijun@huawei.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
Date: Wed, 24 Feb 2021 13:09:52 +0100
Message-ID: <2613370.aJkOJV8Rtk@thomas> (raw)
In-Reply-To: <b1c3bd89176540bda82940c1080019b7@pantheon.tech>

24/02/2021 12:55, Juraj Linkeš:
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > 24/02/2021 02:34, oulijun:
> > >
> > > 在 2021/2/10 17:41, Thomas Monjalon 写道:
> > > > 03/02/2021 13:46, Lijun Ou:
> > > >> From: Chengchang Tang <tangchengchang@huawei.com>
> > > >>
> > > >> Because of the '9ca2f16' have merged, the current hns3 pmd driver
> > > >> can not be directly complied on the kunpeng920 server board.
> > > >> Therefore, we need to fix the meson build.
> > > >> Besides, add kunpeng 920 SoC meson cross compile target.
> > > >>
> > > >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
> > > >
> > > > Why do you think this patch is fixing the one above?
> > > > It looks just a new config, not a fix. Am I missing something?
> > > >
> > > I'm sorry to see you so late. In the meantime, we are celebrating the
> > > Spring Festival. This patch fixes the problem. If the patch is not
> > > added, the latest version cannot be directly compiled on the Kunpeng
> > > 930 server board.In addition, the cross compilation configuration file is added.
> > 
> > Please can you explain what was removed which breaks your compilation?
> > 
> 
> I can explain what's changed and why we changed it.
> 
> The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build.
> The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.

There were already many fixes for that rework.
Please check if there are other missing updates.




  reply	other threads:[~2021-02-24 12:10 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
2021-02-10  9:41   ` Thomas Monjalon
2021-02-24  1:34     ` oulijun
2021-02-24  7:41       ` Thomas Monjalon
2021-02-24  9:17         ` oulijun
2021-02-24 10:24           ` Thomas Monjalon
2021-02-24 11:55         ` Juraj Linkeš
2021-02-24 12:09           ` Thomas Monjalon [this message]
2021-03-01 10:46             ` Juraj Linkeš
2021-03-05  1:36               ` oulijun
2021-03-22  1:01                 ` Min Hu (Connor)
2021-02-03 12:46 ` [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build Lijun Ou
2021-03-05  1:38 ` [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 oulijun
2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
2021-03-20  2:27     ` Min Hu (Connor)
2021-03-23  8:07     ` Ruifeng Wang
2021-03-23 13:51       ` oulijun
2021-03-23 15:40         ` Ruifeng Wang
2021-03-25  7:21           ` oulijun
2021-03-25  7:45             ` Ruifeng Wang
2021-03-25  7:56               ` oulijun
2021-03-25  8:10                 ` Ruifeng Wang
2021-03-26 12:40     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
2021-03-26 12:42     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
2021-03-25  7:48     ` Ruifeng Wang
2021-03-26 12:45       ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
2021-03-25  7:49     ` Ruifeng Wang
2021-03-26 12:46     ` Jerin Jacob
2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 " Lijun Ou
2021-04-16  9:57     ` [dpdk-dev] [PATCH V4 0/3] add Hisilicon kunpeng CPU support Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 2/3] config/arm: add kunpeng920 cross target Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 3/3] config/arm: add kunpeng930 " Lijun Ou
2021-04-19  8:10       ` [dpdk-dev] [PATCH V4 0/3] add Hisilicon kunpeng CPU support Thomas Monjalon
     [not found] ` <6032863.io6GlxzLMq@thomas>
     [not found]   ` <f0e55cbc-3b61-8858-a5e7-aeee9dc613c2@huawei.com>
     [not found]     ` <6796692.TXxtQ3U2Ta@thomas>
2021-03-25 13:26       ` [dpdk-dev] [Linuxarm] [PATCH V2 0/4] " oulijun
2021-03-25 14:40         ` Thomas Monjalon
2021-03-26  0:41           ` oulijun
2021-04-05 19:50             ` Honnappa Nagarahalli
2021-04-06  1:00               ` oulijun
2021-04-07  2:19                 ` Honnappa Nagarahalli
2021-04-08  3:30                   ` oulijun
2021-04-08  8:01                     ` Thomas Monjalon
     [not found] <mailman.4282.1614163031.25471.dev@dpdk.org>
2021-02-24 11:02 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Thierry Herbelot
2021-02-24 11:44   ` Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2613370.aJkOJV8Rtk@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=linuxarm@openeuler.org \
    --cc=oulijun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git