DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] scripts: fix commit check for empty list
@ 2016-07-08 17:50 Thomas Monjalon
  2016-07-10 14:35 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2016-07-08 17:50 UTC (permalink / raw)
  To: dev

When running check-git-log.sh on a clean tree it was complaining
of a wrong empty headline because '^[^:]*$' was matching.
It is fixed by matching at least one character with +.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/check-git-log.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 7d2c7ee..c2a3ac0 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -62,7 +62,7 @@ bad=$(echo "$headlines" | grep --color=always \
 	-e '\.$' \
 	-e '[,;!?&|]' \
 	-e ':.*_' \
-	-e '^[^:]*$' \
+	-e '^[^:]\+$' \
 	-e ':[^ ]' \
 	-e ' :' \
 	| sed 's,^,\t,')
-- 
2.7.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] scripts: fix commit check for empty list
  2016-07-08 17:50 [dpdk-dev] [PATCH] scripts: fix commit check for empty list Thomas Monjalon
@ 2016-07-10 14:35 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-07-10 14:35 UTC (permalink / raw)
  To: dev

2016-07-08 19:50, Thomas Monjalon:
> When running check-git-log.sh on a clean tree it was complaining
> of a wrong empty headline because '^[^:]*$' was matching.
> It is fixed by matching at least one character with +.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-10 14:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-08 17:50 [dpdk-dev] [PATCH] scripts: fix commit check for empty list Thomas Monjalon
2016-07-10 14:35 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).