From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B1DCA0518; Thu, 30 Jul 2020 12:42:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAF781BFE7; Thu, 30 Jul 2020 12:42:44 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id E159B11A2 for ; Thu, 30 Jul 2020 12:42:42 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 65957AC3; Thu, 30 Jul 2020 06:42:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 30 Jul 2020 06:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= vInU6jjvC0qF0At3T1Q3ot/MDVT6R4BimewujohZvjc=; b=LYilU7JV/E2aFjjZ BsvTrkXx/UELYvuHRj/5NBKTZIvOS3rMNu9hmbOT9XTnnvGDEaO+3cULmbEFZWqN c4oP55elAA+CgE+8AKQd9uRTGeJxCKNLENJWyFFp+V1jePhG2wwU71WM45qXu6Xi 19cyFrs1Rbi1QldXABrzfl/CeK+GS2Ur3c0k8NbJ8EiBin1QfeYnAgGOWHE/laEe LNA8gsgtQL/ryYEp/306gOItrVipHaj/ltTxM1is0u+o3mEoEvFRpPtNjA49favo tXo5vmuHFAJRWZMBdDOu/ApWMESvuMHJZscqlTQh/Sr9M0XX2QfLgNH6dYnPUxoQ ZUO1/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=vInU6jjvC0qF0At3T1Q3ot/MDVT6R4BimewujohZv jc=; b=POpvRxd7hy+BJD+OpZu6O9IWXex3ljJkOQGLJuwJY4X2/aaZRnlw6fT83 /gubTCqv2x4KS11XbO0qE8fDPt/OK3j6ooPZA6t7iKWOPZwAe9qysyYQxRGuxqhV PkgxGToLEb6AjVTCwijsJ05I8LXyo1J/XsauNXbzcKyDtV4ZwFbDQcpC2o22qlNw aiRWe2ZIhltCgmCl6Q5DkIijEnTbWsGxSzcCLe66R0VCPG+eMkc4Sbov7VFd1Pd1 xKTdUswoLySgvMTHnf7NrjKBMqBaSc+Puxs2ZhCN2aQDECpQyxQazD5xKJchJ3Ea C4BdrLdWL70/PBUGWpQvnirCwjg/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieeigdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 68FBB3280060; Thu, 30 Jul 2020 06:42:39 -0400 (EDT) From: Thomas Monjalon To: "yang_y_yi@163.com" , Yi Yang =?utf-8?B?KOadqOeHmikt5LqR5pyN5Yqh6ZuG5Zui?= Cc: "dev@dpdk.org" , "jiayu.hu@intel.com" , "yang_y_yi@163.com" , "olivier.matz@6wind.com" Date: Thu, 30 Jul 2020 12:42:38 +0200 Message-ID: <26165953.ALDsH63Fg3@thomas> In-Reply-To: References: <4b0e9a13cb870cfede99697988c1e139@sslemail.net> <10959143.08NVAeP5qT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] =?utf-8?b?562U5aSNOiBbUEFUQ0ggMi8zXSBtYnVmOiBjaGFuZ2Ug?= =?utf-8?q?free=5Fcb_interface_to_adapt_to_GSO_case?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2020 12:39, Yi Yang (=E6=9D=A8=E7=87=9A)-=E4=BA=91=E6=9C=8D=E5=8A=A1= =E9=9B=86=E5=9B=A2: > Thomas, do you mean I need to change the below files to add deprecation = notice about free_cb? No it should be a separate patch for announing the deprecation in 20.08. Below patches cannot be applied in 20.08. >=20 > doc/guides/rel_notes/deprecation.rst > doc/guides/rel_notes/release_20_08.rst >=20 > I'll use --cc-cmd devtools/get-maintainer.sh to send a new version includ= ing deprecation notice you mentioned. >=20 > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Thomas Monjalon [mailto:thomas@monjalon.net]= =20 > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B47=E6=9C=8830=E6=97=A5 = 18:17 > =E6=94=B6=E4=BB=B6=E4=BA=BA: yang_y_yi@163.com > =E6=8A=84=E9=80=81: dev@dpdk.org; jiayu.hu@intel.com; Yi Yang (=E6=9D=A8= =E7=87=9A)-=E4=BA=91=E6=9C=8D=E5=8A=A1=E9=9B=86=E5=9B=A2 ; yang_y_yi@163.com; olivier.matz@6wind.com > =E4=B8=BB=E9=A2=98: Re: [PATCH 2/3] mbuf: change free_cb interface to ada= pt to GSO case >=20 > 30/07/2020 11:56, yang_y_yi@163.com: > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_= mbuf *mi, struct rte_mbuf *m) > > RTE_ASSERT(m->shinfo !=3D NULL); > > =20 > > if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) =3D=3D 0) > > - m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque); > > + m->shinfo->free_cb(m, m->shinfo->fcb_opaque); > > } > > =20 > > /** > > diff --git a/lib/librte_mbuf/rte_mbuf_core.h=20 > > b/lib/librte_mbuf/rte_mbuf_core.h index 8cd7137..d194429 100644 > > --- a/lib/librte_mbuf/rte_mbuf_core.h > > +++ b/lib/librte_mbuf/rte_mbuf_core.h > > @@ -671,7 +671,7 @@ struct rte_mbuf { > > /** > > * Function typedef of callback to free externally attached buffer. > > */ > > -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void=20 > > *opaque); > > +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *,=20 > > +void *); >=20 > I think a deprecation notice is required in 20.08 in order to apply such = change in 20.11. >=20 > Please use --cc-cmd devtools/get-maintainer.sh when sending a patch. >=20 >=20 >=20