From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 23752CE7 for ; Mon, 18 Jul 2016 17:13:15 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id q128so12138835wma.1 for ; Mon, 18 Jul 2016 08:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=CQ4Fe10o5jaaLBtPRSa2ZbMPHzEdGAA/xRfJjgg8vuY=; b=SauNhzxt9KQhIXlc5ZdU6IlfNAJQLq1hK2GOYQTODkeJLaQ3WtteoKoM0ZgXJ56kwL 3IV9BpmeGIwy2PixZluPcV3t8AAM4eYVFHWGrYKLr+CFoJXT+4CnfR50caMyRW08m6dz dewFyuNmLW8ft9WMJwNSU/aC1EuJt1QST4WSBchRDCqkjbCCcK0Hi3/bBA7moUVFlGX3 x/Xlb/r3V27vg+QMWqTOivkLuSY4avVp7yPqJFtLeZ+hHlrBaj828I0kg3cE8QV+wFJj GKPmAaYWMcuYRu+buoQlQrlbKHr+1kTBkU7joTk3UcMxxiNPRxXjVJXFZg1Plt4efm+F Tu8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=CQ4Fe10o5jaaLBtPRSa2ZbMPHzEdGAA/xRfJjgg8vuY=; b=ESggh+QFVUIft7v6+3RcG/pvs4+wZw4M+eARZw7AsFOlao5LaJmAtsvDFAxoumFhyl GsU1UlzPMyKe1kZYbgj4GYEI+2mG6ar+2nyfuU6QjQNzdwvQBTmIqjCdu18X0GvfNq13 MoM1SrgXYqQ0YsBqt06ePIeW/O4y6h9OrZZJUIhynzUxmIwSmggZU3Z/4acXIgrF7mDg YSRRWKN+4Pnxa4aimwIwRgJDfAjahnypDOkizR+prYISMdBrX4/maWXwzdZBnrleF1xD CTCAS4IpnVhlzdU/tL5BoTRaBHORZgTogc1Q9HaUbN9fBMXHXguJwJiipNpnWQmyqZBa Q1ng== X-Gm-Message-State: ALyK8tKRgNUOpevZmDzFTU4/R8GBKtKwM+D0T/ZIqgyhrFjNEpjRA2btUQTewgsQlKl4JtLh X-Received: by 10.28.22.6 with SMTP id 6mr19465358wmw.55.1468854794884; Mon, 18 Jul 2016 08:13:14 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id fu9sm1762472wjb.11.2016.07.18.08.13.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 08:13:14 -0700 (PDT) From: Thomas Monjalon To: "Ido Barnea (ibarnea)" Cc: dev@dpdk.org, Helin Zhang , Konstantin Ananyev Date: Mon, 18 Jul 2016 17:13:13 +0200 Message-ID: <2620065.kVZaRD93r7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <50DD7300-C300-4862-AEDB-B148206013AD@cisco.com> References: <20160718133630.58012-1-ibarnea@cisco.com> <24085954.MYZGtIaJgz@xps13> <50DD7300-C300-4862-AEDB-B148206013AD@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 15:13:15 -0000 2016-07-18 14:12, Ido Barnea: > In Trex, we do include ixgbe_type.h from c++ code because we do some > register writes ourselves to support some functionality not exposed in > the DPDK API. I agree we should find a way to expose some driver-specific headers for very specific features which will never be implemented elsewhere. But ideally, we should try to fix the DPDK API. > We can continue making this change in our copy of the code only. Just > trying to align our code with the official version as much as possible, > and thought it might benefit others as well to make this c++ compatible. > Apart from this small change, c++ compilation is supported. OK. Other comment from the maintainers (cc) of this driver? PS: please avoid top-post. > On 18/07/2016, 4:54 PM, "Thomas Monjalon" wrote: > > >Hi, > > > >DPDK is a C code and do not support C++ compilation. > >Only the exposed headers have some C++ support requirements. > > > >> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 ++ > > > >Patching this file for C++ will be probably rejected, sorry. > > > >I'm interested to understand what is your need?