From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id C6159F977 for ; Sun, 15 Jan 2017 22:29:44 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c85so135173826wmi.1 for ; Sun, 15 Jan 2017 13:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=dyekHWbQp5Cwk5ZcirxBrh+KffRCkhRL7s9ZnzQXwTg=; b=Ek+EsC00kjDdFnWujktp3cBiVSBLkMEzZkPvcSuhh9EvPTQFCF8CYmFYqX4pqh74fA +WMS/yG63WWifXbW2brepL/WTDC7/aPnUzAvO5NYYXazvM8JMgDz7EI6yEeKnAJ0ZxGG 2nRJCQDumi2RCb948RoUoSE4jjvxKBxiKbHdDTYM0m/LG00yIJwCrdYbvzYnYAnzDakG 8yaqyfbc3UiBNluVvrfhrqPjrAzehQ0uqvsdXRx47uWXPUIxC7DEn9IdBYkzDqEWN/Ij yQm6gMGRsaZW1bFrxmbpAcrbGd2FeUBDU6vmfyW+hZo3m+MjnH0o4oLrsYPY1dG+q0sj wl1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=dyekHWbQp5Cwk5ZcirxBrh+KffRCkhRL7s9ZnzQXwTg=; b=BhqhEK7528uZS+d53hM3Rf3MP7quhqFGDd93nCMe1xXWKm/NZwpcnzRWrTwWMd1yIL mHel3zv3m/eg4QOQVIHIOIe33tfJ2RUxspo8bWZiQ0DfrEHzN48KAJnwwEXlPqSoJ8w1 n5k+wQpAABzQHKYad77iMXhCz6Z2GpaaboleM4qw0UQZAXzxGtqTwFQnkJEhh4gLxsK0 47RiukxLOn+bUGsoZJGi4j31pXTxshAryqn0/Uh5o3C+RYea0C3ccF4nrKaONknowPnx HcBC1qTZvkJDWpmUAk7xS0vb6K/CMuOB8Z/VTWP159KbRIe10ngNBRCmZBR3EHdlCSWh MWyA== X-Gm-Message-State: AIkVDXK/LxTbeaEHBwtrvSXIQ/Qs4lQ3LlN3ID2f91Wf8Po12e0zsgIq4khQKs/IS1LOks6n X-Received: by 10.28.68.6 with SMTP id r6mr9404971wma.57.1484515784218; Sun, 15 Jan 2017 13:29:44 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 63sm23769186wmg.2.2017.01.15.13.29.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jan 2017 13:29:43 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@linaro.org, viktorin@rehivetech.com, santosh.shukla@caviumnetworks.com Date: Sun, 15 Jan 2017 22:29:42 +0100 Message-ID: <2622450.7mMCSCBjjk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484212646-10338-12-git-send-email-jerin.jacob@caviumnetworks.com> References: <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-12-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 11/29] eal: generic implementation for I/O device read/write access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2017 21:29:44 -0000 2017-01-12 14:47, Jerin Jacob: > +#define rte_read8_relaxed(addr) \ > + ({ uint8_t __v = *(const volatile uint8_t *)addr; __v; }) Why do you prefer a macro over an inline function? It won't provide the same "debuggability".