From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E11D51B207; Mon, 14 Jan 2019 15:22:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 775792C6E5; Mon, 14 Jan 2019 09:22:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 09:22:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dw12bpmU77Wg+xfAIGxii93/mJDQ5XSam8oRU+rSo5U=; b=MezQGfguglmv agRfEEyZ8thNK3CAThLOAveWoHRDPgCLL+qcLUr7yG44SkqNTBmO42mu/wBqLgLn p79d0dUj64vnbpvwBh/Wz7hzqozXGQyN4AlVbmniKX1f8DYnLMoBnsmQNOb4Ephm L7z75NHwnanS235exe6nJy3jNAAbxgc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dw12bpmU77Wg+xfAIGxii93/mJDQ5XSam8oRU+rSo 5U=; b=LK/LPy6jja4CbNAl2Bzy0MzyprkSsvaKY+/a2WAwb+O1DSO+KAx+fUM0Q kfpGxnoly1U8PIIzGV0K1ZdL+kkc68uFIFJmC3AOGr2W598W2hGcBy7/A2fWMrK+ grW3Ygoipu7j1vA5fAAgu1pDOx1txQgE3HJTM80zWfNezwiw+uAqx9JzoNZWDYuu B+KKoJhNpIcQRDNC4+RoHHuwrwfkP54lXbPzqcuoOMjZfrtUuLtrzdBFFmP8t9ow pE1Ba+G0aKF9FjHEqiS7EyNIdk1x8H69ZaGW5igPUgVCJbyKIHsMARfStI3csgjI weVbDHdbQQbkGGybOerptODcVkVEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D7F5A10106; Mon, 14 Jan 2019 09:22:57 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org Date: Mon, 14 Jan 2019 15:22:56 +0100 Message-ID: <26237186.kTPCeHV27o@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/bsdapp: don't clean up files at startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 14:23:00 -0000 10/01/2019 12:34, Anatoly Burakov: > On FreeBSD, closing the file descriptor drops the lock even if the > file descriptor was mmap'ed. This leads to the cleanup at the end > of EAL init to remove fbarray files that are still in use by the > process itself. > > However, instead of working around this issue, we can take advantage > of the fact that FreeBSD doesn't really create any per-process > files in the first place, so no cleanup is actually needed. > > Fixes: 0a529578f162 ("eal: clean up unused files on initialization") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks