From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAAF8A0521; Tue, 3 Nov 2020 05:56:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C12ADA8E9; Tue, 3 Nov 2020 05:56:35 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by dpdk.org (Postfix) with ESMTP id DA210A54B; Tue, 3 Nov 2020 05:56:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjMwB82GTJd/MDIGcveqZdRJYynB6bveQVTFtyg/orc=; b=j0DhlT5ZT2JSpqXqAkRC3KPl/PoXkxw0AVBfDoBZt/ZJ1zKkJT0c1uoCZn5u0HqFpLMTl2B6e7pC+uc7WgkBUEm+BlDu7dfbk1Nlq9jZP/SqNWQTvak1BElaAvzHht/xbB5qMrrPfSX69KodTU6qpf0WFYSAdnlMkYHf+TTWjC8= Received: from AM5PR0701CA0063.eurprd07.prod.outlook.com (2603:10a6:203:2::25) by DB7PR08MB3355.eurprd08.prod.outlook.com (2603:10a6:5:18::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 04:56:31 +0000 Received: from AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::49) by AM5PR0701CA0063.outlook.office365.com (2603:10a6:203:2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.10 via Frontend Transport; Tue, 3 Nov 2020 04:56:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT045.mail.protection.outlook.com (10.152.17.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 04:56:31 +0000 Received: ("Tessian outbound c579d876a324:v64"); Tue, 03 Nov 2020 04:56:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6586dbd418cdc93d X-CR-MTA-TID: 64aa7808 Received: from 7ff93d6ba75f.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9326ED59-9B27-4E87-974C-8E1766F8FD43.1; Tue, 03 Nov 2020 04:56:25 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ff93d6ba75f.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Nov 2020 04:56:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AxksYkos61coxI0knjwNXKX8iPrOv8s+JCxjtoKyWB8vGZliVHB8wWIzhLJiX1AW6NfwoPGHd+6nFAKzzr75llAU6YLDCtZRx/HE6qDxttFbrPtMcEmaP95/jQv2GESSP33Xn1DhtxBSXM5S5XiPWgH1ic/5K2saPlUoBfBYObEsa1gEe25ri6/FpI7d+nBxZgdhedfXWkfcEYwhTT2iDvRuCsUMLFpoTZMbbaojoXjv7oYht6ZYLR43YcHJ0L3SWr4LEWw2Yr6BJplgTzG1upa/hw1bfbenVlNP1CM23SnImgUoEUq58QHJ+mG3UMo6x3AMvbf157eqAMGeMXck1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjMwB82GTJd/MDIGcveqZdRJYynB6bveQVTFtyg/orc=; b=lg1Vz7sD8yYF9kRjQXawysZXl5l4havHhE+kxLPZsRcdsZwQWX3WbAd0QlE8+eccG1nNanm7S+FqLUj8NpnGPiJgTDCsAuXmIGstFYU0eOb1Y0qlpXKMaTtMGy4ibkDUKP7qkPOk6dH310te6CdF1V3rltgD2mkz/Br55uMxiiBGDlKG2oIqPsm6cC9xrZrScpUt2XncxFxv9UpMl1TSnw/aNgXwAK9IQODqQZ0ijsp5ni5o0xt2QJpB+7VJiRdzw+A4LdIfuavnScXRE467FVnc9xnWPrPSJHv1n8AQqMS2FDedyKdFf1sVGFKbchXmFVD6wuke0goiFFV4HgTyTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjMwB82GTJd/MDIGcveqZdRJYynB6bveQVTFtyg/orc=; b=j0DhlT5ZT2JSpqXqAkRC3KPl/PoXkxw0AVBfDoBZt/ZJ1zKkJT0c1uoCZn5u0HqFpLMTl2B6e7pC+uc7WgkBUEm+BlDu7dfbk1Nlq9jZP/SqNWQTvak1BElaAvzHht/xbB5qMrrPfSX69KodTU6qpf0WFYSAdnlMkYHf+TTWjC8= Received: from VI1PR08MB4622.eurprd08.prod.outlook.com (2603:10a6:803:bc::17) by VI1PR08MB3518.eurprd08.prod.outlook.com (2603:10a6:803:7a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 04:56:22 +0000 Received: from VI1PR08MB4622.eurprd08.prod.outlook.com ([fe80::e9cc:b2a4:eb77:980b]) by VI1PR08MB4622.eurprd08.prod.outlook.com ([fe80::e9cc:b2a4:eb77:980b%7]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 04:56:22 +0000 From: Dharmik Thakkar To: Honnappa Nagarahalli CC: Bruce Richardson , Vladimir Medvedkin , Ruifeng Wang , Gavin Hu , "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf Thread-Index: AQHWsXOSRxrJp0k7qkyV0zp4V0ynMKm1nFOAgAA8HoA= Date: Tue, 3 Nov 2020 04:56:22 +0000 Message-ID: <262639BF-81CC-4F9F-A402-844AC7CB98B9@arm.com> References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102235203.6342-1-dharmik.thakkar@arm.com> <20201102235203.6342-4-dharmik.thakkar@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [72.182.82.154] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8fd185ec-5904-45fe-c819-08d87fb4d4c0 x-ms-traffictypediagnostic: VI1PR08MB3518:|DB7PR08MB3355: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3826;OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ltJVT+MO7pnqlKuguoPzZ6pCW2ePB9mHMa6LLAYeX6W3gMnjdS8691NX6yTbdRTKXarALrAjMjuVicZ9b5W8k53Vuo9dv2ZcSIZh6uYfJhKiP3B9yg6bKEXJI2cymxNRpgSTLnWQFqPZ7qNzJLretEezKsKqP/5QQlRDFIxoIrUkK+9e8/fy78HPYxKpC1JYBe1WuQTQLz/AbzJMgAgDWicsPGxoDGpZefo5Zvfk9dH3eSfvwR82YTKNCBU0FOq1yH0pcjFAA3epb+sgkED7GMSjQB4VWrdlqOYWVYa1VhwgIR4Jguc3sjwgrawltGmH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB4622.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(8676002)(36756003)(37006003)(86362001)(316002)(6512007)(54906003)(8936002)(26005)(186003)(2616005)(4326008)(6636002)(6506007)(2906002)(53546011)(478600001)(6862004)(33656002)(64756008)(66946007)(66476007)(66556008)(91956017)(66446008)(76116006)(5660300002)(83380400001)(71200400001)(6486002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ISPH/AOhWToI7J1hSAxG84d9lrzN0L8K8mj8pb58eAb5f3Hte3sp8JBOfgk1tRonewq/1OFA54Mb0PGDJUOpfHoc+w9KJ5SDCNhV6gYTdVoOAj+rUZSStBF51DD6A1aXGHBe1H9YRA6AY/KF2GhTssI3H4GpPUVOeQ+j+TNLocct3nfc5Gj1S9v42HXMIU5z9AyxG69feQyekNQGKX4skk763FLmYBxnKvimQifchRItLyDPg1ob0KWotXGcuJgaDOISrWyjejr7EHVIgxU97UA4UylOWhk5uYwexN4wE4Z4Q+8v8r3svVnvXNhNwfvyBWGpYoWW45Yy6JCXJ3WS2LeKVxMXnTV/JxQ8kHZDrRijYcLg8hXDhR5bARIS8EXCFdQKvuDhiEZ0VkbClBsYhgAB4QvgvXokNuwSt4j6k7EK0hXgaTbOJpWwBX9j2SoIZ/F1W7Hr/69f9SmhlJO1VGbWK04/F0dZIHDA53VhuOnfZC5p+tAN+ds8SZQF1G6I9qvnwIv5mO3VHHILs/clrVUz20W9Z7yNd7uCViYFUTpk9RAc3bC/fmAp2UfaX29ZRWRXwvmMgK/cAKxpyviFxBk5aHCzSlSJS2Zrqaw7TlQQQKKfUUtLrvlQF6wdn+ev65UFklaLfNftpe1mnoA/Fg== Content-Type: text/plain; charset="us-ascii" Content-ID: <4D915C69B4DF7947A32CC824ED065EFD@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3518 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ee3fb086-46f4-4960-bb34-08d87fb4cf5a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DJVBzKqguj0onaJ3ArQndfIxQjnDe65cBp6vhUt3FUVp7tWU2iyz1RLkSLyHsaXR+yE6ILz14ev8G0aCXBBTjqh7GWGYCLxArdKNQZUlGVlSCAiZPXXvwFMn3+DzjamqhAnh5lN4H9bWjFXp4HfYJkj9WDSaAD1qz9YktGnq+CM1Jx9LClUgiypZK5+66Wub3IeFRollAHmpLRjl5xFVab8Jo/DMdWCR3GP6uOklUuGgrHQV+bjWlmFw+JEqHpqBKTgJFMlBOWmjplwOw0HLWYFWN+JJv5A5SiTNXPoyhIaw1lPCLXG3mpuzrwhQjZOVOXjPj0YhMo0CEjswIVwHnTSwRAHGifUtgUJRSroUAzt+jpxK2Fa463tMTH6v4F2ShXunno2Sxy4Prz0f9eukFg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(46966005)(6862004)(6636002)(33656002)(26005)(82310400003)(8676002)(5660300002)(53546011)(82740400003)(36906005)(478600001)(70586007)(81166007)(336012)(86362001)(37006003)(316002)(2906002)(54906003)(356005)(186003)(47076004)(6486002)(70206006)(6512007)(8936002)(83380400001)(4326008)(36756003)(6506007)(2616005)(450100002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 04:56:31.2240 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fd185ec-5904-45fe-c819-08d87fb4d4c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3355 Subject: Re: [dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 2, 2020, at 7:21 PM, Honnappa Nagarahalli wrote: >=20 > >=20 >>=20 >> Remove redundant error checking for reader threads since they never retu= rn >> error. >>=20 >> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") >> Cc: honnappa.nagarahalli@arm.com >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Ruifeng Wang >> --- >> app/test/test_lpm_perf.c | 21 ++++++++------------- >> 1 file changed, 8 insertions(+), 13 deletions(-) >>=20 >> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index >> 55084816ab91..224c92fa3d65 100644 >> --- a/app/test/test_lpm_perf.c >> +++ b/app/test/test_lpm_perf.c >> @@ -554,11 +554,10 @@ test_lpm_rcu_perf_multi_writer(void) >> __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED) >> / TOTAL_WRITES); >>=20 >> - /* Wait and check return value from reader threads */ >> writer_done =3D 1; >> + /* Wait until all readers have exited */ >> for (i =3D 2; i < num_cores; i++) >> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) >> - goto error; >> + rte_eal_wait_lcore(enabled_core_ids[i]); >>=20 >> rte_lpm_free(lpm); >> rte_free(rv); >> @@ -603,10 +602,9 @@ test_lpm_rcu_perf_multi_writer(void) >> / TOTAL_WRITES); >>=20 >> writer_done =3D 1; >> - /* Wait and check return value from reader threads */ >> + /* Wait until all readers have exited */ >> for (i =3D 2; i < num_cores; i++) >> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) >> - goto error; >> + rte_eal_wait_lcore(enabled_core_ids[i]); >>=20 >> rte_lpm_free(lpm); >>=20 >> @@ -710,10 +708,9 @@ test_lpm_rcu_perf(void) >> (double)total_cycles / TOTAL_WRITES); >>=20 >> writer_done =3D 1; >> - /* Wait and check return value from reader threads */ >> + /* Wait until all readers have exited */ >> for (i =3D 0; i < num_cores; i++) >> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) >> - goto error; >> + if (rte_eal_wait_lcore(enabled_core_ids[i]); > ^^ Do we need the 'if' statement? No, will remove in the next version. >>=20 >> rte_lpm_free(lpm); >> rte_free(rv); >> @@ -769,11 +766,9 @@ test_lpm_rcu_perf(void) >> (double)total_cycles / TOTAL_WRITES); >>=20 >> writer_done =3D 1; >> - /* Wait and check return value from reader threads */ >> + /* Wait until all readers have exited */ >> for (i =3D 0; i < num_cores; i++) >> - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) >> - printf("Warning: lcore %u not finished.\n", >> - enabled_core_ids[i]); >> + rte_eal_wait_lcore(enabled_core_ids[i]); >>=20 >> rte_lpm_free(lpm); >>=20 >> -- >> 2.17.1