DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Dharmappa, Savinay" <savinay.dharmappa@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] app: test: measure libipsec performance
Date: Fri, 06 Mar 2020 09:58:45 +0100	[thread overview]
Message-ID: <2628800.AiC22s8V5E@xps> (raw)
In-Reply-To: <SN6PR11MB25587EDC9518B4E0720F49F79AE20@SN6PR11MB2558.namprd11.prod.outlook.com>

05/03/2020 23:51, Ananyev, Konstantin:
> 
> > 05/03/2020 12:45, Ananyev, Konstantin:
> > > I think the header need to be "app/test", or "test/ipsec".
> > 
> > It should be "test/ipsec" as it is an IPsec test command
> > in the test application.
> > 
> > > Apart from that:
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > 
> > I wonder why we have a different maintainer for each IPsec test.
> > It looks a bit confusing.
> > 
> > IPsec - EXPERIMENTAL
> > M: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > T: git://dpdk.org/next/dpdk-next-crypto
> > F: lib/librte_ipsec/
> > M: Bernard Iremonger <bernard.iremonger@intel.com>
> > F: app/test/test_ipsec.c
> > F: doc/guides/prog_guide/ipsec_lib.rst
> > M: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > F: app/test/test_ipsec_perf.c
> > M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > F: app/test/test_ipsec_sad.c
> > F: app/test-sad/
> 
> I suppose mainly by historical reasons -
> each of these tests have different authors.
> Obviously each author claimed maintanership of his own code.
> Do you consider that as a problem?

Yes I consider a maintainer should know a whole area
and be the point of contact for this area.
For instance, when there is a bug with a test,
we don't know whether the problem is in the test or in the library.

Note that the original author can be found with the git history.

> > In general, only one person takes the responsibility to be
> > the main contact of any related question in the area.
> > 
> > So the file pattern could be:
> > F: app/test/test_ipsec*




  reply	other threads:[~2020-03-06  8:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 10:53 [dpdk-dev] [PATCH v1] " Savinay Dharmappa
2020-03-02 11:43 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2020-03-02 12:51   ` David Marchand
2020-03-02 14:40   ` Medvedkin, Vladimir
2020-03-03 15:34   ` Ananyev, Konstantin
2020-03-05  7:15   ` [dpdk-dev] [PATCH v3] " Savinay Dharmappa
2020-03-05 11:45     ` Ananyev, Konstantin
2020-03-05 17:11       ` Thomas Monjalon
2020-03-05 22:51         ` Ananyev, Konstantin
2020-03-06  8:58           ` Thomas Monjalon [this message]
2020-03-10 13:24             ` Ananyev, Konstantin
2020-03-10 20:14               ` Thomas Monjalon
2020-03-06  7:08     ` [dpdk-dev] [PATCH v4] test/ipsec: " Savinay Dharmappa
2020-04-19 21:43       ` Akhil Goyal
2020-04-21  2:29       ` Thomas Monjalon
2020-04-21  2:35         ` Thomas Monjalon
2020-04-21 10:21           ` Ananyev, Konstantin
2020-04-21 10:28             ` Thomas Monjalon
2020-04-21 11:07               ` Ananyev, Konstantin
2020-04-21 11:49                 ` Thomas Monjalon
2020-04-21 12:04                   ` Ananyev, Konstantin
2020-04-21 12:58                     ` Thomas Monjalon
2020-04-23 15:25       ` [dpdk-dev] [PATCH v5] " Savinay Dharmappa
2020-04-24 10:06         ` Ananyev, Konstantin
2020-05-09 21:46           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2628800.AiC22s8V5E@xps \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=savinay.dharmappa@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).