From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53AD5A2EEB for ; Tue, 10 Sep 2019 12:17:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A198C1EDB6; Tue, 10 Sep 2019 12:17:20 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0CE381EDB4 for ; Tue, 10 Sep 2019 12:17:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13207772CE; Tue, 10 Sep 2019 10:17:18 +0000 (UTC) Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 173F63737; Tue, 10 Sep 2019 10:17:08 +0000 (UTC) To: "Gavin Hu (Arm Technology China)" , "Wang, Yinan" , "Joyce Kong (Arm Technology China)" , "dev@dpdk.org" Cc: nd , "Bie, Tiwei" , "Wang, Zhihong" , "amorenoz@redhat.com" , "Wang, Xiao W" , "Liu, Yong" , "jfreimann@redhat.com" , Honnappa Nagarahalli , Steve Capper References: <1568020491-52462-1-git-send-email-joyce.kong@arm.com> <1568020491-52462-2-git-send-email-joyce.kong@arm.com> From: Maxime Coquelin Openpgp: preference=signencrypt Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <262f4f84-3ef4-32cc-ce1e-82c5ad7bbb61@redhat.com> Date: Tue, 10 Sep 2019 12:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 10 Sep 2019 10:17:18 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for packed vring desc avail flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Yinan for reporting the regresion and Gavin for the analysis. On 9/10/19 11:48 AM, Gavin Hu (Arm Technology China) wrote: > Hi Yinan, > > We have done a comparative analysis and found with the old code the if(weak_barriers) and else branches were saved on x86 as rte_smp_wmb and rte_cio_wmb are identical. > http://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtqueue.h#n49 > For the new code, with Joyce's patches applied, the branches were not saved, which requir additional cpu cycles, this caused slight degradation on x86. > > The patches uplifted the performance on aarch64 about 9% as indicated in the cover letter. While I am thinking over a solution to the degradation on x86,could you help answer: > 1. Is rte_cio_wmb is sufficient for the non weak-barrier case(HW offloading)? > I got this question because I see in Intel NIC PMDs, it is almost never used, it is rte_wmb that is more widely used to notify the NIC device, any difference between the virtio ring compatible smartNIC device(or vDPA?) and i40e like devices? > 2. If the rte_cio_wmb is not sufficient for this case and replaced by stronger barriers, like sfence, then the branches will not be saved by the compiler, then the problem becomes with the correct use of barriers, other than the degradation. > > Any comments are welcome! It may we worth that Yinan tries with rte_wmb instead of rte_cio_wmb without the series applied, just to confirm this is caused by the etra branch. Maxime > Best Regards, > Gavin > >> -----Original Message----- >> From: Wang, Yinan >> Sent: Tuesday, September 10, 2019 11:54 AM >> To: Maxime Coquelin ; Joyce Kong (Arm >> Technology China) ; dev@dpdk.org >> Cc: nd ; Bie, Tiwei ; Wang, Zhihong >> ; amorenoz@redhat.com; Wang, Xiao W >> ; Liu, Yong ; >> jfreimann@redhat.com; Honnappa Nagarahalli >> ; Gavin Hu (Arm Technology China) >> >> Subject: RE: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for packed vring >> desc avail flags >> >> >> Hi Joyce, >> >> I just test performance impact of your patch set with code base commit id: >> d03d8622db48918d14bfe805641b1766ecc40088, after applying your v3 patch >> set , seven paths of vhost/virtio pvp test shows performance drop as below: >> >> PVP vhost/virtio 1c1q test          before apply patch apply patch >> test_perf_pvp_inorder_mergeable 7.603 7.474 >> test_perf_pvp_inorder_no_mergeable 7.642 7.525 >> test_perf_pvp_mergeable 7.556 7.431 >> test_perf_pvp_normal 7.554 7.478 >> test_perf_pvp_vector_rx 7.581 7.469 >> test_perf_pvp_virtio11_mergeable 7.068 6.905 >> test_perf_pvp_virtio11_normal 7.088 6.888 >> >> Thanks, >> Yinan >> >>> -----Original Message----- >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin >>> Sent: 2019年9月9日 18:10 >>> To: Joyce Kong ; dev@dpdk.org >>> Cc: nd@arm.com; Bie, Tiwei ; Wang, Zhihong >>> ; amorenoz@redhat.com; Wang, Xiao W >>> ; Liu, Yong ; >>> jfreimann@redhat.com; honnappa.nagarahalli@arm.com; >> gavin.hu@arm.com >>> Subject: Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for packed >> vring >>> desc avail flags >>> >>> >>> >>> On 9/9/19 11:14 AM, Joyce Kong wrote: >>>> In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the >>>> frontend and backend are assumed to be implemented in software, that >>>> is they can run on identical CPUs in an SMP configuration. >>>> Thus a weak form of memory barriers like rte_smp_r/wmb, other than >>>> rte_cio_r/wmb, is sufficient for this case(vq->hw->weak_barriers == 1) >>>> and yields better performance. >>>> For the above case, this patch helps yielding even better performance >>>> by replacing the two-way barriers with C11 one-way barriers for avail >>>> flags in packed ring. >>>> >>>> Meanwhile, a read barrier is required to ensure ordering between >>>> descriptor's flags and content reads[1]. With C11, load-acquire can >>>> enforce the ordering instead of rmb barrier. >>>> >>>> [1]https://patchwork.dpdk.org/patch/49109/ >>>> >>>> Signed-off-by: Joyce Kong >>>> Reviewed-by: Gavin Hu >>>> Reviewed-by: Phil Yang >>>> --- >>>> drivers/net/virtio/virtio_rxtx.c | 13 +++++++------ >>>> drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 +++++- >>>> drivers/net/virtio/virtqueue.h | 11 +++++++++++ >>>> lib/librte_vhost/vhost.h | 2 +- >>>> lib/librte_vhost/virtio_net.c | 11 +++++------ >>>> 5 files changed, 29 insertions(+), 14 deletions(-) >>> >>> Reviewed-by: Maxime Coquelin >>> >>> Thanks, >>> Maxime