From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0D7AF1B59E for ; Thu, 10 Jan 2019 09:52:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 97A6D231A4; Thu, 10 Jan 2019 03:52:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 10 Jan 2019 03:52:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=N+QWp7YIgBEohTDB1rvo+RGivV8moK988JjXHpM9Pzw=; b=lO8zl1FI6HZj j6xC3cFDqh6Ub63cIwvU3q4B8E7dNvnMg5AnPcogOFy3Fm5HCEGNRKq4A5jJyGom MhvcD1O2KbGO5rx5fDE66C6MLfRPdnN28ARTb+WWRDchLhbLd2ywaN4vsdy3MiV/ qxWlR51XLDV6UII9F/eB+xwJbNH5MN8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=N+QWp7YIgBEohTDB1rvo+RGivV8moK988JjXHpM9P zw=; b=sPM3IQrythVDrWFWos8ssXb7MNALJkU/grMmUFKan2t5yyKXIHunKTUos 2JUsxLsQmGHWCw9+j78vBh/8igtimmbQALVJv1czqm1QldOeKQau1KGd/a6AOlYK VMZbwgvQlnPxjv/xqII1pUgjVc2vTQvQJddUteT6qh5lU4CKowEIVTxX2UfnEAoC C9PZghuJIKnyuwqS3qOyRkLhgL8jX21iQNHzvZltR+kjB9j+BdpgSCjfpXtqsKtJ g9AoFvCTlsoJieSyBCvAFPcPLT74EJ7YGCraBulZ42cnW6uO0NmAuzplLhOreJ9L bvKL+dQ2TQQH2f48cTBMuz7WpS57A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedvgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 50C6E10106; Thu, 10 Jan 2019 03:52:44 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: Bruce Richardson , David Marchand , dev@dpdk.org Date: Thu, 10 Jan 2019 09:52:43 +0100 Message-ID: <2632071.H5f8aPozaM@xps> In-Reply-To: References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <1557339.2CBSiR8abE@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 08:52:47 -0000 10/01/2019 09:45, Burakov, Anatoly: > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > 09/01/2019 21:51, Bruce Richardson: > >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > >>> On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > >>> <[1]anatoly.burakov@intel.com> wrote: > >>> > >>> Currently, while EAL does depend on librte_compat as far as common > >>> meson build is concerned, for some reason the headers for that > >>> library are not added into the list of includes. This is fixed in > >>> Linuxapp-specific meson file, but is absent from FreeBSD meson file. > >>> This worked fine up until recently, when an rte_compat dependency > >>> was added to rte_log, which is a common header. Fix this issue by > >>> adding librte_compat includes to common EAL meson file. > >>> Fixes: 844514c73569 ("eal: build with meson") > >>> Fixes: a8499f65a1d1 ("log: add missing experimental tag") > >>> Cc: [2]bruce.richardson@intel.com > >>> Cc: [3]david.marchand@redhat.com > >>> Cc: [4]stable@dpdk.org > >>> Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com> > >>> > >>> lgtm, thanks. > >>> Reviewed-by: David Marchand <[6]david.marchand@redhat.com> > >>> -- > >>> David Marchand > >>> > >> Agreed. > >> One other point I'd make is that having compat as a separate library seems > >> a little like overkill to me - it's just one header file! Is there a reason > >> why we don't just move it into the EAL where everyone can use it without > >> having to specify another dependency? > > > > +1 for moving compat into EAL. > > > > Presumably the reason to keep it separate would be to enable depending > on it for libraries that EAL itself depends on (i.e. kvargs). Yes, forgot this one.