[dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[Shahaf Shuler]

Update deprecation notice for the new ethdev offloads API.
Deprecation of the old offloads API is set to 18.05.

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 52058f580..deb546a67 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -41,12 +41,14 @@ Deprecation Notices
   PKT_RX_QINQ_STRIPPED, that are better described. The old flags and
   their behavior will be kept until 17.08 and will be removed in 17.11.
 
-* ethdev: Tx offloads will no longer be enabled by default in 17.11.
-  Instead, the ``rte_eth_txmode`` structure will be extended with
-  bit field to enable each Tx offload.
-  Besides of making the Rx/Tx configuration API more consistent for the
-  application, PMDs will be able to provide a better out of the box performance.
-  As part of the work, ``ETH_TXQ_FLAGS_NO*`` will be superseded as well.
+* ethdev: a new Tx and Rx offload API was introduced on 17.11.
+  In the new API, offloads are divided into per-port and per-queue offloads.
+  Offloads are disabled by default and enabled per application request.
+  The old offloads API is target to be deprecated on 18.05. This includes:
+
+  - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
+  - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
+  - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
 
 * ethdev: the legacy filter API, including
   ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well
-- 
2.12.0

Re: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[Shahaf Shuler]

Hi,

Any comments on this patch? Is there any objection to deprecation in 18.05? 

Tuesday, October 17, 2017 5:24 PM, Shahaf Shuler:
> Update deprecation notice for the new ethdev offloads API.
> Deprecation of the old offloads API is set to 18.05.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 52058f580..deb546a67 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,12 +41,14 @@ Deprecation Notices
>    PKT_RX_QINQ_STRIPPED, that are better described. The old flags and
>    their behavior will be kept until 17.08 and will be removed in 17.11.
> 
> -* ethdev: Tx offloads will no longer be enabled by default in 17.11.
> -  Instead, the ``rte_eth_txmode`` structure will be extended with
> -  bit field to enable each Tx offload.
> -  Besides of making the Rx/Tx configuration API more consistent for the
> -  application, PMDs will be able to provide a better out of the box
> performance.
> -  As part of the work, ``ETH_TXQ_FLAGS_NO*`` will be superseded as well.
> +* ethdev: a new Tx and Rx offload API was introduced on 17.11.
> +  In the new API, offloads are divided into per-port and per-queue offloads.
> +  Offloads are disabled by default and enabled per application request.
> +  The old offloads API is target to be deprecated on 18.05. This includes:
> +
> +  - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
> +  - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
> +  - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
> 
>  * ethdev: the legacy filter API, including
>    ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well
> --
> 2.12.0

Re: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[Andrew Rybchenko]

On 10/17/2017 05:24 PM, Shahaf Shuler wrote:
> Update deprecation notice for the new ethdev offloads API.
> Deprecation of the old offloads API is set to 18.05.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 52058f580..deb546a67 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,12 +41,14 @@ Deprecation Notices
>     PKT_RX_QINQ_STRIPPED, that are better described. The old flags and
>     their behavior will be kept until 17.08 and will be removed in 17.11.
>   
> -* ethdev: Tx offloads will no longer be enabled by default in 17.11.
> -  Instead, the ``rte_eth_txmode`` structure will be extended with
> -  bit field to enable each Tx offload.
> -  Besides of making the Rx/Tx configuration API more consistent for the
> -  application, PMDs will be able to provide a better out of the box performance.
> -  As part of the work, ``ETH_TXQ_FLAGS_NO*`` will be superseded as well.
> +* ethdev: a new Tx and Rx offload API was introduced on 17.11.
> +  In the new API, offloads are divided into per-port and per-queue offloads.
> +  Offloads are disabled by default and enabled per application request.
> +  The old offloads API is target to be deprecated on 18.05. This includes:
> +
> +  - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
> +  - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
> +  - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
>   
>   * ethdev: the legacy filter API, including
>     ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Re: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, October 17, 2017 3:24 PM
> To: nhorman@tuxdriver.com; thomas@monjalon.net
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API
> 
> Update deprecation notice for the new ethdev offloads API.
> Deprecation of the old offloads API is set to 18.05.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 52058f580..deb546a67 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,12 +41,14 @@ Deprecation Notices
>    PKT_RX_QINQ_STRIPPED, that are better described. The old flags and
>    their behavior will be kept until 17.08 and will be removed in 17.11.
> 
> -* ethdev: Tx offloads will no longer be enabled by default in 17.11.
> -  Instead, the ``rte_eth_txmode`` structure will be extended with
> -  bit field to enable each Tx offload.
> -  Besides of making the Rx/Tx configuration API more consistent for the
> -  application, PMDs will be able to provide a better out of the box performance.
> -  As part of the work, ``ETH_TXQ_FLAGS_NO*`` will be superseded as well.
> +* ethdev: a new Tx and Rx offload API was introduced on 17.11.
> +  In the new API, offloads are divided into per-port and per-queue offloads.
> +  Offloads are disabled by default and enabled per application request.
> +  The old offloads API is target to be deprecated on 18.05. This includes:
> +
> +  - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
> +  - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
> +  - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
> 
>  * ethdev: the legacy filter API, including
>    ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.12.0

Re: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

[Thomas Monjalon]

> > Update deprecation notice for the new ethdev offloads API.
> > Deprecation of the old offloads API is set to 18.05.
> > 
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks

[dpdk-dev] [PATCH] doc: reduce initial offload API scope to drivers

[Ferruh Yigit]

18.05 tagets ethdev-PMD offload API, which means switching all PMDs to
new offloading API

Next step targets ethdev-application offload API which means forcing
applications to switch to new API

Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
Cc: shahafs@mellanox.com

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 0c696f743..b40c57f28 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -97,8 +97,13 @@ Deprecation Notices
 * ethdev: a new Tx and Rx offload API was introduced on 17.11.
   In the new API, offloads are divided into per-port and per-queue offloads.
   Offloads are disabled by default and enabled per application request.
-  The old offloads API is target to be deprecated on 18.05. This includes:
+  The old offloads API between ethdev and drivers is target to be deprecated on 18.05.
+  This includes:
 
+  - removal of the conversion in ethdev from new offloading API to old API.
+
+  In later releases the old offloading API between ethdev and applications will be
+  deprecated too, which will include:
   - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
   - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
   - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
-- 
2.13.6

Re: [dpdk-dev] [PATCH] doc: reduce initial offload API scope to drivers

[Shahaf Shuler]

Hi Ferruh,

Friday, March 16, 2018 5:32 PM, Ferruh Yigit:
> Subject: [PATCH] doc: reduce initial offload API scope to drivers
> 
> 18.05 tagets ethdev-PMD offload API, which means switching all PMDs to
> new offloading API
> 
> Next step targets ethdev-application offload API which means forcing
> applications to switch to new API
> 
> Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 0c696f743..b40c57f28 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -97,8 +97,13 @@ Deprecation Notices
>  * ethdev: a new Tx and Rx offload API was introduced on 17.11.
>    In the new API, offloads are divided into per-port and per-queue offloads.
>    Offloads are disabled by default and enabled per application request.
> -  The old offloads API is target to be deprecated on 18.05. This includes:
> +  The old offloads API between ethdev and drivers is target to be
> deprecated on 18.05.
> +  This includes:
> 
> +  - removal of the conversion in ethdev from new offloading API to old API.

We cannot remove this part before all of the applications has moved to the new API.
The conversion function is to help PMDs to have single control path with no branch for both old and new application. 

> +
> +  In later releases the old offloading API between ethdev and
> + applications will be  deprecated too, which will include:
>    - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
>    - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
>    - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.

I am OK with postponing the deprecation to a later release and have the PMDs conversion to the new API in the current/next one. 

> --
> 2.13.6

Re: [dpdk-dev] [PATCH] doc: reduce initial offload API scope to drivers

[Ferruh Yigit]

On 3/18/2018 5:57 AM, Shahaf Shuler wrote:
> Hi Ferruh,
> 
> Friday, March 16, 2018 5:32 PM, Ferruh Yigit:
>> Subject: [PATCH] doc: reduce initial offload API scope to drivers
>>
>> 18.05 tagets ethdev-PMD offload API, which means switching all PMDs to
>> new offloading API
>>
>> Next step targets ethdev-application offload API which means forcing
>> applications to switch to new API
>>
>> Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
>> Cc: shahafs@mellanox.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 0c696f743..b40c57f28 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -97,8 +97,13 @@ Deprecation Notices
>>  * ethdev: a new Tx and Rx offload API was introduced on 17.11.
>>    In the new API, offloads are divided into per-port and per-queue offloads.
>>    Offloads are disabled by default and enabled per application request.
>> -  The old offloads API is target to be deprecated on 18.05. This includes:
>> +  The old offloads API between ethdev and drivers is target to be
>> deprecated on 18.05.
>> +  This includes:
>>
>> +  - removal of the conversion in ethdev from new offloading API to old API.
> 
> We cannot remove this part before all of the applications has moved to the new API.
> The conversion function is to help PMDs to have single control path with no branch for both old and new application. 

There are two conversion done in ethdev:
1) From old API to new API
2) From new API to old API

so that PMDs can have access to both old and new API independent from what
application provided.

Above text suggesting to remove only 2).
If we switch all PMDs to new API we don't need conversion 2) anymore.

If application using new API we are all good, for old application that using old
API ethdev will convert to new API so that PMDs can use them.

> 
>> +
>> +  In later releases the old offloading API between ethdev and
>> + applications will be  deprecated too, which will include:
>>    - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
>>    - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
>>    - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
> 
> I am OK with postponing the deprecation to a later release and have the PMDs conversion to the new API in the current/next one. 
> 
>> --
>> 2.13.6
> 

[dpdk-dev] [PATCH v2] doc: reduce initial offload API scope to drivers

[Ferruh Yigit]

Do ethdev new offloading API switch in two steps.

In v18.05 target is implementing the new ethdev-PMD offload interface,
which means converting all PMDs to new offloading API.

Next target is removing the old ethdev offload API.
It will effect applications and will force them to implement new
offloading API.

Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
Cc: shahafs@mellanox.com

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* Update commit log and deprecation notice for clarification
---
 doc/guides/rel_notes/deprecation.rst | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c929dcc31..fd9def20c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -72,8 +72,12 @@ Deprecation Notices
 * ethdev: a new Tx and Rx offload API was introduced on 17.11.
   In the new API, offloads are divided into per-port and per-queue offloads.
   Offloads are disabled by default and enabled per application request.
-  The old offloads API is target to be deprecated on 18.05. This includes:
 
+  The old ethdev - drivers offload interface will be deprecated on 18.05.
+  This includes:
+  - removal of the conversion in ethdev from new offloading API to old API for drivers.
+
+  In later releases the old offloading API will be deprecated, which will include:
   - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
   - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
   - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
-- 
2.14.3

Re: [dpdk-dev] [PATCH v2] doc: reduce initial offload API scope to drivers

[Shahaf Shuler]

Saturday, April 14, 2018 12:21 AM, Ferruh Yigit:
> Subject: [PATCH v2] doc: reduce initial offload API scope to drivers
> 
> Do ethdev new offloading API switch in two steps.
> 
> In v18.05 target is implementing the new ethdev-PMD offload interface,
> which means converting all PMDs to new offloading API.
> 
> Next target is removing the old ethdev offload API.
> It will effect applications and will force them to implement new offloading
> API.
> 
> Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v2:
> * Update commit log and deprecation notice for clarification
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index c929dcc31..fd9def20c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -72,8 +72,12 @@ Deprecation Notices
>  * ethdev: a new Tx and Rx offload API was introduced on 17.11.
>    In the new API, offloads are divided into per-port and per-queue offloads.
>    Offloads are disabled by default and enabled per application request.
> -  The old offloads API is target to be deprecated on 18.05. This includes:
> 
> +  The old ethdev - drivers offload interface will be deprecated on 18.05.
> +  This includes:
> +  - removal of the conversion in ethdev from new offloading API to old API
> for drivers.
> +
> +  In later releases the old offloading API will be deprecated, which will
> include:
>    - removal of ``ETH_TXQ_FLAGS_NO*`` flags.
>    - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
>    - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
> --
> 2.14.3

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Re: [dpdk-dev] [PATCH v2] doc: reduce initial offload API scope to drivers

[Thomas Monjalon]

15/04/2018 07:28, Shahaf Shuler:
> Saturday, April 14, 2018 12:21 AM, Ferruh Yigit:
> > Subject: [PATCH v2] doc: reduce initial offload API scope to drivers
> > 
> > Do ethdev new offloading API switch in two steps.
> > 
> > In v18.05 target is implementing the new ethdev-PMD offload interface,
> > which means converting all PMDs to new offloading API.
> > 
> > Next target is removing the old ethdev offload API.
> > It will effect applications and will force them to implement new offloading
> > API.
> > 
> > Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
> > Cc: shahafs@mellanox.com
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > v2:
> > * Update commit log and deprecation notice for clarification
> > ---
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Applied, thanks