From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 5BF12B34B for ; Tue, 22 Jul 2014 11:36:38 +0200 (CEST) Received: by mail-wg0-f50.google.com with SMTP id n12so7856991wgh.9 for ; Tue, 22 Jul 2014 02:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jCK0nXfFo1tOSPyCDlz42zmN6vRR3JWApja23V2uyS0=; b=diCa6UMDMkG8VD7e1zf/WdhJerMKB/nW7iCw7goFA1RRA/ZqeV/VqfIAOexVXKUJUr JjDqMM1c1oC+dNMgkXNNrBApIsh/TrmzqeZwdC2m8yeu0q/zME7df33VL6/DQQ1l3xAE MT8m/+LrTl4OmL6JlpF/BLAyNCOeIHW8EpVUSfV+okk7hmGEmkXhnqN/3cGpWBFhR3/4 3tXyggGGhm7ZkE72AnpzLNnVFQoUdysIJ2CbsfIPTnq6GaMK30lfYr1l6vDSa2bS1GfA 5vcKRoywhD4loYCDxadXWBrL/Y+Uu3zjgYCwLBCiveru3dWOpKGU7GbjP7k9/uqMZizC 3TTw== X-Gm-Message-State: ALoCoQkzdFWRpiBm/31Hupjnm2dXlYqxyjFBYBSAASNxy1yX9nPkvELl0z7b+g1JsyY8tDTiaRu7 X-Received: by 10.194.71.12 with SMTP id q12mr32136260wju.5.1406021876482; Tue, 22 Jul 2014 02:37:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id au7sm44218167wjc.41.2014.07.22.02.37.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jul 2014 02:37:55 -0700 (PDT) From: Thomas Monjalon To: Ouyang Changchun Date: Tue, 22 Jul 2014 11:37:48 +0200 Message-ID: <2633548.rrHgnQHcZ9@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 09:36:38 -0000 Hi, 2014-07-22 15:47, Ouyang Changchun: > This patch series include 3 things: > 1) Rename the field name from start_rx_per_q to rx_enable_queue in > struct rte_eth_rxconf, and do same thing for TX. > This patch also update description for field rx_enable_queue and tx_enable_queue. > 2) According to 1), update field name from start_rx_per_q to rx_enable_queue in struct igb_rx_queue > in ixgbe PMD, do same thing for TX. > 3) Update its reference in sample vhost. In order to be atomic (and do not break git bisect), you should submit it in one patch. Title would be "ethdev: rename queue enabler field" or something like that. But the most important in such change is to explain why you make it. Thanks -- Thomas