From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1AD542D4B; Sun, 25 Jun 2023 17:45:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 386BB40ED8; Sun, 25 Jun 2023 17:45:59 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C861D40A7F for ; Sun, 25 Jun 2023 17:45:57 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 38E745C0101; Sun, 25 Jun 2023 11:45:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 25 Jun 2023 11:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687707957; x=1687794357; bh=TFBigF26dFr+idHthjP/M0Q+8ad2bLYvyOX znNDTDXY=; b=oQAhu+zvGeCqWOW3a4Gpq3wz/8CZsZJic7/ycIcFC3iKqAvhCLe V3n213YI1VBJONSIZy4XeqSu+d5uPjI704zzySrSI26aqSXSsRgw0f60dFiMsAQn y9fQdY0howV+O9Pz9nrjJDlEacgVBzXjkZY5AswNU+A5NAWUSHGYH53zEM7ru9wp mtTrtrbWexDPfYQcKMbcsposSOwaUGhvYxtI3Tzg5xYHkTwMYmAytlcRZziIQDO8 GkVafETcPk20DOXTc97F7cNbL2COdz8Xc+RqjZSTioDajgKUrDrWFZYg+6XmGh3e CkdPPioWC8bIKsQK378z/M0w9nyIb7X1Tgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687707957; x=1687794357; bh=TFBigF26dFr+idHthjP/M0Q+8ad2bLYvyOX znNDTDXY=; b=G2iwBOgeRy6k+QdtP82kC5ekDwvrD2WSc+QkKC8wSOmPK6e6uRT GCdAJTv67T6qLU4vsg7uQdBou1FKnfhR1k7JSEJJl66uiPYxLgMy3LBcv6H5jkaD slEwE0yORCHINLKv6J59F/VBVJ0eXiAeqDYchN787B7qEf8nLN4xfb6GeQdQYUGr XoOB20EvWU0qIrpUelPxWw/5DCgq1h6umTJIC8G7Akrg76XdgyuKUpS1Nhy+EEw5 RCBbNzcmZQ62gxj0f3OJSx5oARtsX9DPcp33QCX6yJLZQ8KZM/XAoOD3uo0vkB4Y OwK6y99BiuHtE4idHvLedSyWitUI8ElputQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehtddgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 25 Jun 2023 11:45:54 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Hemant Agrawal , Sachin Saxena , Simei Su , Wenjun Wu , Qi Zhang , Xiao Wang , Beilei Xing , Qiming Yang , Jiawen Wu , Jian Wang Subject: Re: [PATCH] drivers: remove compile-time option for IEEE 1588 Date: Sun, 25 Jun 2023 17:45:52 +0200 Message-ID: <2634630.Isy0gbHreE@thomas> In-Reply-To: <3a74993a-a37d-381a-f33f-49deff8f0f10@amd.com> References: <20230203132810.14187-1-thomas@monjalon.net> <3a74993a-a37d-381a-f33f-49deff8f0f10@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/06/2023 16:00, Ferruh Yigit: > On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > > The option RTE_LIBRTE_IEEE1588 has no effect on any library > > unlike its name. > > > > Also we are suppose to enable/disable features dynamically, > > not at compilation time. > > > > And the best is that this macro is neither documented, > > nor in rte_config.h. > > > > It looks to be a mistake keeping this flag, so it is removed, > > meaning always enabled. > > PS: it is disabling vector paths of some drivers. > > > > PTP (IEEE1588) processing brings additional overhead to datapath. > > Agree that it is not good to have undocumented compile macro, but just > removing it may cause performance degradation. > > It may be possible to have separate burst function that supports PTP and > driver configures it when application explicitly request it with a new > offload flag (although it is not exactly an offload), what do you think? The best is to enable dynamically with different functions.