From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AED6A00BE; Wed, 3 Jun 2020 14:05:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61D8E1C439; Wed, 3 Jun 2020 14:05:39 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 358151C436 for ; Wed, 3 Jun 2020 14:05:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5487B5C0067; Wed, 3 Jun 2020 08:05:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 03 Jun 2020 08:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= tRIlQb79p75WLaLUs95uGzGWCLSC+bD5ukfbSvNjtPA=; b=x6ldY5Z5Uam20Hu/ cg5C+Cs1dYZXXRUjMM2JFalNINvUrgdQWoYvkM4iLz3brjaD0pjzL5zV3K5Cudob ml1jLQ9LoEd/wDF1N3DIiBvj9CZUOM03vETCMKoQ8RV4lUPTU2qGByKvhWb4ohnD A2eKhBk69F7E0l3sl/K+lxw4XtrQt9NeLQhvyWxbkKBvCOc7uozwxxzsLosvh/kM mXQfZz6o3qQVEsEztIGxJ1ARqyqfDQDACpMI6NGZOcLDV3+1uSzkvfoOlC9yYOWK cfABWuDi+MmbX816eaCorD9ZD5DkPMRFY3+gfi837aYdK78xZGWweD/n0rX65F20 hj12dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tRIlQb79p75WLaLUs95uGzGWCLSC+bD5ukfbSvNjt PA=; b=XKT5Y6QTbkAHtVxAK9IGrxYI9rzligQqwEaXgtxf6RW0wNkTLjNXREs/W aNepoLm0oBhGrLM0YZe+5x9JfsXfpvaM/isFpfuiN1LYD7VBsg7SEK6kUoW9Y8qC RM3CKEx+vb29wVsWIJtByUOOFPXiB9DQElPLlb9uKzJxHK2WGiHtuOTAdLa506fR GfP6nDftHqzApwC+hdCQAJgkXPkBlxFKlHQRXhWMk9LFBYmAIOJP+82k3lqmC00C epKCHRYT3rm02k3VqpvP9yqefPx26f94tZxktBZG6A1pV7Nar4pCfnhVetkDUYvM r/PGNAChLfTTL4cRsCtTzOOJb03ww== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefledgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4EBC7328005D; Wed, 3 Jun 2020 08:05:34 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "dev@dpdk.org" Date: Wed, 03 Jun 2020 14:05:32 +0200 Message-ID: <2635614.tN7NUgvS9A@thomas> In-Reply-To: <4a983caee75249d3b31f58dd4e302875@pantheon.tech> References: <1591177738-32338-1-git-send-email-juraj.linkes@pantheon.tech> <2931549.x8W8VkzX4A@thomas> <4a983caee75249d3b31f58dd4e302875@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/06/2020 12:47, Juraj Linke=C5=A1: > From: Thomas Monjalon =20 > What about #include ? >=20 > I only changed the .h files since that was enough to fix the issue, but I= 'll add that include as well. [...] > It needs to be backported, so these lines are required: > Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual drivers") > Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") > Fixes: ffc905f3b856 ("ethdev: separate driver APIs") > Fixes: 331c447ad913 ("ethdev: separate internal structures into own head= er") > Cc: stable@dpdk.org >=20 > I didn't know which patches this fixes, so I'll add this. How should I fi= gure this out? Just look at which patch(es) changed the lines I'm modifying? You can use any git tool to search in history. I like using gitk. I searched when the lines you changed were introduced. This kind of search is called pickaxe in git docs. When you found the SHA1, you can use this git alias to generate the Fixes l= ine: fixline =3D log -1 --abbrev=3D12 --format=3D'Fixes: %h (\"%s\")%nCc: %ae' Or even more complex to add the Cc: stable@dpdk.org line automatically: fixline =3D "!f () { git log -1 --abbrev=3D12 --format=3D'Fixes: %h (\"%s\= ")%nCc: %ae' $1 ; ( git tag -l --contains $1 | head -n1 | sed 's,^v,,' | se= d 's,-rc.*,,' ; for i in 1 2 ; do make showversion | cut -d'.' -f-2 ; done = ) | uniq -u | head -n1 | sed 's,.*,Cc: stable@dpdk.org,' ;}; f" PS: your email was not prefixing my words with "> ". Please check your mail config to make sure we clearly distinguish questions and answers. Thanks