From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B16E342DF4; Fri, 7 Jul 2023 09:12:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8961B406B5; Fri, 7 Jul 2023 09:12:58 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 8310740685 for <dev@dpdk.org>; Fri, 7 Jul 2023 09:12:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BDF015C01B5; Fri, 7 Jul 2023 03:12:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 07 Jul 2023 03:12:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688713975; x=1688800375; bh=5Mmnyml55LVeVVybIiNoSXjbtBXGKaMlQVX +Lmhpqio=; b=loZKjSKjCuzmBdy5Z+sRsHYckwf5BerHNyEXkaX7w6G2suQH8hI BZY8ShUt9mXzkPmSYEH0RyzcuKbKFJ8T8RamOza04wWSm+1J+/lk6b0e+5pxaBIt CncXAwm1Sm60cgHuPmiXyjUdP6mcLEjRwPVzqFCyP9gXMsawa5v111yL5Z7RUBU9 V3T7UnPXuj9/GTskU4iCIiZ4RYoii+0hXJadVySUkBqMD/qn6hIxCadEHQDHWSyS R4WNyKahwPA6sP5qQMdc9/Kd/qIWuP5EavgbcEmBKGodThwTmFKHB1awuimiZzgt t2v5kSBIi+klm0JZ3Q4d9t+YRK5dhYwZ9gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688713975; x=1688800375; bh=5Mmnyml55LVeVVybIiNoSXjbtBXGKaMlQVX +Lmhpqio=; b=femCwRAuBXUvxMqnr/A2xVKJC6hzPJI5LpZ61PFKUSKXJbKkbNf cwKpJmk9SBin7Bdfo0j3mlGJSZJejoCrrsw/lQZL4OiAvVAjhhPpmwKU8RvFvGqf TLYc2o8u6Shpx2Zcr1EOIBVTStqv4cjEDysP1SAwpEiF8f/C2Gp+UDJY9h80OoqQ /EsC01P9dOD4pvzCUeilaMgTszMedBNDZeA7HlGryxgLBwoDBjZI6jadYGFPnJeP /M/PtVzYgKoIoo8YeA4kbttBJHdkw7jKyVn//bBKpzmOmiiDLHzulBToQ2jAj4+X Md38z8ynUlyCEYf1tWmfX+qHL5D3w+Eni2g== X-ME-Sender: <xms:97qnZLPFMNpA-CETGaQja73vh3ggGzItENZb5s23iR1zeEGZF59r_Q> <xme:97qnZF8bXXuis3kscvbSKIhDvVt8bFT31nvV25hkpAGsmt8XuQqUrrD8k_fakZUWd YoJUxUA-OjUm8P2YA> X-ME-Received: <xmr:97qnZKRZMMI6U55r1-2_ZMeaKOVzo4IAKihToZ9LqDefqwX_toDQ4ON4jIR6RteRzcUMFN3OX1JnXxoKW-WpiJSWAg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvddtgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnheptdejieeifeehtdffgf dvleetueeffeehueejgfeuteeftddtieekgfekudehtdfgnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: <xmx:97qnZPvuMj8Lj4mzomPtTBqPG950CtK9Za_C6M14Ssfh502E4F7U6w> <xmx:97qnZDcHDeGEM-TMNOqag1sw8U6FSnhIw40X31InzBidOlKg606BlQ> <xmx:97qnZL0YomDPP0pekcOBfWiNizkEFnYwZdOc4YQ3MpiuF9ragDDN4g> <xmx:97qnZLG-nFJ357NqHeCBpBuGbTIGIORx1_ykgowH6BgJxgDW04GrCA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Jul 2023 03:12:54 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Marvin Liu <yong.liu@intel.com> Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH] eal: allow both allow and block options coexistence Date: Fri, 07 Jul 2023 09:12:52 +0200 Message-ID: <2637257.yKVeVyVuyW@thomas> In-Reply-To: <20230707050701.21433-1-yong.liu@intel.com> References: <20230707050701.21433-1-yong.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 07/07/2023 07:07, Marvin Liu: > Currently, all buses use the same eal allow and block options. Need to > allow both allow and block options for different buses to coexist. > It wouldn't be a problem for pci bus if both allow and block options > were present. When the first option occurs, the scan mode for pci bus is > set. > > For example: > --allow 0000:05:00.0 --block wq0.0 > only pci device 0000:05:00.0 will be scanned > all devices except wq0.0 on dsa bus will be scanned > --allow 0000:05:00.0 --block 0000:05:00.1 > block option will be ignored > --block 0000:05:00.1 --allow 0000:05:00.0 > allow option will be ignored It is wrong to ignore a user parameter silently. Also, it would be clearer to use the new devargs syntax with bus=pci,addr=0000:05:00.0