From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 46D9D5699
 for <dev@dpdk.org>; Thu, 28 Mar 2019 00:27:24 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id CB17C21FC3;
 Wed, 27 Mar 2019 19:27:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 27 Mar 2019 19:27:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=rRHJX16LDyFrfDI0Qi9I0swkocviPjEr16iLncIPc54=; b=KqAYShTdib+i
 q+ZK456si/2/ZUFifr/ZHxHFBQCi/AaZKUxbcK8KYS3vskHTX5iMrhLVsWfOhtlj
 GfnOJJcGXRJtC76B2GsQhPx43DtutJS8s/rzf4KoLF9XEIf2T016cByNTWw2DBcs
 lJiWolvcfB60a2DpyAZWNhsr0jaAL/g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=rRHJX16LDyFrfDI0Qi9I0swkocviPjEr16iLncIPc
 54=; b=G24hTStJprwKligmYS9vSolNm5ukDNNBErnN1woYLVHvdh1mVuB5VgCal
 lvVLBYivajyUTdki/zHB3MUhKgiC2G/CpjF5c3etudEwA8S/aQQx6b+gmnasZYMi
 VCwxw9dPvSQKYds4kjkDAXPgPPa86H8et6jEHHl8ywrtI8rvhuJ9FZWQR6XPQQ3i
 c6ygO4rJrYTzMBkH2EI6uekAiM+WumnVqKMAtX4VdnpZWrvuD9pRHpwYov1pIIYG
 bkzMq/GurWIRuXH+GCy0m1kmZxES+F9mONh/5hxAMCWprrD2vqmgaGEZF1EnE7L8
 E+PlhxtbxXW3iFLojeMI6nW6pCKYw==
X-ME-Sender: <xms:2gacXJ00w4jtyc0wfmMSDwSCqzj-28vQ0DQYBQRMpFYRqH2hEt_2Fg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddvvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh
 hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr
 rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc
 evlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:2wacXEVqQ-TEwkp1Pxti8LZFTp2JAzkxZPh3kMe5AYVNvb3hyEM-9A>
 <xmx:2wacXE4qdVHFNqxley5MpXCWOm19UeZReIpFrlT9yvo1O3WnDrifgw>
 <xmx:2wacXLIgzKWHjUzD4rzwUji9PDtOYOoz1Cx3rpL7lAaXrYmAWSE0dA>
 <xmx:2wacXEObkXlbZd4ieSlkjVdHYJOWc6gnTvy4IIkQoXEjfgWZeiZ2og>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D36ACE473B;
 Wed, 27 Mar 2019 19:27:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anand Rawat <anand.rawat@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "jeffrey.b.shaw@intel.com" <jeffrey.b.shaw@intel.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 Ranjit Menon <ranjit.menon@intel.com>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Date: Thu, 28 Mar 2019 00:27:20 +0100
Message-ID: <2639848.f1PDEsoNVO@xps>
In-Reply-To: <38de8645-b876-cce4-9594-38ffb487c82e@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <2640699.3m2PSFbs9Z@xps> <38de8645-b876-cce4-9594-38ffb487c82e@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support
	windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 23:27:24 -0000

28/03/2019 00:10, Anand Rawat:
> On 3/27/2019 3:29 PM, Thomas Monjalon wrote:
> > 27/03/2019 22:23, Ranjit Menon:
> > > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote:
> > >> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote:
> > >>> Added header files to support windows on x86 platforms.
> > >>> Updated rte_common.h to include rte_windows.h for windows
> > >>> build. Updated lib/meson.build to create shared libraries
> > >>> on windows. Added def file to list the exports for the
> > >>> eal library.
> > >>>
> > >>> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> > >>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > >>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > >>> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> > >>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > >>> ---
> > >>>    lib/librte_eal/common/include/rte_common.h    |  7 ++++-
> > >>>    .../common/include/rte_string_fns.h           |  4 ++-
> > >>>    lib/librte_eal/rte_eal_exports.def            |  9 ++++++
> > >>>    .../windows/eal/include/rte_windows.h         | 30
> > >>> +++++++++++++++++++
> > >>>    lib/librte_eal/windows/eal/meson.build        |  2 ++
> > >>>    lib/meson.build                               | 19 ++++++++++--
> > >>>    6 files changed, 66 insertions(+), 5 deletions(-)
> > >>>    create mode 100644 lib/librte_eal/rte_eal_exports.def
> > >>>    create mode 100644 lib/librte_eal/windows/eal/include/rte_windows.h
> > >>>
> > >>> diff --git a/lib/librte_eal/common/include/rte_common.h
> > >>> b/lib/librte_eal/common/include/rte_common.h
> > >>> index 7178ba1e9..4775c84f5 100644
> > >>> --- a/lib/librte_eal/common/include/rte_common.h
> > >>> +++ b/lib/librte_eal/common/include/rte_common.h
> > >>> @@ -1,5 +1,5 @@
> > >>>    /* SPDX-License-Identifier: BSD-3-Clause
> > >>> - * Copyright(c) 2010-2014 Intel Corporation
> > >>> + * Copyright(c) 2010-2019 Intel Corporation
> > >>>     */
> > >>>
> > >>>    #ifndef _RTE_COMMON_H_
> > >>> @@ -24,6 +24,11 @@ extern "C" {
> > >>>
> > >>>    #include <rte_config.h>
> > >>>
> > >>> +/* windows specific*/
> > >>> +#ifdef RTE_EXEC_ENV_WINDOWS
> > >>> +#include <rte_windows.h>
> > >>> +#endif
> > >>> +
> > >>
> > >> IMO, Updating the rte_common.h for each execution environment is not
> > >> clean and unnecessary #ifdef clutter in the common code.
> > >>
> > >> I think, it can be fixed by adding new os or eal specific header file
> > >> at the following location and simply include it(without any #ifdef)
> > >>
> > >> lib/librte_eal/linux/eal/include/exec-env/rte_eal.h
> > >> lib/librte_eal/freebsd/eal/include/exec-env/rte_eal.h
> > >> lib/librte_eal/windows/eal/include/exec-env/rte_eal.h # the content of
> > >> exiting rte_windows.h goes here.
> > >>
> > >> It can be rte_eal.h or rte_os.h or anything similar.
> > >>
> > >>
> > > This was done based on a suggestion from Thomas:
> > > (http://patches.dpdk.org/patch/50844/)
> > >
> > > But, I agree. Your suggestion would be a good enhancement. There is
> > > already an existing rte_eal.h in common/include, so an rte_os.h or
> > > something similar might make sense.
> >
> > Yes I agree with rte_os.h
> >
> >
> I can include this change in v6. I am looking to add rte_os.h under
> windows/eal/include/exec-env/ and include the header in rte_common.h
> as a separate patch. This change would require new files for linux and freebsd.
> What be should be the content of that?

I think you can add empty files.
Later we may discover some definitions to move from common code to rte_os.h.

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id D2A01A05D3
	for <public@inbox.dpdk.org>; Thu, 28 Mar 2019 00:27:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id F0F2256A1;
	Thu, 28 Mar 2019 00:27:25 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 46D9D5699
 for <dev@dpdk.org>; Thu, 28 Mar 2019 00:27:24 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id CB17C21FC3;
 Wed, 27 Mar 2019 19:27:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 27 Mar 2019 19:27:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=rRHJX16LDyFrfDI0Qi9I0swkocviPjEr16iLncIPc54=; b=KqAYShTdib+i
 q+ZK456si/2/ZUFifr/ZHxHFBQCi/AaZKUxbcK8KYS3vskHTX5iMrhLVsWfOhtlj
 GfnOJJcGXRJtC76B2GsQhPx43DtutJS8s/rzf4KoLF9XEIf2T016cByNTWw2DBcs
 lJiWolvcfB60a2DpyAZWNhsr0jaAL/g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=rRHJX16LDyFrfDI0Qi9I0swkocviPjEr16iLncIPc
 54=; b=G24hTStJprwKligmYS9vSolNm5ukDNNBErnN1woYLVHvdh1mVuB5VgCal
 lvVLBYivajyUTdki/zHB3MUhKgiC2G/CpjF5c3etudEwA8S/aQQx6b+gmnasZYMi
 VCwxw9dPvSQKYds4kjkDAXPgPPa86H8et6jEHHl8ywrtI8rvhuJ9FZWQR6XPQQ3i
 c6ygO4rJrYTzMBkH2EI6uekAiM+WumnVqKMAtX4VdnpZWrvuD9pRHpwYov1pIIYG
 bkzMq/GurWIRuXH+GCy0m1kmZxES+F9mONh/5hxAMCWprrD2vqmgaGEZF1EnE7L8
 E+PlhxtbxXW3iFLojeMI6nW6pCKYw==
X-ME-Sender: <xms:2gacXJ00w4jtyc0wfmMSDwSCqzj-28vQ0DQYBQRMpFYRqH2hEt_2Fg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddvvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh
 hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr
 rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc
 evlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:2wacXEVqQ-TEwkp1Pxti8LZFTp2JAzkxZPh3kMe5AYVNvb3hyEM-9A>
 <xmx:2wacXE4qdVHFNqxley5MpXCWOm19UeZReIpFrlT9yvo1O3WnDrifgw>
 <xmx:2wacXLIgzKWHjUzD4rzwUji9PDtOYOoz1Cx3rpL7lAaXrYmAWSE0dA>
 <xmx:2wacXEObkXlbZd4ieSlkjVdHYJOWc6gnTvy4IIkQoXEjfgWZeiZ2og>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D36ACE473B;
 Wed, 27 Mar 2019 19:27:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anand Rawat <anand.rawat@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "jeffrey.b.shaw@intel.com" <jeffrey.b.shaw@intel.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 Ranjit Menon <ranjit.menon@intel.com>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Date: Thu, 28 Mar 2019 00:27:20 +0100
Message-ID: <2639848.f1PDEsoNVO@xps>
In-Reply-To: <38de8645-b876-cce4-9594-38ffb487c82e@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <2640699.3m2PSFbs9Z@xps> <38de8645-b876-cce4-9594-38ffb487c82e@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support
	windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190327232720.SlT2uoJTK8I4fW7L-a5FtSvrAkOJ8mfSeCIj4K5aGHw@z>

28/03/2019 00:10, Anand Rawat:
> On 3/27/2019 3:29 PM, Thomas Monjalon wrote:
> > 27/03/2019 22:23, Ranjit Menon:
> > > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote:
> > >> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote:
> > >>> Added header files to support windows on x86 platforms.
> > >>> Updated rte_common.h to include rte_windows.h for windows
> > >>> build. Updated lib/meson.build to create shared libraries
> > >>> on windows. Added def file to list the exports for the
> > >>> eal library.
> > >>>
> > >>> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> > >>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > >>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > >>> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> > >>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > >>> ---
> > >>>    lib/librte_eal/common/include/rte_common.h    |  7 ++++-
> > >>>    .../common/include/rte_string_fns.h           |  4 ++-
> > >>>    lib/librte_eal/rte_eal_exports.def            |  9 ++++++
> > >>>    .../windows/eal/include/rte_windows.h         | 30
> > >>> +++++++++++++++++++
> > >>>    lib/librte_eal/windows/eal/meson.build        |  2 ++
> > >>>    lib/meson.build                               | 19 ++++++++++--
> > >>>    6 files changed, 66 insertions(+), 5 deletions(-)
> > >>>    create mode 100644 lib/librte_eal/rte_eal_exports.def
> > >>>    create mode 100644 lib/librte_eal/windows/eal/include/rte_windows.h
> > >>>
> > >>> diff --git a/lib/librte_eal/common/include/rte_common.h
> > >>> b/lib/librte_eal/common/include/rte_common.h
> > >>> index 7178ba1e9..4775c84f5 100644
> > >>> --- a/lib/librte_eal/common/include/rte_common.h
> > >>> +++ b/lib/librte_eal/common/include/rte_common.h
> > >>> @@ -1,5 +1,5 @@
> > >>>    /* SPDX-License-Identifier: BSD-3-Clause
> > >>> - * Copyright(c) 2010-2014 Intel Corporation
> > >>> + * Copyright(c) 2010-2019 Intel Corporation
> > >>>     */
> > >>>
> > >>>    #ifndef _RTE_COMMON_H_
> > >>> @@ -24,6 +24,11 @@ extern "C" {
> > >>>
> > >>>    #include <rte_config.h>
> > >>>
> > >>> +/* windows specific*/
> > >>> +#ifdef RTE_EXEC_ENV_WINDOWS
> > >>> +#include <rte_windows.h>
> > >>> +#endif
> > >>> +
> > >>
> > >> IMO, Updating the rte_common.h for each execution environment is not
> > >> clean and unnecessary #ifdef clutter in the common code.
> > >>
> > >> I think, it can be fixed by adding new os or eal specific header file
> > >> at the following location and simply include it(without any #ifdef)
> > >>
> > >> lib/librte_eal/linux/eal/include/exec-env/rte_eal.h
> > >> lib/librte_eal/freebsd/eal/include/exec-env/rte_eal.h
> > >> lib/librte_eal/windows/eal/include/exec-env/rte_eal.h # the content of
> > >> exiting rte_windows.h goes here.
> > >>
> > >> It can be rte_eal.h or rte_os.h or anything similar.
> > >>
> > >>
> > > This was done based on a suggestion from Thomas:
> > > (http://patches.dpdk.org/patch/50844/)
> > >
> > > But, I agree. Your suggestion would be a good enhancement. There is
> > > already an existing rte_eal.h in common/include, so an rte_os.h or
> > > something similar might make sense.
> >
> > Yes I agree with rte_os.h
> >
> >
> I can include this change in v6. I am looking to add rte_os.h under
> windows/eal/include/exec-env/ and include the header in rte_common.h
> as a separate patch. This change would require new files for linux and freebsd.
> What be should be the content of that?

I think you can add empty files.
Later we may discover some definitions to move from common code to rte_os.h.