From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1D56A0A0C; Tue, 29 Jun 2021 16:06:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 106D0411AE; Tue, 29 Jun 2021 16:06:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id AE61C40E01; Tue, 29 Jun 2021 16:06:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="195303546" X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="195303546" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 07:06:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="492697728" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 29 Jun 2021 07:06:08 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 07:06:07 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 22:06:05 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Tue, 29 Jun 2021 22:06:05 +0800 From: "Zhang, Qi Z" To: "Wu, Wenjun1" , "dev@dpdk.org" , "Yang, Qiming" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1] net/ice/base: fix wrong first mask value setting Thread-Index: AQHXZn4z37bXkgzdQEyApZQuDSuMiKsrEqLw Date: Tue, 29 Jun 2021 14:06:05 +0000 Message-ID: <263c976572be44309bfbdd9e80cfb120@intel.com> References: <20210621085923.1286701-1-wenjun1.wu@intel.com> In-Reply-To: <20210621085923.1286701-1-wenjun1.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/ice/base: fix wrong first mask value setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wu, Wenjun1 > Sent: Monday, June 21, 2021 4:59 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; stable@dpdk.org > Subject: [PATCH v1] net/ice/base: fix wrong first mask value setting >=20 > Since each pf does not share the same structure space, the first mask val= ue > should start at 0 instead of hw->pf_id * per_pf to avoid address overflow= . > Otherwise, address space will overlap when masks.first + masks.count > > ICE_PROF_MASK_COUNT, and it may lead to unexpected variable assignment, > which causes segmentation fault. >=20 > Fixes: 9467486f179f ("net/ice/base: enable masking for RSS and FD field > vectors") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjun Wu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi