From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 5A18B9E5 for ; Fri, 11 Sep 2015 10:12:06 +0200 (CEST) Received: by wicgb1 with SMTP id gb1so52638270wic.1 for ; Fri, 11 Sep 2015 01:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=SNHDaGB8ZuO3eHYrl308hF9i/KHXgZcVO3x6FyJYbhI=; b=Fg4qbwpYsoZYRwFelPjRN7f8XCfl0SWwPhjpzd5KEw/pksaHfwEJYSxMPjsGHAU2Bi DY/jG2prg9RYvbwIquZOIvNxZaWtnR6vITv4IL8RsJBODDkSuLTopywabTrGdY8DyUA6 fYBYnTZRWwmWeILZg8fePDnDxYfnj3cKesIUtNyavBAj1YZzkjRzB36P5/DIXgMpBFJl p4iQ8e0kxhJkW13CAWD8DvVED5Z/6SzdNKRioeVmJVY/63HvHCY6N3fZj533NQTpXrY9 8Hx9uldB9SDKCDuogL4w8s9NC0RGvD/rU1Rb4SyqPZN4moyCdcFwFE3L4rQvaBO0I2PH fL8w== X-Gm-Message-State: ALoCoQkIEKqqlJiGj8yonWiHa3exogIqa4DEPmU3SW6XfGnrg8hSe8m9Cl/dQvpKawOIqcNvKavB X-Received: by 10.194.108.4 with SMTP id hg4mr14075731wjb.45.1441959126078; Fri, 11 Sep 2015 01:12:06 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id z2sm1003191wij.1.2015.09.11.01.12.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2015 01:12:05 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org, Ferruh Yigit , David Marchand Date: Fri, 11 Sep 2015 10:10:57 +0200 Message-ID: <2640256.iR0jT46UN8@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20150910193300.GA32153@sivlogin002.ir.intel.com> References: <1441900908-29763-1-git-send-email-ferruh.yigit@intel.com> <20150910193300.GA32153@sivlogin002.ir.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: use existing PCI macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 08:12:06 -0000 2015-09-10 20:33, Ferruh Yigit: > > On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit > > wrote: > > > > > To get pci_dev and vf number from dev, benefit from > > > existing macros in pci.h > > > > > > Signed-off-by: Ferruh Yigit > > > > Correct me if I am wrong but you might need to provide wrappers for kernel > > version <= 2.6.34 (or something that indicates availability of those). > > Correct, those macros available after kernel version >= 2.6.34. > If these is any chance that one using older kernel than this version, > instead of having wrappers I am for keeping existing implementation and > drop this patch. Why should we support kernel older than 2.6.34? Do we need to update doc/guides/rel_notes/supported_os.rst?