From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DD4684F90 for ; Wed, 27 Mar 2019 23:29:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7092520D9E; Wed, 27 Mar 2019 18:29:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 18:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NAtEDYKi720Q15DzUySBWwmEbtECprVxR7CLhY1KKuM=; b=n40KO2l8rfcw dah5bZax5tkDDcs0GPlsLcyV2bBIB4VJOOmfs65GA0FBUtFAt7y/iqvhQoRBkylR FFBk06yveHVaXipoJWXryIvmobQeU+llJXhOpiQcH+wRjIHJUUmY6eNnRSBJQc/B dEGOI5KQDm6iDAZuzLrKC0U+Lz7e7fQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NAtEDYKi720Q15DzUySBWwmEbtECprVxR7CLhY1KK uM=; b=QqItgcAH2FhFPXczxKXFn+q+RRyUX1euJP6h6nsFYJY+ivHld+Mj3dyQ3 zYLCyAdOkVWWfjOfQ70mg0uUHY9wFOf5B1+FKfkeX2gBYn+YhFN+US6OZr/CTIoF FN3CTJAbnTzE0fmeWnBirQOgxW9j5CT3tREGdrgmZV2FCI5BeGamJBIghM5+B+d/ CKUl3gFz4KJkWLbVtbfahcmdcsWQFO8SqEE0mO6aNA1hEAEm7ETFL19FIr5hfwy7 9vKgZ4ili/BePL+L5lY4GVV+sqo12XUjZa7Mxc0jkDTiLwhukx4nhgMl4JJVvTLb anZsqGq3M5OzFJ3rnTIYErOFalA3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A9C01031A; Wed, 27 Mar 2019 18:29:11 -0400 (EDT) From: Thomas Monjalon To: Ranjit Menon , Jerin Jacob Kollanukkaran Cc: "anand.rawat@intel.com" , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "jeffrey.b.shaw@intel.com" , "bruce.richardson@intel.com" Date: Wed, 27 Mar 2019 23:29:10 +0100 Message-ID: <2640699.3m2PSFbs9Z@xps> In-Reply-To: References: <20190306041634.12976-1-anand.rawat@intel.com> <944cfe276e570e3e6feb01a7da7c6fa03de22ee4.camel@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 22:29:15 -0000 27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > >> Added header files to support windows on x86 platforms. > >> Updated rte_common.h to include rte_windows.h for windows > >> build. Updated lib/meson.build to create shared libraries > >> on windows. Added def file to list the exports for the > >> eal library. > >> > >> Signed-off-by: Anand Rawat > >> Signed-off-by: Pallavi Kadam > >> Signed-off-by: Bruce Richardson > >> Reviewed-by: Jeff Shaw > >> Reviewed-by: Ranjit Menon > >> --- > >> lib/librte_eal/common/include/rte_common.h | 7 ++++- > >> .../common/include/rte_string_fns.h | 4 ++- > >> lib/librte_eal/rte_eal_exports.def | 9 ++++++ > >> .../windows/eal/include/rte_windows.h | 30 > >> +++++++++++++++++++ > >> lib/librte_eal/windows/eal/meson.build | 2 ++ > >> lib/meson.build | 19 ++++++++++-- > >> 6 files changed, 66 insertions(+), 5 deletions(-) > >> create mode 100644 lib/librte_eal/rte_eal_exports.def > >> create mode 100644 lib/librte_eal/windows/eal/include/rte_windows.h > >> > >> diff --git a/lib/librte_eal/common/include/rte_common.h > >> b/lib/librte_eal/common/include/rte_common.h > >> index 7178ba1e9..4775c84f5 100644 > >> --- a/lib/librte_eal/common/include/rte_common.h > >> +++ b/lib/librte_eal/common/include/rte_common.h > >> @@ -1,5 +1,5 @@ > >> /* SPDX-License-Identifier: BSD-3-Clause > >> - * Copyright(c) 2010-2014 Intel Corporation > >> + * Copyright(c) 2010-2019 Intel Corporation > >> */ > >> > >> #ifndef _RTE_COMMON_H_ > >> @@ -24,6 +24,11 @@ extern "C" { > >> > >> #include > >> > >> +/* windows specific*/ > >> +#ifdef RTE_EXEC_ENV_WINDOWS > >> +#include > >> +#endif > >> + > > > > IMO, Updating the rte_common.h for each execution environment is not > > clean and unnecessary #ifdef clutter in the common code. > > > > I think, it can be fixed by adding new os or eal specific header file > > at the following location and simply include it(without any #ifdef) > > > > lib/librte_eal/linux/eal/include/exec-env/rte_eal.h > > lib/librte_eal/freebsd/eal/include/exec-env/rte_eal.h > > lib/librte_eal/windows/eal/include/exec-env/rte_eal.h # the content of > > exiting rte_windows.h goes here. > > > > It can be rte_eal.h or rte_os.h or anything similar. > > > > > This was done based on a suggestion from Thomas: > (http://patches.dpdk.org/patch/50844/) > > But, I agree. Your suggestion would be a good enhancement. There is > already an existing rte_eal.h in common/include, so an rte_os.h or > something similar might make sense. Yes I agree with rte_os.h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 762BCA05D3 for ; Wed, 27 Mar 2019 23:29:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D5974F91; Wed, 27 Mar 2019 23:29:16 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DD4684F90 for ; Wed, 27 Mar 2019 23:29:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7092520D9E; Wed, 27 Mar 2019 18:29:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 18:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NAtEDYKi720Q15DzUySBWwmEbtECprVxR7CLhY1KKuM=; b=n40KO2l8rfcw dah5bZax5tkDDcs0GPlsLcyV2bBIB4VJOOmfs65GA0FBUtFAt7y/iqvhQoRBkylR FFBk06yveHVaXipoJWXryIvmobQeU+llJXhOpiQcH+wRjIHJUUmY6eNnRSBJQc/B dEGOI5KQDm6iDAZuzLrKC0U+Lz7e7fQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NAtEDYKi720Q15DzUySBWwmEbtECprVxR7CLhY1KK uM=; b=QqItgcAH2FhFPXczxKXFn+q+RRyUX1euJP6h6nsFYJY+ivHld+Mj3dyQ3 zYLCyAdOkVWWfjOfQ70mg0uUHY9wFOf5B1+FKfkeX2gBYn+YhFN+US6OZr/CTIoF FN3CTJAbnTzE0fmeWnBirQOgxW9j5CT3tREGdrgmZV2FCI5BeGamJBIghM5+B+d/ CKUl3gFz4KJkWLbVtbfahcmdcsWQFO8SqEE0mO6aNA1hEAEm7ETFL19FIr5hfwy7 9vKgZ4ili/BePL+L5lY4GVV+sqo12XUjZa7Mxc0jkDTiLwhukx4nhgMl4JJVvTLb anZsqGq3M5OzFJ3rnTIYErOFalA3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A9C01031A; Wed, 27 Mar 2019 18:29:11 -0400 (EDT) From: Thomas Monjalon To: Ranjit Menon , Jerin Jacob Kollanukkaran Cc: "anand.rawat@intel.com" , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "jeffrey.b.shaw@intel.com" , "bruce.richardson@intel.com" Date: Wed, 27 Mar 2019 23:29:10 +0100 Message-ID: <2640699.3m2PSFbs9Z@xps> In-Reply-To: References: <20190306041634.12976-1-anand.rawat@intel.com> <944cfe276e570e3e6feb01a7da7c6fa03de22ee4.camel@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327222910.F31hVwGWI3QZ3kn7OgqDyLSJJT6njgYtBVXh5NyupBo@z> 27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > >> Added header files to support windows on x86 platforms. > >> Updated rte_common.h to include rte_windows.h for windows > >> build. Updated lib/meson.build to create shared libraries > >> on windows. Added def file to list the exports for the > >> eal library. > >> > >> Signed-off-by: Anand Rawat > >> Signed-off-by: Pallavi Kadam > >> Signed-off-by: Bruce Richardson > >> Reviewed-by: Jeff Shaw > >> Reviewed-by: Ranjit Menon > >> --- > >> lib/librte_eal/common/include/rte_common.h | 7 ++++- > >> .../common/include/rte_string_fns.h | 4 ++- > >> lib/librte_eal/rte_eal_exports.def | 9 ++++++ > >> .../windows/eal/include/rte_windows.h | 30 > >> +++++++++++++++++++ > >> lib/librte_eal/windows/eal/meson.build | 2 ++ > >> lib/meson.build | 19 ++++++++++-- > >> 6 files changed, 66 insertions(+), 5 deletions(-) > >> create mode 100644 lib/librte_eal/rte_eal_exports.def > >> create mode 100644 lib/librte_eal/windows/eal/include/rte_windows.h > >> > >> diff --git a/lib/librte_eal/common/include/rte_common.h > >> b/lib/librte_eal/common/include/rte_common.h > >> index 7178ba1e9..4775c84f5 100644 > >> --- a/lib/librte_eal/common/include/rte_common.h > >> +++ b/lib/librte_eal/common/include/rte_common.h > >> @@ -1,5 +1,5 @@ > >> /* SPDX-License-Identifier: BSD-3-Clause > >> - * Copyright(c) 2010-2014 Intel Corporation > >> + * Copyright(c) 2010-2019 Intel Corporation > >> */ > >> > >> #ifndef _RTE_COMMON_H_ > >> @@ -24,6 +24,11 @@ extern "C" { > >> > >> #include > >> > >> +/* windows specific*/ > >> +#ifdef RTE_EXEC_ENV_WINDOWS > >> +#include > >> +#endif > >> + > > > > IMO, Updating the rte_common.h for each execution environment is not > > clean and unnecessary #ifdef clutter in the common code. > > > > I think, it can be fixed by adding new os or eal specific header file > > at the following location and simply include it(without any #ifdef) > > > > lib/librte_eal/linux/eal/include/exec-env/rte_eal.h > > lib/librte_eal/freebsd/eal/include/exec-env/rte_eal.h > > lib/librte_eal/windows/eal/include/exec-env/rte_eal.h # the content of > > exiting rte_windows.h goes here. > > > > It can be rte_eal.h or rte_os.h or anything similar. > > > > > This was done based on a suggestion from Thomas: > (http://patches.dpdk.org/patch/50844/) > > But, I agree. Your suggestion would be a good enhancement. There is > already an existing rte_eal.h in common/include, so an rte_os.h or > something similar might make sense. Yes I agree with rte_os.h