From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E583A0544; Mon, 10 Oct 2022 14:52:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E70C74021E; Mon, 10 Oct 2022 14:52:44 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 01ACB40146 for <dev@dpdk.org>; Mon, 10 Oct 2022 14:52:43 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 811835C00C3; Mon, 10 Oct 2022 08:52:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 10 Oct 2022 08:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665406363; x= 1665492763; bh=nsqhmm0MVTGc1WOHpi/NQf8r8KShBBsuTvzjqMhyKo8=; b=q CKfbpEuL1GwZFZqWZ7neVFAvEOxx9VDGnaxAHnRt2w8GXOWzachpzmy6Er1Xz7r9 Oo3HEoq/S94zihI8unfDkChsSh0dJaifev9iQofN1Bndfvm28D+MpCWEqFKcMXdh TerLzjmUEnHndvO1ulyvIFiyeWCwKPT0dp/NlneTe6n2rtfAbmaMI4qza3rA3uNn OYT7PmdGgDRxqn0oehLgGiNvzRY+G1dtOfIWQW22qDWuBt5CaEo3FgIJu2anrJO8 Ti4hDeZtjQXSW8kIKAnl0nT68SkNuuHxcd/xJIM0xiOOSCsMk8CphYuutbYirbXJ Mo04VCijp6hYnxGkm36Iw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665406363; x= 1665492763; bh=nsqhmm0MVTGc1WOHpi/NQf8r8KShBBsuTvzjqMhyKo8=; b=G Enrx+ion67TbF3Z5VTCViSic5ayGQg6tr2l6NzuxXQn1bgIz7qzfPLEqTaZbU8Zm zFTOd1y4sNKZHzH60pe8BrFXEeBQ5FNwiKJ+RCR67GF9hCk/scDJl5dis4DmcRa4 5o/9OEyJK2KR2WM80rFVe49pPP359rGMibP0t74bqIeth5d44V7RSXrlMf89gIy1 VMHO96Geq38UpZibsOpG8UMObbmpyeSeN5+x4OvPMvyZpqXO/hklVB4uoOKvxBBY B0py7XVTPEup/Kr5O3Z++cFFy6na5QtN/XZw4EuA8ql2hbiHwy4AUYV0R4xvwjCf WSkYQepF9wqBhiebh2wXQ== X-ME-Sender: <xms:mxVEY3EqEz08nCTBEBn_sLcsMXl6UnoNUlma8b_I-vuaiAPqcT5mMw> <xme:mxVEY0W0bJ8du_HlQNwY8xynhHWltyxxeWZgcqBXS97UByYrjjq5Ad6S-5OWEp9s9 NojT68kfi-aztDcJg> X-ME-Received: <xmr:mxVEY5IXO4ji7isEqveu6wIEAYoW0M-sd3bvNvRokvqfnyfsQ8b7lgCw9d0z80Ym-3ZtEIvH_IoRcDu4YE1mPlSHDA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejgedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:mxVEY1Gh0bMkRXrfE-RWEhan-iySwX5uEO82aYprNUff-Xoal4U8tA> <xmx:mxVEY9U5IBjtdpHclnqdPdbdwJQq-dA5vH5TvCA5Y3YMiRbsS_M-1w> <xmx:mxVEYwOa8MDtyO7iv8i_OkpUNNo5asDMj3bm6Up1f4syioi1Ku-GJw> <xmx:mxVEY_IN1O6474DzivXM0QeSom-eCQNGwV85PtzyjchdtlCWdzeNSQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Oct 2022 08:52:42 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Tadhg Kearney <tadhg.kearney@intel.com> Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com, reshma.pattan@intel.com, david.marchand@redhat.com, stephen@networkplumber.org, ferruh.yigit@amd.com Subject: Re: [PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power Date: Mon, 10 Oct 2022 14:52:40 +0200 Message-ID: <2640781.uZKlY2gecq@thomas> In-Reply-To: <20221006093803.2076768-1-tadhg.kearney@intel.com> References: <20221005162023.1923558-1-tadhg.kearney@intel.com> <20221006093803.2076768-1-tadhg.kearney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 06/10/2022 11:38, Tadhg Kearney: > This is targeting 22.11 and aims to add an API to DPDK power library to > allow uncore frequency adjustment. This will be called through the l3fwd-power > app and gives the ability to set the minimum and maximum uncore frequency to > both min, max or specific frequency index. > > Signed-off-by: tadhgkearney <tadhg.kearney@intel.com> > Reviewed-by: David Hunt <david.hunt@intel.com> > Acked-by: David Hunt <david.hunt@intel.com> I did some edits to make it more comfortable to my eyes. Applied, thanks. I really would like 2 follow-ups please: - some general clean-up in power library code and doc. - some discussion about how we can make this library more generic.