From: Thomas Monjalon <thomas@monjalon.net>
To: Kefu Chai <tchaikov@gmail.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Avi Kivity <avi@scylladb.com>, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v5 2/2] build: add meson options of max_memseg_lists
Date: Thu, 14 Oct 2021 10:29:34 +0200 [thread overview]
Message-ID: <2642296.XfZ1dg20Xv@thomas> (raw)
In-Reply-To: <YWfpbcLdrliYDtey@bricha3-MOBL.ger.corp.intel.com>
14/10/2021 10:25, Bruce Richardson:
> On Thu, Oct 14, 2021 at 04:54:19AM +0800, Kefu Chai wrote:
> > RTE_MAX_MEMSEG_LISTS = 128 is not enough for many-core machines, in our
> > case, we need to increase it to 8192. so add an option so user can
> > override it.
> >
> > Signed-off-by: Kefu Chai <tchaikov@gmail.com>
>
> This seems a very low-level option to be exposing to the user. Some
> thoughts/questions:
>
> - can you give some more detail on why you need such a massive number, 64
> times the default?
> - what would be the impact of increasing the default to 8192? I assume this
> is only used in a few places in EAL, so would the memory footprint
> increase be large?
> - rather than a single specified value, would an alternative be to make
> this be a computed value at config time, scaled by number of lcores (or
> number of numa nodes)?
+1 for these suggestions
prev parent reply other threads:[~2021-10-14 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 14:48 [dpdk-dev] [PATCH] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai
2021-09-02 15:02 ` Bruce Richardson
2021-09-02 15:05 ` [dpdk-dev] [PATCH v2] " Kefu Chai
2021-09-02 15:11 ` [dpdk-dev] [PATCH v3] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts Kefu Chai
2021-09-08 16:51 ` [dpdk-dev] [PATCH v4] " Kefu Chai
2021-09-20 7:51 ` kefu chai
2021-09-20 8:08 ` Bruce Richardson
2021-09-27 15:03 ` kefu chai
2021-10-13 15:38 ` Thomas Monjalon
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 0/2] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 1/2] build: add meson options of atomic_mbuf_ref_counts Kefu Chai
2021-10-14 8:20 ` Bruce Richardson
2021-10-25 15:55 ` Thomas Monjalon
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 2/2] build: add meson options of max_memseg_lists Kefu Chai
2021-10-14 8:25 ` Bruce Richardson
2021-10-14 8:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2642296.XfZ1dg20Xv@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=avi@scylladb.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=tchaikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).