From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C937943CE2; Mon, 18 Mar 2024 10:38:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C0D840289; Mon, 18 Mar 2024 10:38:19 +0100 (CET) Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) by mails.dpdk.org (Postfix) with ESMTP id 6B4A24026E for <dev@dpdk.org>; Mon, 18 Mar 2024 10:38:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A7EE711400E3; Mon, 18 Mar 2024 05:38:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 18 Mar 2024 05:38:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1710754697; x=1710841097; bh=IXez4fXcWwDMPzuT9mXTuBJdbYpHmraPb5TRvL9zTFM=; b= dR0LxlMCC+8glio/haVh4M8oX7mS4mAGVEoe9STQyGOBzGSO2+LX/MVvDks8AOtX FOaY+rf4cSEEzrZ8OI8++NR72urgym93A2s8gg5OeY+Pm8M/bK72VDYYRphAHZlD U15VvgY+15U1xa8IAh52eNKB0VdQt4tj5fZ5L1FGP9rbUqa+QOfueuTGOrb6seRv l7b/c/B5WDeTu4VLdgQBEGoNaxk4KH9uWEOuUPUDe3Pf8dxVBkGiZWfzVzzLUNTf RQzr1+lPouYReHaj0C5AhLb+jg0EeSpQGz6EynKpIxGV+JLBecvsVp4I0QXfSQQz uDe8QUNuzTsi6WyE2SmUiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1710754697; x= 1710841097; bh=IXez4fXcWwDMPzuT9mXTuBJdbYpHmraPb5TRvL9zTFM=; b=o aTNS5TUL1XEzcp7mnXgW1knAj5yhtL6w7FNcB46zzTitHQ4WaXHJGJQSlpngmQRM OaUK31FkNGt19ut1K2weFmVgde5AJEuGYPiXT585C7LFyaRP8e3AwlgWN82w3Sfj 6VWxn4T7dc+AEqplIdOeTsuY/k8tXCmLJ2WTopA6j3e1F/Vo4VMki1bjJSCQGkBW o5wbpAbI4hRMRgYgCOnrl+ICIdMnj8QPtyDuql55qz4mREdVyXCps1Nhr86+VpA8 1js5QlFwSirdW62qflD6mIAioPR+VOB47NgyPqc07M5nMqsABiMT0Ue/OLwLE/nx gGARHrq80Y9Vr5Nth7+KQ== X-ME-Sender: <xms:iAv4Zdg5N8Doa42aju5UhwmSzWSQ2ayuLea9Dr0ZXoiclfTi6E1Nfg> <xme:iAv4ZSDNkWDdYmLLqYRVvXxmGYNpWgVmBkkdGSl4hAjvnoskL-PIS0I0bVr7Y751n VDZ2IJfsvJF__nfvg> X-ME-Received: <xmr:iAv4ZdFuP-3U54fAoV5zC2Y4x1jvbJhYp_5XQ_qzpZ-tRPuXclVsJvwWkKRoc7vlocTcDa3kVu7ziUzzu0Y1f7OSYQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrkeejgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:iAv4ZSRhIa2MPjuiCAWeSbY5Pol012JNgtHPaKvBbaKHhwLrha31Tg> <xmx:iQv4Zax48LUbLv9lhzy7-5jOhPL0XtZzkTApIPWA7JQvT47gPzOJNg> <xmx:iQv4ZY6FRGt4cnamuoz0l82z0y66jEue04kJ7Uzn-d8zJMZVO0n9ag> <xmx:iQv4ZfwCsPEY5dHwrZjQg1dxQ8H5mEJz29sSgLoGr_sNwCLN7301Mg> <xmx:iQv4ZUt16MB6vYq7raQz1yXGZbyhVeqDYD-Zqacbo_tDMGZXQmjHRw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Mar 2024 05:38:16 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Chengwen Feng <fengchengwen@huawei.com> Cc: david.marchand@redhat.com, dev@dpdk.org Subject: Re: [PATCH v3 4/6] argparse: fix argument flags operate as uint32 type Date: Mon, 18 Mar 2024 10:38:14 +0100 Message-ID: <2643015.tIAgqjz4sF@thomas> In-Reply-To: <20240318091848.14360-5-fengchengwen@huawei.com> References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318091848.14360-1-fengchengwen@huawei.com> <20240318091848.14360-5-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 18/03/2024 10:18, Chengwen Feng: > --- a/app/test/test_argparse.c > +++ b/app/test/test_argparse.c > +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0) > +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2) Don't you want to make it part of the API? I thought it was what you did in this v3.