From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF65456F5; Tue, 30 Jul 2024 18:20:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB778402F1; Tue, 30 Jul 2024 18:20:00 +0200 (CEST) Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id 6728E402EB; Tue, 30 Jul 2024 18:12:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 79EC313805EA; Tue, 30 Jul 2024 12:12:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 30 Jul 2024 12:12:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1722355948; x=1722442348; bh=6mmV2Ed5VaxR0gOdj2c35D9XSY1/r4Nw0x+qjZCJL8c=; b= lixbpQ1wP0zj4aQqF8Zb4P5vrab3Ed0sWhJsxJT+7y6DPxISUFVdI+IaNT1/q7pJ zam7ZHtaZNoI/aIBMW0Zd0vNOTzVbnAB0oiuRp3SoGY7b6Dv8a+0dmxomUt2/NZR KgNJwisL7SfdzX9yuDeWL3fh5d+CDGhXgB/oPKR9fIdKZl9hGbPfkXfM11UUlaYn EONLINNKyRkJG+HG7KBP2EYQR/92m+by9IvDdjRZX7tFovtCffMRuh73bh8sNXwX sn669PkpvChVMB/UiawkcedtD8nhn2lo9XF9iAMiP3A/U8dzv7Uh/h8nairju379 pt90nHKcw9mULO4bzpwybQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722355948; x= 1722442348; bh=6mmV2Ed5VaxR0gOdj2c35D9XSY1/r4Nw0x+qjZCJL8c=; b=j qhEjeIEvuGIUrpcJqgnQ+6H0LSObZ0fik5Yqx1gNuKLAVACQldLA83V2Fy9MUfx/ I+KDJTZ/jADiHeuXmcFd63gNKJUtq8owcj6Jx2J02XBgiqPjwzcVhM2W6MihtxHM KKDWwhFv4EXjV64XFWORgw74XbETJHajJMNGcPG+lxDfbpf1PCSKGAkNnyvP4Cvs mcwCACOB1Am2sc085vp8RifWZIgzE1cs948Zzx4JrlSs9w4loiItl+ipoheZz7FB d0AB+XC87B0f8CVR5DHYt4ewVkxvpgT7728xX306aDn1a9Ek2L2YllqmUKwJgoAp BDS6I490KvkY6qWplFb7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjeeggdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Jul 2024 12:12:24 -0400 (EDT) From: Thomas Monjalon To: Rakesh Kudurumalla Cc: ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, orika@nvidia.com, dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com, stable@dpdk.org Subject: Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability Date: Tue, 30 Jul 2024 18:12:20 +0200 Message-ID: <2648204.9Mp67QZiUf@thomas> In-Reply-To: <20240730100335.3734796-1-rkudurumalla@marvell.com> References: <20240729061026.3729690-1-rkudurumalla@marvell.com> <20240730100335.3734796-1-rkudurumalla@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, 30/07/2024 12:03, Rakesh Kudurumalla: > This patch addresses the issue by introducing a delay Please start with describing the issue. > before acquiring the lock in the loop. This delay allows for better > availability of the lock, ensuring that show_lcore_stats() can > periodically update the statistics even when forwarding jobs are running. Why a delay is better than a pause? > @@ -542,7 +542,7 @@ l2fwd_main_loop(void) > } while (likely(stats_read_pending == 0)); > > rte_spinlock_unlock(&qconf->lock); > - rte_pause(); > + rte_delay_us(10); > }