From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE289A0562; Wed, 14 Apr 2021 23:33:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DFB4161D3E; Wed, 14 Apr 2021 23:33:51 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id E63FC161D3B for ; Wed, 14 Apr 2021 23:33:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 49C7D580C10; Wed, 14 Apr 2021 17:33:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 17:33:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= OCaaIH8xx28ZtgpI4J3AmuPw7mlpz1VO1rCCBrFOdYk=; b=Sb7/rpMqEBHMpsTW wn7RnkdaAdZakID13UXDepKMfqe8pBoRePHns2JwtakG8bMYjfRAmxNhjI36s9d6 gBldl1V/6tyALIG5AE0HBP5u40UmwLp6RF/RWfzFq+gZjf7JMpNVeoxufOcgHsEc Xd7LxkPtkOwMje1zwBvlWcuJceD/4QbTAIgR41D0HMR5e71W3BpTTsn93EwRq070 u9DAjFGWnG7tm+g20klxRLJkzzI8N9sUTq+YFUFFkD7MFz9ROK1vbMx503oVfuK8 +JnTOpc9XYu/Ty0qJxGc1bQumRKj0oWJbDLv7fqnxf7wU5c/rc6FUfPm/TROzOyi 5QzwdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OCaaIH8xx28ZtgpI4J3AmuPw7mlpz1VO1rCCBrFOd Yk=; b=vhVvi97adbvoRAykH8VT/X6UT5oWe0ai9C76Kuhtfjwdsnz2Aem6ZTBv+ GppBvnPNVv6h9G2ErnIB90QBmoliy9z79rqOHAZvVFyGTBckIEPcYodPNb378+uN lmMQDDwuJQpU1hcpZMGlbCQ+8wCq49nnu+t9GwKmE5ozlDk1+OmyqUk5Hg9rsFwA y5TDXWHEQkSKXn4cqepvQwXE1OxZm0mXzK/nWxGqeD8cH97l9xgh2kh7Uu9oI2Kk OKDNcuE0+KjrZMH5hU+IihRdgRhIjR5rjL8E+LtCXDAkj5MZoJoqRDeqfXPfjipa 717Dxf6EDpLxRWfmdp5vvIeEO942g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudeigecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E9720240057; Wed, 14 Apr 2021 17:33:46 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Beilei Xing , Jeff Guo , Olivier Matz , Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ferruh Yigit , Andrew Rybchenko , Dmitry Kozlyuk Date: Wed, 14 Apr 2021 23:33:45 +0200 Message-ID: <2650023.nygtLaPhlT@thomas> In-Reply-To: <20210410224732.20234-3-dmitry.kozliuk@gmail.com> References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <20210410224732.20234-1-dmitry.kozliuk@gmail.com> <20210410224732.20234-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 2/4] eal: make OS shims internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/04/2021 00:47, Dmitry Kozlyuk: > DPDK code often relies on functions and macros that are not standard C, > but are found on all platforms, even if by slightly different names. > Windows provided macros or inline definitions for such symbols. > However, when placed in public header, these symbols were unnecessarily > exposed, breaking consumer POSIX compatibility code. > > Move most of the shims to , a header to be used instead > of by internal code. Include it in libraries and PMDs that > previously imported shims from . Directly replace shims that > were only used inside EAL: > * index -> strchr, rindex -> strrchr > * sleep -> rte_delay_us_sleep > * strerror_r -> strerror_s > > Signed-off-by: Dmitry Kozlyuk Acked-by: Thomas Monjalon