From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1D224378B for ; Fri, 4 Aug 2017 11:36:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C0AB0206E6; Fri, 4 Aug 2017 05:36:30 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 04 Aug 2017 05:36:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qUzB6fhXUcs8iLB qKsTJEPa1lX53v2kYIP064D/mBnM=; b=e7nOMldf4lSniRmBSQyAF9X6+kFlYo9 30nUyJ2RR0rvrU9MgX1HViarRM/daShzAwYMOiuDcWWyB6B4xJKxvLwgxQmWBamr lHsJ526AgwbUO2HmAYJqAR70O/0h4vrGr0T7DNfb/jl0qeISEFdQbYxeyvE350iw kd6QbkZJ64PY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qUzB6fhXUcs8iLBqKsTJEPa1lX53v2kYIP064D/mBnM=; b=HmDqK3Ap 8XWeT5zzAaNXf6myYIalBIbOZwu6yx/JZzifAbjQUwS1qR4/icTMHz59T+LB4ujp qlAYnJs9CPdMt4/4XeSe9kUuLefh0StSnj8bjzNnUDUB8XJEzQ/KhaFo9X0MHz4c fGvkLDK5qVm37zYVcA9kvsRAWYQXOLeI/PuORCPbWdFvlcnnBlhZTvNE5Jg1cXDH IdJ7IAynQ+ulpMfrZwV+ljXzRRsuHKt3XrFy4yqnCj31jMNp0bkTW4hVR63BUdiM CXy4tSpWBgJBlDblQGhJC6tHtSkBUPoc0JLBCzCvoZX46onLBDmzLBY2XyZyoWHf kADtiQ8GAxTkeQ== X-ME-Sender: X-Sasl-enc: GE6KTUX9jV3N2GrhsMusT+pG3r6wzhV42VpmQ6XqgRWa 1501839388 Received: from xps.localnet (159.16.90.92.rev.sfr.net [92.90.16.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B7A1244AA; Fri, 4 Aug 2017 05:36:28 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org, "shreyansh.jain@nxp.com" Date: Fri, 04 Aug 2017 11:36:22 +0200 Message-ID: <2651056.W04Ra9JkEP@xps> In-Reply-To: <3F5BA2D9419A984DBB40DB5CFACBB36D1F9D8F2F@IRSMSX101.ger.corp.intel.com> References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <2019184.UUXt4e9AVR@xps> <3F5BA2D9419A984DBB40DB5CFACBB36D1F9D8F2F@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 09:36:31 -0000 04/08/2017 10:22, Hunt, David: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > 07/06/2017 16:37, David Hunt: > > Users can now use 'make defconfig' to generate a configuration using > > the most appropriate defaults for the current machine. > > > > > > arch taken from uname -m > > machine defaults to native > > execenv is taken from uname, Linux=linuxapp, otherwise bsdapp > > toolchain is taken from $CC -v to see which compiler to use > > > > Signed-off-by: David Hunt > > Acked-by: Shreyansh Jain > > Looks to be a good idea if it is really automatic. > > > + ${CC} -v 2>&1 | \ > > + grep " version " | cut -d ' ' -f 1) > > Unfortunately, it depends on $CC which is not commonly exported. > What about defaulting to gcc? > > > - @echo "Configuration done" > > + @echo "Configuration done using "$(shell basename \ > > + $(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g") > > RTE_CONFIG_TEMPLATE is not defined in this patch (and I do not see the benefit in next patch). > > Thomas, > Does this mean that this patch is not going into this release? It has been acked for almost a month now, with no further comment. The one hour between your comment and the release of RC4 did not give me a reasonable amount of time to address your concerns. I also feel that the lack of comments in the last month should mean that the patch should be applied as is. If changes are required, I am happy to address in the next release. You're right, I'm very sorry not taking time to review it before. I think only the first patch should be integrated, without the comment for RTE_CONFIG_TEMPLATE. Opinion?