* [PATCH] dmadev: add missing header include
@ 2022-02-22 11:41 Thomas Monjalon
2022-02-22 11:48 ` Bruce Richardson
2022-02-22 13:44 ` Walsh, Conor
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-02-22 11:41 UTC (permalink / raw)
To: dev
Cc: bruce.richardson, stable, Chengwen Feng, Kevin Laatz,
Morten Brørup, Conor Walsh
When checking C++ compatibility of SDK headers,
an error is detected by the compiler:
lib/dmadev/rte_dmadev_pmd.h:95:23: error:
‘RTE_DEV_NAME_MAX_LEN’ undeclared here (not in a function)
The header file rte_dev.h must be included.
Fixes: b36970f2e13e ("dmadev: introduce DMA device library")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/dmadev/rte_dmadev_pmd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h
index 5316ad5b5f..82ab7a8cc7 100644
--- a/lib/dmadev/rte_dmadev_pmd.h
+++ b/lib/dmadev/rte_dmadev_pmd.h
@@ -14,6 +14,8 @@
* by any application.
*/
+#include <rte_dev.h>
+
#include "rte_dmadev.h"
#ifdef __cplusplus
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmadev: add missing header include
2022-02-22 11:41 [PATCH] dmadev: add missing header include Thomas Monjalon
@ 2022-02-22 11:48 ` Bruce Richardson
2022-02-22 13:44 ` Thomas Monjalon
2022-02-22 13:44 ` Walsh, Conor
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2022-02-22 11:48 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, stable, Chengwen Feng, Kevin Laatz, Morten Brørup, Conor Walsh
On Tue, Feb 22, 2022 at 12:41:04PM +0100, Thomas Monjalon wrote:
> When checking C++ compatibility of SDK headers,
> an error is detected by the compiler:
>
> lib/dmadev/rte_dmadev_pmd.h:95:23: error:
> ‘RTE_DEV_NAME_MAX_LEN’ undeclared here (not in a function)
>
> The header file rte_dev.h must be included.
>
> Fixes: b36970f2e13e ("dmadev: introduce DMA device library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmadev: add missing header include
2022-02-22 11:48 ` Bruce Richardson
@ 2022-02-22 13:44 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-02-22 13:44 UTC (permalink / raw)
To: Bruce Richardson
Cc: dev, stable, Chengwen Feng, Kevin Laatz, Morten Brørup, Conor Walsh
22/02/2022 12:48, Bruce Richardson:
> On Tue, Feb 22, 2022 at 12:41:04PM +0100, Thomas Monjalon wrote:
> > When checking C++ compatibility of SDK headers,
> > an error is detected by the compiler:
> >
> > lib/dmadev/rte_dmadev_pmd.h:95:23: error:
> > ‘RTE_DEV_NAME_MAX_LEN’ undeclared here (not in a function)
> >
> > The header file rte_dev.h must be included.
> >
> > Fixes: b36970f2e13e ("dmadev: introduce DMA device library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] dmadev: add missing header include
2022-02-22 11:41 [PATCH] dmadev: add missing header include Thomas Monjalon
2022-02-22 11:48 ` Bruce Richardson
@ 2022-02-22 13:44 ` Walsh, Conor
1 sibling, 0 replies; 4+ messages in thread
From: Walsh, Conor @ 2022-02-22 13:44 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Richardson, Bruce, stable, Chengwen Feng, Laatz, Kevin,
Morten Brørup
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday 22 February 2022 11:41
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org;
> Chengwen Feng <fengchengwen@huawei.com>; Laatz, Kevin
> <kevin.laatz@intel.com>; Morten Brørup <mb@smartsharesystems.com>;
> Walsh, Conor <conor.walsh@intel.com>
> Subject: [PATCH] dmadev: add missing header include
>
> When checking C++ compatibility of SDK headers,
> an error is detected by the compiler:
>
> lib/dmadev/rte_dmadev_pmd.h:95:23: error:
> ‘RTE_DEV_NAME_MAX_LEN’ undeclared here (not in a function)
>
> The header file rte_dev.h must be included.
>
> Fixes: b36970f2e13e ("dmadev: introduce DMA device library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Conor Walsh <conor.walsh@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-22 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-22 11:41 [PATCH] dmadev: add missing header include Thomas Monjalon
2022-02-22 11:48 ` Bruce Richardson
2022-02-22 13:44 ` Thomas Monjalon
2022-02-22 13:44 ` Walsh, Conor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).