From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority
Date: Tue, 25 Sep 2018 14:57:14 +0200 [thread overview]
Message-ID: <2653701.FErX7ZCc7E@xps> (raw)
In-Reply-To: <1537878167.10481.46.camel@debian.org>
25/09/2018 14:22, Luca Boccassi:
> On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote:
> > 24/08/2018 18:47, Konstantin Ananyev:
> > > If user specifies priority=0 for some of ACL rules
> > > that can cause rte_acl_classify to return wrong results.
> > > The reason is that priority zero is used internally for no-match
> > > nodes.
> > > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=79.
> > > The simplest way to overcome the issue is just not allow zero
> > > to be a valid priority for the rule.
> > >
> > > Fixes: dc276b5780c2 ("acl: new library")
> > >
> > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >
> > Cc: stable@dpdk.org
> >
> > Applied with below title, thanks
> > acl: forbid rule with priority zero
>
> Hi,
>
> This patch is marked for stable, but it changes an enum in a public
> header so it looks like an ABI breakage? Have I got it wrong?
- RTE_ACL_MIN_PRIORITY = 0,
+ RTE_ACL_MIN_PRIORITY = 1,
In my understanding, the change is not breaking the ABI because
the old minimal value (0) can still be used, with the same side effect.
The new value is just removing a side effect for newly compiled apps.
Konstantin, am I right?
next prev parent reply other threads:[~2018-09-25 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 16:47 Konstantin Ananyev
2018-09-16 9:56 ` Thomas Monjalon
2018-09-25 12:22 ` Luca Boccassi
2018-09-25 12:57 ` Thomas Monjalon [this message]
2018-09-25 14:34 ` Ananyev, Konstantin
2018-10-03 16:18 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2653701.FErX7ZCc7E@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).