From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 585672BA3 for ; Thu, 17 Jan 2019 19:23:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4240A14B2; Thu, 17 Jan 2019 13:23:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 13:23:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mdlJib+nsLYbQRRj2Vw/S3KEl5Qmiyecu94inL5TL4Y=; b=ke/rmyqdUugW nEsMuQKI11S2BvHIapcdmAQIJwy8ozOW7FwEe7cUVH4pV8RgtCZzJymEdEa3eGX0 IkKn86pZWt1dQU9UKY1rfneVmBgoC1vcMpghcczVS/tY87nUmgvVvpzkFzHOrfaq bs5bxI4ELFR5mVQ33J3FSejKG55o9nw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mdlJib+nsLYbQRRj2Vw/S3KEl5Qmiyecu94inL5TL 4Y=; b=noLJAirk+KP2Embz+HyNDnxzF22113Cj5WsVuuffJeVDuSp8wtJ/Yix1J ESm6S1+R/Gew42UrHS83AfgGXCXek8KtfGD0US/4rfl7vC6JcA/5Jni+T9MOJZu0 uVIxqkLs2GR+Fnxocsocq/VzoVBpxlWmFveYi85ByyWeHJbWGq6WIhY2+xbcYbTz VKM6boC2C9+7wOMGlx8FERdf/rNjPJGoT22/aCDcTVL1Ozk8EIkX/ayAJGqlXTON ebJT4DH6ZNDusypiFPdPkifYrRTHHIPH4IYWpXm5eJLfcvJvZmuMy0EULay7VLWh GAKHxfV8HAiBWkdV7vXVj4kS8hQlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AE3C4E4652; Thu, 17 Jan 2019 13:23:09 -0500 (EST) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, Ferruh Yigit , bruce.richardson@intel.com Date: Thu, 17 Jan 2019 19:23:08 +0100 Message-ID: <2654509.CpMWhpLgrV@xps> In-Reply-To: <884f29ec-a85d-41f2-abd7-17b5bbeea3bb@intel.com> References: <20190117171744.63455-1-harry.van.haaren@intel.com> <884f29ec-a85d-41f2-abd7-17b5bbeea3bb@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 18:23:12 -0000 17/01/2019 18:23, Ferruh Yigit: > On 1/17/2019 5:17 PM, Harry van Haaren wrote: > > This commit reworks the checks for binutils 2.30 and how > > the flags to disable AVX512F are passed to the compiler. > > > > Previously the #define for including AVX512 code was set, > > while the -mno-avx512f argument was given to the compiler. > > This would cause gcc to correctly refuse to emit AVX512 > > instructions, but the rte_memcpy code that includes AVX512 > > optimizations was being added to the build. > > > > The check for binutils check is now moved to x86 as it is > > irrelevant for other architectures, and the -mno-avx512f > > flag is passed to a march_opts array in meson. As the > > -mno-avx512 flag is added earlier in the build, the code > > in rte_memcpy is no longer attempted to be compiled. > > > > This commit also adds a message print in the meson configure > > stage to alert the user of the workaround being employed. > > > > Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") > > > > Signed-off-by: Harry van Haaren > > Tested-by: Ferruh Yigit > > Thanks for the fix Harry. Applied (with message reworded as suggested), thanks