From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CCFDA09FF; Mon, 11 Jan 2021 17:17:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2561C140F3A; Mon, 11 Jan 2021 17:17:07 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 20310140F27 for ; Mon, 11 Jan 2021 17:17:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 142D42392; Mon, 11 Jan 2021 11:17:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 11 Jan 2021 11:17:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= dZ61pWSQT07wI4hTc1IeHtBafIb5mAG6jZ9sursOTTw=; b=oM8BQFnNgr7FIam4 IL6wg4ERApe1+UyCa/9Usm14OYnmRKO2idKppSzMQazm3L6/Au6LjpgR4gAgPOEz gPT2akcxgKKakcdQdvBYsD5MScAXJDpUPdlrc9MvqhYFiaSsRTjRSMbOX+Ew7Ee7 kIEfxlLA1UQ9VZHL8fapDZiqifnohUOKvfqLoXAG6jD6ydLe/USubaGeEtXWm40U 6WfMi4lYxXdDoCfjNLseLru9Tf8i6R6SesD64JH/h7OMU7TbQ0cFKpaaIvtpLpd+ QhSrlD9RV2r7rr50O2yTcoBRhwJpZSseYqHJGDbdVzXuHQlcMM7KSrTA4k60Z6EV 9yen7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dZ61pWSQT07wI4hTc1IeHtBafIb5mAG6jZ9sursOT Tw=; b=WcUDqk+vENd9CzN0inAgy920HSvMB9VGRZsSvteaEsx71pLbPwwJf64Qp +jNt6JFIGH8gxGSl/PJlMe7UvndzzLcRaAnBjTaZBbUqWX4tj/oj2cHtbnJKLjog y0tL4NoVBuqRqX9pD0N4ahzOS+3g4RwGv8lUK+ZlSWTk1FyN3l7w+qlGUYn/6OPy NJgGdIY/1tGjZr0YM1b1d5Eq7AgF54WoIrm4OpTU8utQcM8LVaEmqq8whnjLZ3O1 KtELy9fGRKTKhf55X+xS8htCs1URVREp/S/mAbSXO0Syz6nooQm8D1J8m2LQOEFX JrvxF9JyO8PxaXsf+ToWVv4RWhM3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdehuddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepleekhfejgeetudejteduteevgfefudfgkeevveeuudfgleefvdei fefhgfdtfeeinecuffhomhgrihhnpedtqdhprhdvrdgrshenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 61D8F240065; Mon, 11 Jan 2021 11:17:03 -0500 (EST) From: Thomas Monjalon To: Liron Himi Cc: "ferruh.yigit@intel.com" , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Liron Himi Date: Mon, 11 Jan 2021 17:17:01 +0100 Message-ID: <2658408.858OVXDmSS@thomas> In-Reply-To: References: <20201215222319.13816-1-lironh@marvell.com> <1776515.fif75YaaBN@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/01/2021 17:08, Liron Himi: > From: Thomas Monjalon > Sent: Monday, 11 January 2021 18:05 > To: Liron Himi > Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran ; Liron Himi > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers > > 11/01/2021 16:29, Liron Himi: > > Hi Thomas, > > > > When did you take this MUSDK version? > > Is this your head "pkg-config: expose dma-add-size"? > > I'm using musdk-SDK-10.3.5.0-PR2 as recommended in the doc. > > > If not, this explain the mvneta issue. > > I already noticed that and pushed a fixed to the github. > > I see. So it may need a doc update. > [L.H.] why need to update the doc? It is still the same release branch, I just added a fix patch to it. Yes, my bad: I used the tag musdk-SDK-10.3.5.0-PR2 instead of the branch musdk-release-SDK-10.3.5.0-PR2. > > As for the prefix issue, > > The prefix is being set in the 'configure' phase by using the '--prefix' variable. Have you tried that? > > No I didn't try that, and I'm using DESTDIR variable when installing. > Whould it be possible to update the prefix with DESTDIR when installing? > [L.H.] need to explore this option. But for now use 'prefix', as this is what supported by MUSDK OK > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Monday, 11 January 2021 13:28 > > To: Liron Himi > > Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran > > > > Subject: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for > > armada drivers > > > > External Email > > > > ---------------------------------------------------------------------- > > 16/12/2020 22:36, lironh@marvell.com: > > > From: Liron Himi > > > > > > With pkg-config support available within musdk library (from > > > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' > > > can be removed. > > > PKG_CONFIG_PATH environment variable should be set appropriately to > > > use the musdk library. > > > > Sorry, it does not work. > > > > First, when installing MUSDK, the .pc file is not updated with the correct prefix path: > > make install DESTDIR=$(readlink -f install) In install/mv/lib/pkgconfig/libmusdk.pc: > > prefix=/mv > > instead of: > > prefix=/musdk_path/install/mv > > > > Second, after manually fixing the prefix path and compiling DPDK: > > > > In file included from musdk/install/mv/include/mv_std.h:101, > > from musdk/install/mv/include/drivers/mv_neta.h:100, > > from dpdk/drivers/net/mvneta/mvneta_ethdev.h:24, > > from dpdk/drivers/net/mvneta/mvneta_rxtx.h:10, > > from dpdk/drivers/net/mvneta/mvneta_rxtx.c:7: > > musdk/install/mv/include/env/mv_autogen_build_assert.h:43:5: error: > > "MVCONF_DMA_PHYS_ADDR_T_SIZE" is not defined, evaluates to 0 > > [-Werror=undef] > > musdk/install/mv/include/env/mv_autogen_build_assert.h:44:2: error: > > #error "MVCONF_DMA_PHYS_ADDR_T_SIZE must match size used during musdk_lib compilation." > > > > The CFLAGS may be incomplete: > > Cflags: -I${includedir} -DMVCONF_TYPES_PUBLIC -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC I fixed it by adding: > > -DMVCONF_DMA_PHYS_ADDR_T_SIZE=64 > > > > Please could you fix MUSDK quickly? > > > > I think I will pull next-net as is, but I consider it is broken. > > > > > > > > > > > >