From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id B174C7F60 for ; Wed, 5 Nov 2014 22:48:37 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id k14so2013049wgh.0 for ; Wed, 05 Nov 2014 13:58:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=K9+hr/9/ve/cYkO0gSk2dtduur7FHE2Z8rAkRoPYU20=; b=bwzjMFwt9fUryeveC3DgwKBh4wzCfbM70jWXTm8qlG/6YqQFdCYnOVByLpLczKL/O2 YqRuc1N5FzXB8+POxcwNu/+ygzlJKZo2hPxxEZtUwSAAcZYFuZ71/xpjhAbOyEdYocnn U5OPriNMEl7lWUJKrLXR/fkMKjEWG1AYkNy7f5Iw4ksxmFPAIZw/ob0LQBTznSjuBp5q IwNezaNWRlr6zkWecpJ0tSrPWyhWsBbq1lHC84jixmyp04Me0WL4yDEO10D7ukuHs+jv lQFdYOe2BYBhWC7nr7gT9FFLzIzRh6/fk8atbER0kMxnYNxshnvapK/o6O29Fg9r0WFp Ujsw== X-Gm-Message-State: ALoCoQlc0H56goaJ1dvHFYB//fejOTyiSI9D9CmrYWhORn+wPmrrrOFSrzkMtsX3NYnorK9NJAbW X-Received: by 10.194.171.201 with SMTP id aw9mr1294wjc.67.1415224682318; Wed, 05 Nov 2014 13:58:02 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id r2sm5990202wif.23.2014.11.05.13.58.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Nov 2014 13:58:01 -0800 (PST) From: Thomas Monjalon To: Chao Zhu , David Marchand Date: Wed, 05 Nov 2014 22:57:42 +0100 Message-ID: <2660902.epKVdpL28Y@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <54598DFC.6070006@linux.vnet.ibm.com> References: <1414500657-23774-1-git-send-email-david.marchand@6wind.com> <54598DFC.6070006@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, bjzhuc@cn.ibm.com Subject: Re: [dpdk-dev] [PATCH v3 00/10] split architecture specific operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 21:48:37 -0000 > > The set of patches split x86 architecture specific operations from DPDK and put > > them to x86 arch directory. > > This will make the adoption of DPDK much easier on other computer architecture. > > For a new architecture, just add an architecture specific directory and > > necessary building configuration files, then DPDK eal library can support it. > > > > > > Reviewing patchset from Chao, I ended up modifying it along the way, > > so here is a new iteration of this patchset. > > > > Changes since Chao v2 patchset : > > > > - added a preliminary patch for moving rte_atomic.h (for better readability) > > - fixed documentation generation > > - implemented a generic header for each arch specific header (cpuflags, memcpy, > > prefetch were missing) > > - removed C++ stuff from generic headers > > - centralised all doxygen stuff in generic headers (no need to have duplicates) > > - refactored rte_cycles functions > > - moved vmware tsc stuff to arch rte_cycles.h headers > > - finished x86 factorisation > > > > > > Little summary of current state : > > > > - all applications continue to include the eal headers as before, these headers > > are the arch-specific ones > > - the arch specific headers always include the generic ones. The generic headers > > contain the doxygen documentation and code common to all architectures > > - a x86 architecture has been defined which handles both 32bits and 64bits > > peculiarities > > > > > > It builds fine for 32/64 bits (w and w/o "force intrinsics"), but I really would > > like a lot of eyes on this (and I would say, especially, rte_cycles, rte_memcpy > > and rte_cpuflags). > > I still have some concerns about the use of intrinsics for architecture != x86 > > but I think Chao will be the best to look at this. > > > > > Acked-by: Chao Zhu Acked-by: Thomas Monjalon Applied Thanks for the big clean-up. Now we are ready to accept new CPUs. -- Thomas