From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 0FA0156A4 for ; Wed, 1 Apr 2015 21:58:48 +0200 (CEST) Received: by wibgn9 with SMTP id gn9so80081729wib.1 for ; Wed, 01 Apr 2015 12:58:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=O33Saxmht4Grf5p6fMR+IESoSoxvFCfbOQwZwcpcQXM=; b=IzfaCZCM9TWiQDSqc75Sr7TXSEsUZsEm26Z/BGDIfbqIEV9c4UgifL0lQIavvgcU9v ioYuCjeP5+y2CTN40M+C5Okf1kag4kdJOx+6pMWeo7AcLxxAB8xWUe85BH7mzUjkrut6 xD6+QS+aV0ho5dFfj983ifZoN3sKtCcA5vVLqaVLQfVqogDgzDNH73HUc9re8DapNEV0 7QzO4+90fonvXRKAgPHbP/sO7dwA7RLIneyp83FKq4kgyxqXFy5VWJJ5GKtCwlvV4MAS tt6WtJiRArFb8ndEQLDXZmQH6VrQg93knF90j0bDombCC8NLExICviB2EUw0xpg7y5Oe x4Vw== X-Gm-Message-State: ALoCoQluVApiU3bx+0qC1mYMNiOzGvZxdbU2yns9T4UdvkQiyEdM2bBWg4GxnB39uQK8akP8E7T2 X-Received: by 10.194.81.104 with SMTP id z8mr85698167wjx.45.1427918326928; Wed, 01 Apr 2015 12:58:46 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cz7sm4578932wib.15.2015.04.01.12.58.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 12:58:46 -0700 (PDT) From: Thomas Monjalon To: huawei.xie@intel.com, changchun.ouyang@intel.com Date: Wed, 01 Apr 2015 21:58:04 +0200 Message-ID: <2662680.fVrczecCFl@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <551AF4EF.5090104@6wind.com> References: <1427824702-5119-1-git-send-email-thomas.monjalon@6wind.com> <551AF4EF.5090104@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mbuf: clean old refcnt option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 19:58:48 -0000 2015-03-31 21:26, Olivier MATZ: > Hi Thomas, > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote: > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into CONFIG_RTE_MBUF_REFCNT > > by commit 62814bc2e923 and removed by commit 4769bc5a27cc. > > Some traces remain because of delayed patches. > > > > It can also be removed from doxygen config. > > It is now poisoned in rte_mbuf.h to warn any misuse. > > > > Fixes: d0dff9ba445e ("doc: sample application user guide") > > Fixes: fc1f2750a3ec ("doc: programmers guide") > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt") > > > > Signed-off-by: Thomas Monjalon [...] > > --- a/doc/guides/sample_app_ug/vhost.rst > > +++ b/doc/guides/sample_app_ug/vhost.rst > > @@ -338,28 +338,6 @@ Compiling the Sample Code > > > > .. code-block:: console > > > > - make > > - > > - .. note:: > > - > > - Note For zero copy, need firstly disable CONFIG_RTE_MBUF_SCATTER_GATHER, > > - CONFIG_RTE_LIBRTE_IP_FRAG and CONFIG_RTE_LIBRTE_DISTRIBUTOR > > - in the config file and then re-configure and compile the core lib, and then build the application: > > - > > - .. code-block:: console > > - > > - vi ${RTE_SDK}/config/common_linuxapp > > - > > - change it as follows: > > - > > - :: > > - > > - CONFIG_RTE_MBUF_SCATTER_GATHER=n > > - CONFIG_RTE_LIBRTE_IP_FRAG=n > > - CONFIG_RTE_LIBRTE_DISTRIBUTOR=n > > - > > - .. code-block:: console > > - > > cd ${RTE_SDK} > > make config ${RTE_TARGET} > > make install ${RTE_TARGET} Note that make config is useless and T= is missing. > I have one doubt about the vhost part, as the previous doc was telling > to disable refcnt option and now the behavior is equivalent to having > the option always enabled. Also you are removing parts of doc that > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and CONFIG_RTE_LIBRTE_IP_FRAG. > > It would be safer to also have an acknowledgment from a vhost expert. Huawei, Changchun, any opinion please?