From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 316FE8E99 for ; Tue, 20 Oct 2015 09:04:55 +0200 (CEST) Received: by wicll6 with SMTP id ll6so30688033wic.0 for ; Tue, 20 Oct 2015 00:04:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=AIfs31SL4jh5NsL9+XK3CXG0X5nkw/YUJWlCExVNN3g=; b=Qy4ZK8H6aSF/9IOVV1MNCnPJs0BrcfkzNike4dhPPO6b2DGq2v0L7lcKUgOCRlivmg pz80jXjl6ggxMZnyHd9vvQjWsSAqf9a7NXKYsdw7tuUcdmedm5FBJlWvnzr2TSi1Dnaw JvK8zZwcwU8ONS00fUQ02AJKHhRFGVfKseetWPIjnAVeghd7Y2j3xTg1XZViwCk1D/c9 w+FTmr7bkD1akZbMBL6zH8nCqd2IKPnUl2xnphrQ/C5um03CZ67Xn1DJ1pQMiq5YFxcK eXCOJbRgNfwdW98I7nrx0sIW5jO9fTo4qL3XW3gqDFI5DXGu+ISrRavFHsZZeL8Zddi8 lYhQ== X-Gm-Message-State: ALoCoQkfexiWKjTeHlDZo6YLTqyC2F0ly3WgSB1IJdZP74Jb+tbE8ZvTlthdo9toumUq9v0JzMU0 X-Received: by 10.180.87.194 with SMTP id ba2mr25021005wib.11.1445324694916; Tue, 20 Oct 2015 00:04:54 -0700 (PDT) Received: from xps13.localnet (115.202.154.77.rev.sfr.net. [77.154.202.115]) by smtp.gmail.com with ESMTPSA id v9sm1849596wjv.45.2015.10.20.00.04.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Oct 2015 00:04:54 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Date: Tue, 20 Oct 2015 09:03:48 +0200 Message-ID: <2663202.cvIv1Wzbri@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1444369572-1157-6-git-send-email-yuanhan.liu@linux.intel.com> References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com> <1444369572-1157-6-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v6 05/13] vhost-user: handle VHOST_USER_RESET_OWNER correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 07:04:55 -0000 2015-10-09 13:46, Yuanhan Liu: > Destroy corresponding device when a VHOST_USER_RESET_OWNER message is > received, otherwise, the vhost-switch would still try to access vq > of that device, which results to SIGSEG fault, and let vhost-switch > crash in the end. It is a fix, so the title should look like: vhost: fix crash when receiving VHOST_USER_RESET_OWNER and there should be a "Fixes:" tag. Please could you also review the related patches from Jerome Jutteau? http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=354 Thanks