[dpdk-dev] [PATCH] kni: fix build with Linux 3.17

[dpdk-dev] [PATCH] kni: fix build with Linux 3.17

[Aaro Koskinen]

In the series of ever-lasting ugly #ifdefs trying make out-of-tree
drivers to support latest mainline kernel...

Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
---
 lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 1c085d9..ba77776 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -345,6 +345,9 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long ioctl_param)
 	up_read(&kni_list_lock);
 
 	net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
+#ifdef NET_NAME_UNKNOWN
+							NET_NAME_UNKNOWN,
+#endif
 							kni_net_init);
 	if (net_dev == NULL) {
 		KNI_ERR("error allocating device \"%s\"\n", dev_info.name);
-- 
2.0.0

Re: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaro Koskinen
> Sent: Monday, August 18, 2014 8:45 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
> 
> In the series of ever-lasting ugly #ifdefs trying make out-of-tree drivers to
> support latest mainline kernel...
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
> ---
>  lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
> b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 1c085d9..ba77776 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -345,6 +345,9 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long
> ioctl_param)
>  	up_read(&kni_list_lock);
> 
>  	net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
> +#ifdef NET_NAME_UNKNOWN
> +							NET_NAME_UNKNOWN,
> +#endif
>  							kni_net_init);
>  	if (net_dev == NULL) {
>  		KNI_ERR("error allocating device \"%s\"\n", dev_info.name);
> --
> 2.0.0

Will this interface be changed from kernel version 3.17?
Would it be better to add kernel version check here instead?

Regards,
Helin

Re: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17

[Thomas Monjalon]

> In the series of ever-lasting ugly #ifdefs trying make out-of-tree
> drivers to support latest mainline kernel...
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied with this commit log:
    Since Linux commit "set name_assign_type in alloc_netdev" (c835a677331495),
    the function alloc_netdev takes a new parameter (name_assign_type)
    whose default value is NET_NAME_UNKNOWN.

Thanks
-- 
Thomas