From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h
Date: Fri, 28 Nov 2014 15:16:22 +0100 [thread overview]
Message-ID: <2664831.CNeh3do0yF@xps13> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9B11F@SHSMSX101.ccr.corp.intel.com>
2014-11-28 02:09, Qiu, Michael:
> I have no comments on this issue, but I indeed see many places do have
> this kernel issue(before/now/future), so can solve this issue globally?
>
> Thus, we do not need to fix this case by case.
>
> One solution(not sure if it works or not):
>
> 1. features and kernel version required list.
> 2. When config DPDK before build, automatically check this list and if
> not mach, just disable this feature in config file even though user set
> it manually.
>
> Thus main code may not need to change.
>
> Does this works?
If configuration system was different, we could have a list of constraint
to satisfy before enabling a feature.
--
Thomas
next prev parent reply other threads:[~2014-11-28 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:14 Sujith Sankar
2014-11-27 17:22 ` Sujith Sankar (ssujith)
2014-11-27 18:01 ` Thomas Monjalon
2014-11-27 20:24 ` Thomas Monjalon
2014-11-28 2:31 ` Sujith Sankar (ssujith)
2014-11-28 2:09 ` Qiu, Michael
2014-11-28 14:16 ` Thomas Monjalon [this message]
2014-12-02 7:10 ` Qiu, Michael
2014-11-28 14:56 ` Neil Horman
2014-12-02 7:24 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664831.CNeh3do0yF@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).