From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 01AAE58E8 for ; Fri, 28 Nov 2014 15:16:46 +0100 (CET) Received: by mail-wg0-f50.google.com with SMTP id k14so8969290wgh.9 for ; Fri, 28 Nov 2014 06:16:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=x+LI2zpMqDirtueTWSwriUOvfkZjAcS6FAkHq2XaLsk=; b=Ocz3bHSFYSuZBCyk7+ZImnreiCr4d458XHeyJePE9ImoXOcRnJtvVb8FJF0vaYuvRz hho2Z3tBTwhhHnM+qGCynzXoHHzhof27LpUgtBojX2/eKtvB2GuVTGrd/pVu9QVbG6Eu jbINIW3CWVFzsaAH38H5X4oZWwuc//pXDuog36JXwzuFoUeCXODzwTNFOTaHOk0cGlLc SKrJKXEAMe+FuIXW7fQMGrJAk9b5qBBoDoOFRdfA0f/MpvN1E2joc2rnIGgoGXFA1nqm UqsKIDgnW8xdnud9O9rmin3bKdWyEWMJWI+1cif6ImY8OjDeb1SllxP7Nz+WIYGn0N7m 6JzQ== X-Gm-Message-State: ALoCoQkaw6aY4k2BFO8DsPjzQ6YhpqRw4bA5MiKauZM7SVtnXt10NJbWgDGRmvG14NlfNuIDsLDy X-Received: by 10.180.104.234 with SMTP id gh10mr59981151wib.3.1417184205861; Fri, 28 Nov 2014 06:16:45 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gf6sm2386505wjc.11.2014.11.28.06.16.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Nov 2014 06:16:45 -0800 (PST) From: Thomas Monjalon To: "Qiu, Michael" Date: Fri, 28 Nov 2014 15:16:22 +0100 Message-ID: <2664831.CNeh3do0yF@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9B11F@SHSMSX101.ccr.corp.intel.com> References: <1417108480-28341-1-git-send-email-ssujith@cisco.com> <533710CFB86FA344BFBF2D6802E60286C9B11F@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 14:16:46 -0000 2014-11-28 02:09, Qiu, Michael: > I have no comments on this issue, but I indeed see many places do have > this kernel issue(before/now/future), so can solve this issue globally? > > Thus, we do not need to fix this case by case. > > One solution(not sure if it works or not): > > 1. features and kernel version required list. > 2. When config DPDK before build, automatically check this list and if > not mach, just disable this feature in config file even though user set > it manually. > > Thus main code may not need to change. > > Does this works? If configuration system was different, we could have a list of constraint to satisfy before enabling a feature. -- Thomas