From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 946E21B644 for ; Tue, 6 Feb 2018 01:05:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3162920D1B; Mon, 5 Feb 2018 19:05:23 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 05 Feb 2018 19:05:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0eoHpBL7JSkGB7x7eLWCsJcpv0 g3H8PJeUHykFLLuJo=; b=NHymyoghLrWImbokTaa7vYx+BazEeHBTcZLZqgrSje 4LYnFJkXb66N26lbEamFYOm4sux/Bw1HWOjncsbj99uehVZ2ZTG32AJyr5cTPyrw aAT3tmDCqwadSRvkfV78rBBSupYa0/tPbWnm7XNhNXrU3c0QShCBAcXbRbMex7Qe E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0eoHpB L7JSkGB7x7eLWCsJcpv0g3H8PJeUHykFLLuJo=; b=ppRjLOrDfmLvsbVXMBlnEH d5+MzcsQ4wfIElP/f4Wz2VBP3Lkt29gi8tyQOARXjZNKEKortZ5fYP8N5ukm6So9 ZpfXqz3lLaD0yJ3yArsXzlvaDg55dpWLxwHWiuCbiUgsQhh+Qv6ecSunB2Ho5wdg JU8zSM951TT3KQGcYWg46m9Q/Kk1NCQym+NfOUfSel2L+3DU319mMqzYHMA7guQ8 KaJSyJdAACOXTagaicGywcgkNkNmkx32pxtRxGOf/jiorWwbTw8i4on6prd52fBY i4NfaqfNBPeZbTU1AmMb2WRIIjypUAF9mbPuPf9t+rtaew2BydVeZ1bSrzWDnVoA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D089E24108; Mon, 5 Feb 2018 19:05:22 -0500 (EST) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org, Olivier Matz , pbhagavatula@caviumnetworks.com, nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com Date: Tue, 06 Feb 2018 01:05:19 +0100 Message-ID: <26657316.2WP0XlBasG@xps> In-Reply-To: <20180202134007.qvip4jkiv2gksxoj@platinum> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> <20180202134007.qvip4jkiv2gksxoj@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 00:05:23 -0000 02/02/2018 14:40, Olivier Matz: > On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote: > > From: Nipun Gupta > > > > The existing rte_eal_mbuf_default mempool ops can return the compile time > > default ops name if the user has not provided command line inputs for > > mempool ops name. It will break the logic of best mempool ops as it will > > never return platform hw mempool ops. > > > > This patch introduces a new API to just return the user mempool ops only. > > > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name") > > > > Signed-off-by: Nipun Gupta > > This option is fine for me. I think we may also consider deprecating > rte_eal_mbuf_default_mempool_ops(), as it is done in option 2. > > Acked-by: Olivier Matz Applied, thanks