From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"johndale@cisco.com" <johndale@cisco.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
"alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
"sony.chacko@qlogic.com" <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v3] mbuf: new flag when Vlan is stripped
Date: Wed, 15 Jun 2016 17:20:33 +0200 [thread overview]
Message-ID: <26681669.pKzqhz6yqQ@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com>
2016-06-15 12:33, Ananyev, Konstantin:
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in
> > PMDs not advertising the same flags in similar conditions.
> >
> > Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED
> > and PKT_RX_QINQ_STRIPPED that are better defined:
> >
> > PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its
> > tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping
> > is enabled in the RX configuration of the PMD.
> >
> > For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated.
> > It should be removed from applications and PMDs in a future revision.
[...]
> > For PKT_RX_QINQ_PKT, it was only supported on i40e, and the behavior was
> > already correct, so we can reuse the same bit value for
> > PKT_RX_QINQ_STRIPPED.
> >
> > [1] http://dpdk.org/ml/archives/dev/2016-April/037837.html,
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-06-15 15:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 23:36 [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled John Daley (johndale)
2016-04-25 12:02 ` Ananyev, Konstantin
2016-04-25 13:50 ` Olivier Matz
2016-04-25 16:17 ` Ananyev, Konstantin
2016-04-26 0:16 ` John Daley (johndale)
2016-04-28 14:43 ` Olivier MATZ
2016-05-10 16:24 ` [dpdk-dev] [RFC] mbuf: new flag when vlan is stripped Olivier Matz
2016-05-12 20:36 ` John Daley (johndale)
2016-05-23 7:59 ` Olivier Matz
2016-05-23 8:46 ` [dpdk-dev] [PATCH] mbuf: new flag when Vlan " Olivier Matz
2016-05-23 8:59 ` Ananyev, Konstantin
2016-05-23 9:12 ` Olivier Matz
2016-05-23 9:23 ` Ananyev, Konstantin
2016-05-23 9:38 ` Olivier Matz
2016-05-23 9:20 ` Ananyev, Konstantin
2016-05-23 9:40 ` Olivier Matz
2016-05-27 14:33 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-06-13 11:41 ` Olivier Matz
2016-06-13 14:42 ` Ananyev, Konstantin
2016-06-13 16:07 ` Olivier Matz
2016-06-13 16:31 ` Ananyev, Konstantin
2016-06-14 8:32 ` Olivier MATZ
2016-06-14 9:15 ` Ananyev, Konstantin
2016-06-14 9:34 ` Olivier MATZ
2016-06-15 11:48 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2016-06-15 12:33 ` Ananyev, Konstantin
2016-06-15 15:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26681669.pKzqhz6yqQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).