From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D2D013576 for ; Fri, 1 Mar 2019 18:28:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 19B62220E3; Fri, 1 Mar 2019 12:28:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Mar 2019 12:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IhWRSD90GtpJRUWiydfk5gkM5eDvj9t2tdMz9FPRdCc=; b=LofwRRZDDWNo fbyNJUjhdMOLsKj9foy9L3n7epx8RF5NXw1i0dPPHvr/Uvd/IePQvMbUmQZbkCam 3VV0uwn2TzLXnxqPooIFEcewKeXUDM+0sAr3j4PxRawK0DO/WlTTt5hzv360BWMO oD/TSZ1YFHdzTzZTEjz013AbaQJ7mUU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IhWRSD90GtpJRUWiydfk5gkM5eDvj9t2tdMz9FPRd Cc=; b=MEsTIT81vWElvL1ZLYtqeP8gZzlWVGD9f7GdW5kaGR08Q+NRemjeip1fg FDOPrnKOL85uXSVPO6Bem75/Yb3qIXtH6cTcnb31tbaofTA++5DMbeGxBABTQGtM hXpjJ/nZ8BlvHYIYq+YelMYbj45WAyEZ1ZJbfIP9KycvYBnjALRR4DALCSlsgbNS nvZKZBL/jSEJKXntjoB9vJhYjNGlutAierwUlCB/5evAvHTJ4U3bA0GtqdNNDZzt mvU4RncMI2FixHlVFqj4sdABqPE1zQZaomZfH6AMY84AVZfl1zdkJXIWa/jymu1J RDEmCgCp4yhmLzH4KEch3wcUoh+QQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehmohhnjhgrlhhonhdrnhgvthdptggrvhhiuhhmnhgvthifohhrkhhsrdgt ohhmnecukfhppeejjedrudefiedrgedurdejtdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (70.41.136.77.rev.sfr.net [77.136.41.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 3873610328; Fri, 1 Mar 2019 12:28:44 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Jerin Jacob Kollanukkaran Cc: dev@dpdk.org Date: Fri, 01 Mar 2019 18:28:38 +0100 Message-ID: <2668267.HQ7s86BJXi@xps> In-Reply-To: <222b056a-2b09-f1db-fcd8-9ffe83152e5e@intel.com> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <20171011143352.GA23500@jerin> <222b056a-2b09-f1db-fcd8-9ffe83152e5e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 17:28:49 -0000 01/03/2019 18:05, Ferruh Yigit: > On 10/11/2017 3:33 PM, jerin.jacob at caviumnetworks.com (Jerin Jacob) wrote: > > From: Thomas Monjalon > >> 07/08/2017 14:04, Jerin Jacob: > >>> baremetal execution environments may have a different > >>> method to enable RTE_INIT instead of using compiler > >>> constructor scheme. Move RTE_INIT* definition under > >>> exec-env to support different execution environments. > >>> > >>> Signed-off-by: Jerin Jacob > >>> --- > >>> app/test-eventdev/evt_test.h | 2 +- > >>> lib/librte_eal/bsdapp/eal/Makefile | 2 +- > >>> .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > >>> lib/librte_eal/common/eal_common_log.c | 2 + > >>> lib/librte_eal/common/include/rte_bus.h | 2 + > >>> lib/librte_eal/common/include/rte_eal.h | 6 --- > >>> lib/librte_eal/common/include/rte_tailq.h | 2 + > >>> lib/librte_eal/linuxapp/eal/Makefile | 2 +- > >>> .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > >>> 9 files changed, 111 insertions(+), 9 deletions(-) > >>> create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_eal.h > >>> create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_eal.h > >> > >> I am not a big fan of duplicating code for Linux and BSD. > >> > >> Maybe we should have different splits and include a common file > >> in Linux and BSD? > > > > OK. This is doable. > > > >> > >> I feel it would be easier to think about the split when adding > >> a new environment. > >> It is also an open question whether we want to support (again) some > >> bare metal environments. > > > > IMO, A factor could be, how much we are OK to change? > > > > Our internal prototype implementation for a bare metal environment > > shows things are already in place and may need minor changes like this to > > accommodate a bare metal execution environment(accounting the latest > > changes of moving pci to driver/pci/..) > > > > If no one care about need for such abstraction then we could drop this > > patch. We can always keep local copy of such patches in our internal > > tree. I thought to upstream it as it may be useful for someone else and > > it is easy for us maintain if changes are in > > lib/librte_eal//eal/ and drivers/*/ > Hi Jerin, Thomas, > > This is an old patch, the abstraction seems good idea but it comes with a > duplication. > > Is there an intention to continue the work? Are we waiting for any decision? > Any objection to mark it as rejected? I am not sure there is a real desire to make DPDK ready for bare-metal (back again). If any of you are aware of a real use-case, we can re-consider.