From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7872F4609E; Thu, 16 Jan 2025 10:09:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64EC44060B; Thu, 16 Jan 2025 10:09:46 +0100 (CET) Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) by mails.dpdk.org (Postfix) with ESMTP id 4BC944025F for <dev@dpdk.org>; Thu, 16 Jan 2025 10:09:45 +0100 (CET) Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 70D3A25401AC; Thu, 16 Jan 2025 04:09:44 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 16 Jan 2025 04:09:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1737018584; x=1737104984; bh=pCB6DSWtX/OlAEj+7cgY77c4UHx7HZmSe8xOL7dAIf0=; b= KmaJiezKHEfACmSxKL3np65JOWKsclz55u34GkmAgPaEwmXRuoT3qFjL4pneBVsv irAcR+BTd7hTcxUwngxAKJ8eE9nwbD0VdLERXeawEx+tzZwDzdzyaA1Jgro6d5BQ d6Y5odtfK4eNlfuG41WERePIq0l/0LLo7BYHxOWGgzzOTp3P2XjRb7jX8mgBbAod f+aFXtlMbE60s3ZZVJPJPp64U0B+fnDDE5hG5XFrEIG5tiWZvqd5s4vtJcuweKjw dLT1Ad1DiE1uroL35F+1kBwVnhlfm2p/Sk2Mz8v3YWh9V8d/RZSmo1ne4xYQGLi9 1JitrTmL5n9QtOu3iBWayQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1737018584; x= 1737104984; bh=pCB6DSWtX/OlAEj+7cgY77c4UHx7HZmSe8xOL7dAIf0=; b=R JQJXl18q8jpPBzn4GFhujO2gvZ9ZaeToDLgAGJ3ge8R87OtTHuw3GzGeFbpEUYwB UO2CRfvKxVLSh2DaOTQoVOKNH/0pwnRcODJhk2z7gkLAL2mU+3qccet5P4oHMSmi yAK59WwXNm5ulUC7yvKpvryP8EKUWk5qawyOjndX5vSXRVB+9uPRHhYHvBuE/Hw+ 05jjTCcylFcL0O9v+VNNq9fP0ZtEtrFX1NvgeJ4p/hso6NPSQSnxXcanX0p4qbAo 2fsbkV4bC07jJKWpitZkXWmJpH91Dz+nP1bw+P8nvfyhVeZ9mIeGU0FB/w5+Yw1B 5i1mE/OWDUxLeUIPHNkNg== X-ME-Sender: <xms:18yIZ2Ff8he3RYTSAvu71Ye__9iqstB9fA4zSOk_hTxR9ylYFLYfsA> <xme:18yIZ3XeRUcSL_0gsEyPH5Kdrk6FnVrqHItc2DhkxW2lKF-gbbkDnTNvGeDzf4zUU lsfTelJXgf0ApjEQQ> X-ME-Received: <xmr:18yIZwIu2Z-10ciEHbcw8urUCRLhQ0LUlbBSjLjXrJK8-l5SwEezIVtggGLsrbYAhGr7XsX7EoSorklCbMsaVpObjQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeiudcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffrtefo kffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsuc dlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhr ohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonh drnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedt keeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghr tghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhihhhuihhsoh hngheshhhurgifvghirdgtohhmpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhr khhplhhumhgsvghrrdhorhhgpdhrtghpthhtoheplhhiuhihohhnghhlohhngheshhhurg ifvghirdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg X-ME-Proxy: <xmx:2MyIZwHPiZkeN14Q385w4umC6Oabut5OMCRFMYZeg9Jgcb5zwLh6JA> <xmx:2MyIZ8XN1x6kzESaps9vwGfXFGOX_ZhtPnDZYDNn6IktMS-HpAY3bw> <xmx:2MyIZzM3RA2b6qCKlgo2q8bjZqW2MlgpfgMZ61RgfwTecZUk8HCqXg> <xmx:2MyIZz3kRH93Prel3eT2c0BjWnmrUyfi2Es-RYDueZtxwrAbO6BVUg> <xmx:2MyIZ6zdZWYm_ncSyGZv4h4Rdu5bDMA-m_5VXeDpw9zipgwWl3Rg-oNr> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Jan 2025 04:09:43 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "lihuisong (C)" <lihuisong@huawei.com> Cc: stephen@networkplumber.org, liuyonglong@huawei.com, dev@dpdk.org Subject: Re: [PATCH v1 2/2] ethdev: fix some APIs can be used in the new event Date: Thu, 16 Jan 2025 10:09:40 +0100 Message-ID: <2673930.7s5MMGUR32@thomas> In-Reply-To: <4080a156-3031-fbb6-e7b9-fc511c398a87@huawei.com> References: <20250115034110.15245-1-lihuisong@huawei.com> <1837683.3VsfAaAtOV@thomas> <4080a156-3031-fbb6-e7b9-fc511c398a87@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 16/01/2025 07:14, lihuisong (C): > =E5=9C=A8 2025/1/15 19:36, Thomas Monjalon =E5=86=99=E9=81=93: > > 15/01/2025 04:41, Huisong Li: > >> The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after > >> allocating an ethdev. So this patch relaxes the conditions for using t= hem. > > You should be more explicit: > > "during probing, before it becomes generally available and considered a= s valid". > "During probing, before the port becomes generally available, its socket= =20 > id and owner id can be considered as valid." > How about say it like this? I prefer when you give the function names, it is more explicit.