From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id CBD45593E
 for <dev@dpdk.org>; Thu, 16 Oct 2014 22:26:31 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id h11so465648wiw.17
 for <dev@dpdk.org>; Thu, 16 Oct 2014 13:34:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=cjgX58WG1n3Jli6a4Ii0PYl7Vi1PpxO1WigXt1U082Y=;
 b=CH1nAaWSDZzcgEe44+wcQ1828p15K2AH9GPK6JY06zWpPwy7lYpOljRXF4EMRKfI23
 GIJT4QNu9Yb+j5DEZuBTud4yCYAOsTZmkMsWkGzrSJHDndw3thKgIQCS5HcPYt3+zK8v
 Qj/H2jooSMy/fYXans+dK+HMIXFsE0KXNa7QCRWQ4QHTZa31c/CyAonOKyBw28OKO7g1
 9LCDDT6AKDpPE+tGFq8/KbAL5lvJG09UvDRRMACuViKxFsAtjZipZQ1wnTP+OQNTOwdr
 gJ4UXiSZVr06vGBGPpc6qAf7Jhd8uOj57IMGBv9jNk7yzzcX0Tjz5NGrffIPZM79KT/m
 08jA==
X-Gm-Message-State: ALoCoQkj9LpA54+JODCh1/wG5YactP8j+fkypYnjTyYS4U7z6i/41boWV9Al3pN7ZgFyHLD1j23t
X-Received: by 10.180.99.67 with SMTP id eo3mr8859253wib.82.1413491666697;
 Thu, 16 Oct 2014 13:34:26 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id wc7sm21793602wjc.8.2014.10.16.13.34.25
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Oct 2014 13:34:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Date: Thu, 16 Oct 2014 22:34:09 +0200
Message-ID: <2679158.ldaB3mIRM3@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <1413006935-22535-8-git-send-email-jijiang.liu@intel.com>
References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com>
 <1413006935-22535-8-git-send-email-jijiang.liu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2014 20:26:31 -0000

2014-10-11 13:55, Jijiang Liu:
> Support VxLAN Tx checksum offload, which include
>   - outer L3(IP) checksum offload
>   - inner L3(IP) checksum offload
>   - inner L4(UDP, TCP and SCTP) checksum offload
[...]
> +
> +	/* fields to support tunnelling packet TX offloads */

I know that previous comment is "fields to support TX offloads",
but I'd prefer "for TX offloading of tunnels".
Maybe that "encapsulation" is better than "tunnel".
Just my opinion.

> +	union {
> +		/**< combined inner l2/l3 lengths as single var */
> +		uint16_t inner_l2_l3_len;
> +
> +		struct {
> +			/**< inner L3 (IP) Header Length. */
> +			uint16_t inner_l3_len:9;
> +
> +			/**< L2 (MAC) Header Length. */
> +			uint16_t inner_l2_len:7;
> +		};
> +	};

I would like to highlight that you are using 2 bytes in the second cache line
of the mbuf.
It deserves at least a line in the commit log.
Actually I'd prefer a separate patch for mbuf modifications.

Thanks
-- 
Thomas