From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id E4F295921 for ; Wed, 9 Dec 2015 21:03:23 +0100 (CET) Received: by wmww144 with SMTP id w144so88864350wmw.0 for ; Wed, 09 Dec 2015 12:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=hxRMuum2Pen8W/OsFADes7mlUuhVIfdoqFSI7ePVzv8=; b=cdTmQaGtyiRKn65v4ZiUzD9hMl8JSaVTqiTFzxWjST6mukKaNm3wP1fSdsM0VNzNgm MWakVTN9J02OUHhvv0Eg4ZxeX0utQKtboBkSujqXaGytmtFGTxTGbbTrKax2/pdwun7Y DRYOLgovOrbfUmLk4fykbA3W4z4gueyhJicQsu0tMPoQMmdEYp0K0gmCQE7jZKJC15fD iRY0QLwy1FMaozsc4MdeCix+nN/SaQ0FsRTbDBKLeV49GSdXqNXw0csMAJX6n6Mqz+09 lBF7cktN7ypelPnBuXF7QvmuIYgodjBl3YiB7wGJjKnpSOUe63qxw7rOFJ//Cdxredjs DJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hxRMuum2Pen8W/OsFADes7mlUuhVIfdoqFSI7ePVzv8=; b=OCc7BX9DJKEjHoQUDYWukc27JajPMpWDg1sYPIg/PjNAjr7U+9qh88sMmv/a0MQzqn ooFjZIcgz3+U9Y1UFXt42teCHIIePZNF9F5BqdOWgXPkiYVdFQRAsBxCwZ9tTYx1sFQ2 URynyisgOMFlpec/EoLlPQiyNjtfURIw5b5Xt+bQAlymdyN3Gk/gcvvGJXLqA9jz8XIa /ttQ6y5BdKNe/7nAJasu/Kt85rJFYvWQP10+/sUNm8eEy++ozlk2O1izfLGAQbWECemw oAnIIgsZDl9Gt2d8lQPdsy/jE54dJG5eg0LWD3qA/jKr4lev/UARN/RbagWkRhR2rUPj FceA== X-Gm-Message-State: ALoCoQl8Kc7Zp3l58WISwaCehvbmA6yhhXS1TqP5EwiB4SsUoSGMSh2Szve58kH1oKXWAwM7XKzHdMG5g3GTvyoFnskNqoH/Ew== X-Received: by 10.28.188.86 with SMTP id m83mr12622725wmf.51.1449691403740; Wed, 09 Dec 2015 12:03:23 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id c194sm9605500wmd.13.2015.12.09.12.03.22 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Dec 2015 12:03:22 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 09 Dec 2015 21:02:07 +0100 Message-ID: <2680132.Dfff00B3aA@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151208031208.GJ29571@yliu-dev.sh.intel.com> References: <1449535821-12384-1-git-send-email-stephen@networkplumber.org> <3746283.SiKfvnY0NL@xps13> <20151208031208.GJ29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, nlaw@brocade.com Subject: Re: [dpdk-dev] [PATCH] vhost: don't stall if guest is slow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 20:03:24 -0000 2015-12-08 11:12, Yuanhan Liu: > On Tue, Dec 08, 2015 at 03:30:43AM +0100, Thomas Monjalon wrote: > > 2015-12-08 10:23, Yuanhan Liu: > > > On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote: > > > > When guest is booting (or any othertime guest is busy) it is possible > > > > for the small receive ring (256) to get full. If this happens the > > > > vhost library should just return normally. It's current behavior > > > > of logging just creates massive log spew/overflow which could even > > > > act as a DoS attack against host. > > > > > > > > Reported-by: Nathan Law > > > > Signed-off-by: Stephen Hemminger > > > > > > Acked-by: Yuanhan Liu > > > > Yuanhan, please what is your opinion about the balance benefit/risk > > of this patch for 2.2? > > Thomas, > > I agree with Stephen that such log is not necessary as it's a fair > normal case. However, I see no too much benefit/risk for 2.2: it > just removes a debug log after all. Applied, thanks